Item::isReturned() - Code Metrics - Inspection of "OrderStatusDispatcher added. Tests added. Some ref..." - floor12/dalli-api - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 222832...e0456b )

by Evgenii

created 2020-08-08 11:33 UTC

Item::isReturned() A

↳ Parent: Item

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	1
c	0
b	0
f	0
nc	1
nop	0
dl	0
loc	3
rs	10
ccs	0
cts	0
cp	0
crap	2

<?php


namespace floor12\DalliApi\Models;


class Item extends BaseXmlObject
{
    /** @var string */
    public $title;
    /** @var int */
    public $_quantity = 1;
    /** @var float */
    public $_weight;
    /** @var int */
    public $_retprice;
    /** @var int */
    public $_barcode;
    /** @var string */
    public $_article;
    /** @var bool|null */
    public $_return;


    /**
     * @param int $quantity
     * @return Item
     */
    public function setQuantity(int $quantity)
    {
        $this->_quantity = $quantity;
        return $this;
    }

    /**
     * @param float $_weight
     * @return Item
     * @return Item
     */
    public function setWeight(float $_weight)
    {
        $this->_weight = $_weight;
        return $this;
    }

    /**
     * @param int $retprice
     * @return Item
     * @return Item
     */
    public function setRetprice(int $retprice)
    {
        $this->_retprice = $retprice;
        return $this;
    }

    /**
     * @param int $_barcode
     * @return Item
     * @return Item
     */
    public function setBarcode(int $_barcode)
    {
        $this->_barcode = $_barcode;
        return $this;
    }

    /**
     * @param string $_article
     * @return Item
     * @return Item
     */
    public function setArticle(string $_article)
    {
        $this->_article = $_article;
        return $this;
    }

    /**
     * @param string $title
     * @return self
     */
    public function setTitle(string $title): self
    {
        $this->title = $title;
        return $this;
    }

    /**
     * @param bool $return
     * @return self;
     */
    public function setReturn(bool $return): self
    {
        $this->_return = $return;
        return $this;
    }

    public function isReturned(): bool
    {
        return $this->_return;

    }
}


1		<?php
2
3
4		namespace floor12\DalliApi\Models;
5
6
7		class Item extends BaseXmlObject
8		{
9		/** @var string */
10		public $title;
11		/** @var int */
12		public $_quantity = 1;
13		/** @var float */
14		public $_weight;
15		/** @var int */
16		public $_retprice;
17		/** @var int */
18		public $_barcode;
19		/** @var string */
20		public $_article;
21		/** @var bool\|null */
22		public $_return;
23
24
25		/**
26		* @param int $quantity
27	2	* @return Item
28		*/
29	2	public function setQuantity(int $quantity)
30	2	{
31		$this->_quantity = $quantity;
32		return $this;
33		}
34
35		/**
36		* @param float $_weight
37		* @return Item
38	2	* @return Item
39		*/
40	2	public function setWeight(float $_weight)
41	2	{
42		$this->_weight = $_weight;
43		return $this;
44		}
45
46		/**
47		* @param int $retprice
48		* @return Item
49	2	* @return Item
50		*/
51	2	public function setRetprice(int $retprice)
52	2	{
53		$this->_retprice = $retprice;
54		return $this;
55		}
56
57		/**
58		* @param int $_barcode
59		* @return Item
60	3	* @return Item
61		*/
62	3	public function setBarcode(int $_barcode)
63	3	{
64		$this->_barcode = $_barcode;
65		return $this;
66		}
67
68		/**
69		* @param string $_article
70		* @return Item
71	1	* @return Item
72		*/
73	1	public function setArticle(string $_article)
74	1	{
75		$this->_article = $_article;
76		return $this;
77		}
78
79		/**
80		* @param string $title
81	1	* @return self
82		*/
83	1	public function setTitle(string $title): self
84	1	{
85		$this->title = $title;
86		return $this;
87		}
88
89		/**
90		* @param bool $return
91		* @return self;
92		*/
93		public function setReturn(bool $return): self
94		{
95		$this->_return = $return;
96		return $this;
97		}
98
99		public function isReturned(): bool
100		{
101		return $this->_return;
		0 ignored issues – show Bug Best Practice introduced 2020-08-08 11:36 UTC by Report Bug Copy Issue Report The expression `return $this->_return` could return the type `null` which is incompatible with the type-hinted return `boolean`. Consider adding an additional type-check to rule them out. Loading history...
102		}
103		}
104

floor12 / dalli-api

Push — master ( 222832...e0456b )

Item::isReturned() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like