Issues in ProviderIdentity.php (master) - Issues in master - flipboxfactory/saml-sp - Measure and Improve Code Quality continuously with Scrutinizer

Issues (20)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/services/ProviderIdentity.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Created by PhpStorm.
 * User: dsmrt
 * Date: 1/12/18
 * Time: 10:44 PM
 */

namespace flipbox\saml\sp\services;

use craft\elements\User;
use flipbox\saml\core\exceptions\InvalidMessage;
use flipbox\saml\core\helpers\MessageHelper;
use flipbox\saml\core\records\ProviderInterface;
use flipbox\saml\core\services\AbstractProviderIdentityService;
use flipbox\saml\sp\records\ProviderIdentityRecord;
use flipbox\saml\sp\records\ProviderRecord;
use flipbox\saml\sp\Saml;
use flipbox\saml\sp\services\login\AssertionTrait;
use flipbox\saml\sp\traits\SamlPluginEnsured;
use SAML2\Assertion;
use SAML2\Response as SamlResponse;
use yii\base\UserException;

/**
 * Class ProviderIdentity
 *
 * @package flipbox\saml\sp\services
 */
class ProviderIdentity extends AbstractProviderIdentityService
{

    use SamlPluginEnsured, AssertionTrait;

    /**
     * ACS Methods
     */

    /**
     * @param User $user
     * @param SamlResponse $response
     * @return ProviderIdentityRecord
     * @throws InvalidMessage
     * @throws UserException
     */
    public function getByUserAndResponse(
        User $user,
        SamlResponse $response,
        ProviderRecord $serviceProvider,
        ProviderRecord $idpProvider
    ) {

        $firstAssertion = $this->getFirstAssertion($response, $serviceProvider);

        // Get Identity
        $identity = $this->forceGet(
            $firstAssertion->getNameID()->getValue(),
            $idpProvider
        );

        // Get Session
        $sessionIndex = $firstAssertion->getSessionIndex();

        // Set Identity Properties
        $identity->userId = $user->id;
        $identity->enabled = true;
        $identity->sessionId = $sessionIndex;
        return $identity;
    }


    /**
     * @param string $nameId
     * @param ProviderInterface $provider
     * @return ProviderIdentityRecord
     * @throws UserException
     */
    protected function forceGet($nameId, ProviderInterface $provider)
    {
        // @var \flipbox\saml\sp\records\ProviderIdentityRecord $identity
        if (! $identity = $this->findByNameId(
            $nameId,
            $provider
        )->one()
        ) {

            /**
             * Create the new identity if one wasn't found above.
             * Since we now have the user id, and we might not have above,
             * do this last.
             */
            $identity = new ProviderIdentityRecord(
                [
                    'providerId' => $provider->id,
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                    'nameId' => $nameId,
                ]
            );
        }

        return $identity;
    }
}


1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: dsmrt
5		* Date: 1/12/18
6		* Time: 10:44 PM
7		*/
8
9		namespace flipbox\saml\sp\services;
10
11		use craft\elements\User;
12		use flipbox\saml\core\exceptions\InvalidMessage;
13		use flipbox\saml\core\helpers\MessageHelper;
14		use flipbox\saml\core\records\ProviderInterface;
15		use flipbox\saml\core\services\AbstractProviderIdentityService;
16		use flipbox\saml\sp\records\ProviderIdentityRecord;
17		use flipbox\saml\sp\records\ProviderRecord;
18		use flipbox\saml\sp\Saml;
19		use flipbox\saml\sp\services\login\AssertionTrait;
20		use flipbox\saml\sp\traits\SamlPluginEnsured;
21		use SAML2\Assertion;
22		use SAML2\Response as SamlResponse;
23		use yii\base\UserException;
24
25		/**
26		* Class ProviderIdentity
27		*
28		* @package flipbox\saml\sp\services
29		*/
30		class ProviderIdentity extends AbstractProviderIdentityService
31		{
32
33		use SamlPluginEnsured, AssertionTrait;
34
35		/**
36		* ACS Methods
37		*/
38
39		/**
40		* @param User $user
41		* @param SamlResponse $response
42		* @return ProviderIdentityRecord
43		* @throws InvalidMessage
44		* @throws UserException
45		*/
46	3	public function getByUserAndResponse(
47		User $user,
48		SamlResponse $response,
49		ProviderRecord $serviceProvider,
50		ProviderRecord $idpProvider
51		) {
52
53	3	$firstAssertion = $this->getFirstAssertion($response, $serviceProvider);
54
55		// Get Identity
56	3	$identity = $this->forceGet(
57	3	$firstAssertion->getNameID()->getValue(),
58	1	$idpProvider
59		);
60
61		// Get Session
62	3	$sessionIndex = $firstAssertion->getSessionIndex();
63
64		// Set Identity Properties
65	3	$identity->userId = $user->id;
66	3	$identity->enabled = true;
67	3	$identity->sessionId = $sessionIndex;
68	3	return $identity;
69		}
70
71
72		/**
73		* @param string $nameId
74		* @param ProviderInterface $provider
75		* @return ProviderIdentityRecord
76		* @throws UserException
77		*/
78	3	protected function forceGet($nameId, ProviderInterface $provider)
79		{
80		// @var \flipbox\saml\sp\records\ProviderIdentityRecord $identity
81	3	if (! $identity = $this->findByNameId(
82	3	$nameId,
83	1	$provider
84	3	)->one()
85		) {
86
87		/**
88		* Create the new identity if one wasn't found above.
89		* Since we now have the user id, and we might not have above,
90		* do this last.
91		*/
92	3	$identity = new ProviderIdentityRecord(
93		[
94	3	'providerId' => $provider->id,
		0 ignored issues – show Bug introduced 2018-04-19 23:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `id` on the interface `flipbox\saml\core\records\ProviderInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
95	3	'nameId' => $nameId,
96		]
97		);
98		}
99
100	3	return $identity;
101		}
102		}
103

flipboxfactory / saml-sp

Issues (20)

Security Analysis not enabled

src/services/ProviderIdentity.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like