for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
/**
* Created by PhpStorm.
* User: dsmrt
* Date: 3/9/18
* Time: 2:48 PM
*/
namespace flipbox\saml\core\controllers;
use Craft;
use craft\helpers\ArrayHelper;
use flipbox\saml\core\AbstractPlugin;
use flipbox\saml\core\traits\EnsureSamlPlugin;
use yii\base\Action;
* Class AbstractGeneralController
* @package flipbox\saml\core\controllers\cp\view
abstract class AbstractSettingsController extends AbstractController
{
use EnsureSamlPlugin;
* @return array
public function behaviors()
return ArrayHelper::merge(
parent::behaviors(),
[
'error' => [
'default' => 'save'
],
'redirect' => [
'only' => ['save'],
'actions' => [
'save' => [200]
]
'flash' => [
'save' => [
200 => \Craft::t('saml-sp', "Settings successfully updated."),
401 => \Craft::t('saml-sp', "Failed to update settings.")
);
}
protected function verbs(): array
return [
'save' => ['post', 'put']
];
* @return mixed
* @throws \yii\base\InvalidConfigException
public function actionSave()
$entityId = Craft::$app->request->getRequiredParam('entityId');
/** @var AbstractPlugin $plugin */
$plugin = $this->getSamlPlugin();
$plugin
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
$settings = [
'entityId' => $entityId
Craft::$app->plugins->savePluginSettings(
$this->getSamlPlugin(),
$settings
return $this->redirectToPostedUrl();
* @return bool
* @throws \yii\web\ForbiddenHttpException
public function checkUpdateAccess(): bool
return $this->checkAdminAccess();
flipboxfactory /
saml-core
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.