Completed
Push — master ( 5ed211...3493fc )
by Damien
06:37
created
src/services/messages/AbstractLogoutResponse.php 1 patch
Unused Use Statements   +4 added lines, -7 removed lines patch added patch discarded remove patch
@@ -7,19 +7,16 @@
 block discarded – undo
7 7
 namespace flipbox\saml\core\services\messages;
8 8
 
9 9
 
10
-use craft\base\Component;
11
-use flipbox\saml\core\AbstractPlugin;
12
-use flipbox\saml\core\helpers\SecurityHelper;
13
-use flipbox\saml\core\records\ProviderInterface;
14
-use flipbox\saml\core\traits\EnsureSamlPlugin;
15
-use LightSaml\Model\AbstractSamlModel;
16 10
 use LightSaml\Model\Assertion\Issuer;
17
-use LightSaml\Model\Assertion\NameID;
18 11
 use LightSaml\Model\Protocol\AbstractRequest;
19 12
 use LightSaml\Model\Protocol\LogoutRequest as LogoutRequestModel;
20 13
 use LightSaml\Model\Protocol\LogoutResponse;
21 14
 use LightSaml\Model\Protocol\StatusResponse;
22 15
 use LightSaml\SamlConstants;
16
+use flipbox\saml\core\AbstractPlugin;
17
+use flipbox\saml\core\helpers\SecurityHelper;
18
+use flipbox\saml\core\records\ProviderInterface;
19
+use flipbox\saml\core\traits\EnsureSamlPlugin;
23 20
 use yii\base\Event;
24 21
 
25 22
 abstract class AbstractLogoutResponse extends AbstractLogout implements SamlResponseInterface
Please login to merge, or discard this patch.
src/services/messages/AbstractMetadata.php 1 patch
Unused Use Statements   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -9,12 +9,6 @@  discard block
 block discarded – undo
9 9
 namespace flipbox\saml\core\services\messages;
10 10
 
11 11
 
12
-use craft\base\Component;
13
-use flipbox\keychain\records\KeyChainRecord;
14
-use flipbox\saml\core\AbstractPlugin;
15
-use flipbox\saml\core\services\traits\Metadata as MetadataTrait;
16
-use craft\helpers\UrlHelper;
17
-use flipbox\saml\core\traits\EnsureSamlPlugin;
18 12
 use LightSaml\Model\Metadata\AssertionConsumerService;
19 13
 use LightSaml\Model\Metadata\EntityDescriptor;
20 14
 use LightSaml\Model\Metadata\IdpSsoDescriptor;
@@ -22,6 +16,12 @@  discard block
 block discarded – undo
22 16
 use LightSaml\Model\Metadata\SingleSignOnService;
23 17
 use LightSaml\Model\Metadata\SpSsoDescriptor;
24 18
 use LightSaml\SamlConstants;
19
+use craft\base\Component;
20
+use craft\helpers\UrlHelper;
21
+use flipbox\keychain\records\KeyChainRecord;
22
+use flipbox\saml\core\AbstractPlugin;
23
+use flipbox\saml\core\services\traits\Metadata as MetadataTrait;
24
+use flipbox\saml\core\traits\EnsureSamlPlugin;
25 25
 use yii\base\Event;
26 26
 use yii\base\InvalidConfigException;
27 27
 
Please login to merge, or discard this patch.
src/services/ProviderServiceInterface.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,6 @@  discard block
 block discarded – undo
39 39
     public function save(AbstractProvider $record, $runValidation = true, $attributeNames = null);
40 40
 
41 41
     /**
42
-     * @param ProviderInterface $provider
43 42
      * @return bool|int
44 43
      */
45 44
     public function delete(ProviderInterface $record);
@@ -50,6 +49,7 @@  discard block
 block discarded – undo
50 49
      * @param bool $runValidation
51 50
      * @param array|null $attributeNames
52 51
      * @throws \Exception
52
+     * @return void
53 53
      */
54 54
     public function linkToKey(
55 55
         AbstractProvider $provider,
Please login to merge, or discard this patch.
Unused Use Statements   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -9,10 +9,10 @@
 block discarded – undo
9 9
 namespace flipbox\saml\core\services;
10 10
 
11 11
 
12
-use flipbox\saml\core\records\ProviderInterface;
13
-use flipbox\saml\core\records\AbstractProvider;
14
-use flipbox\keychain\records\KeyChainRecord;
15 12
 use LightSaml\Model\Metadata\EntityDescriptor;
13
+use flipbox\keychain\records\KeyChainRecord;
14
+use flipbox\saml\core\records\AbstractProvider;
15
+use flipbox\saml\core\records\ProviderInterface;
16 16
 
17 17
 interface ProviderServiceInterface
18 18
 {
Please login to merge, or discard this patch.
src/services/traits/Metadata.php 1 patch
Unused Use Statements   +3 added lines, -5 removed lines patch added patch discarded remove patch
@@ -8,13 +8,11 @@
 block discarded – undo
8 8
 
9 9
 namespace flipbox\saml\core\services\traits;
10 10
 
11
-use flipbox\saml\core\records\AbstractProvider;
12
-use flipbox\saml\core\SamlPluginInterface;
13
-use LightSaml\Model\Metadata\SSODescriptor;
14
-use flipbox\keychain\records\KeyChainRecord;
15
-use LightSaml\Model\Metadata\KeyDescriptor;
16 11
 use LightSaml\Credential\X509Certificate;
12
+use LightSaml\Model\Metadata\KeyDescriptor;
13
+use LightSaml\Model\Metadata\SSODescriptor;
17 14
 use LightSaml\SamlConstants;
15
+use flipbox\keychain\records\KeyChainRecord;
18 16
 
19 17
 
20 18
 trait Metadata
Please login to merge, or discard this patch.
src/services/traits/Security.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@  discard block
 block discarded – undo
9 9
 namespace flipbox\saml\core\services\traits;
10 10
 
11 11
 
12
-use flipbox\saml\core\models\ProviderInterface;
13 12
 use LightSaml\Credential\KeyHelper;
14 13
 use LightSaml\Credential\X509Certificate;
15 14
 use LightSaml\Credential\X509Credential;
@@ -20,6 +19,7 @@  discard block
 block discarded – undo
20 19
 use LightSaml\Model\Protocol\Response;
21 20
 use LightSaml\Model\Protocol\SamlMessage;
22 21
 use RobRichards\XMLSecLibs\XMLSecurityKey;
22
+use flipbox\saml\core\models\ProviderInterface;
23 23
 
24 24
 trait Security
25 25
 {
Please login to merge, or discard this patch.