MetadataOptions::setExpiryInterval() - Code Metrics - Inspection of "Metadata enhancements and bug fixes, and various i..." - flipboxfactory/saml-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ff11b3...fd6c95 )

by Damien

created 2020-01-08 07:25 UTC

MetadataOptions::setExpiryInterval() A

↳ Parent: MetadataOptions

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	9.7
c	0
b	0
f	0
cc	3
nc	3
nop	1

<?php


namespace flipbox\saml\core\models;

use yii\base\Model;

class MetadataOptions extends Model implements \JsonSerializable
{
    use JsonModel;
    /**
     * @var string
     */
    public $url;

    /**
     * @var string
     */
    protected $expiryInterval;

    /**
     * @var \DateTime
     */
    protected $expiryDate;

    /**
     * @param string|null $expiry
     * @return $this
     */
    public function setExpiryInterval($expiry)
    {
        if (! $expiry) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->expiryDate = null;
            return $this;
        }

        $this->expiryInterval = $expiry;

        $now = new \DateTime();

        if (is_null($this->expiryDate)) {
            $this->expiryDate = $now->add(new \DateInterval($this->expiryInterval));
        }

        return $this;
    }

    /**
     * @return string
     */
    public function getExpiryInterval()
    {
        return $this->expiryInterval;
    }

    /**
     * @return \DateTime
     */
    public function getExpiryDate()
    {
        return $this->expiryDate;
    }

    /**
     * @param string|null $expiry
     * @return \DateTime
     */
    public function setExpiryDate($expiry)
    {
        if (! $expiry) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return $this;
        }

        $this->expiryDate = new \DateTime($expiry);

        return $this;
    }

    /**
     * @return array
     */
    public function jsonSerialize()
    {
        $expiryDate = null;
        if ($this->expiryDate instanceof \DateTime) {
            $expiryDate = $this->expiryDate->format(\DateTime::ISO8601);
        }
        return [
            'expiryDate' => $expiryDate,
            'expiryInterval' => $this->getExpiryInterval(),
            'url' => $this->url,
        ];
    }
}


1			<?php
2
3
4			namespace flipbox\saml\core\models;
5
6			use yii\base\Model;
7
8			class MetadataOptions extends Model implements \JsonSerializable
9			{
10			use JsonModel;
11			/**
12			* @var string
13			*/
14			public $url;
15
16			/**
17			* @var string
18			*/
19			protected $expiryInterval;
20
21			/**
22			* @var \DateTime
23			*/
24			protected $expiryDate;
25
26			/**
27			* @param string\|null $expiry
28			* @return $this
29			*/
30			public function setExpiryInterval($expiry)
31			{
32			if (! $expiry) {
			0 ignored issues – show Bug Best Practice introduced 2020-01-08 07:36 UTC by Report Bug Copy Issue Report The expression `$expiry` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
33			$this->expiryDate = null;
34			return $this;
35			}
36
37			$this->expiryInterval = $expiry;
38
39			$now = new \DateTime();
40
41			if (is_null($this->expiryDate)) {
42			$this->expiryDate = $now->add(new \DateInterval($this->expiryInterval));
43			}
44
45			return $this;
46			}
47
48			/**
49			* @return string
50			*/
51			public function getExpiryInterval()
52			{
53			return $this->expiryInterval;
54			}
55
56			/**
57			* @return \DateTime
58			*/
59			public function getExpiryDate()
60			{
61			return $this->expiryDate;
62			}
63
64			/**
65			* @param string\|null $expiry
66			* @return \DateTime
67			*/
68			public function setExpiryDate($expiry)
69			{
70			if (! $expiry) {
			0 ignored issues – show Bug Best Practice introduced 2020-01-08 07:36 UTC by Report Bug Copy Issue Report The expression `$expiry` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
71			return $this;
72			}
73
74			$this->expiryDate = new \DateTime($expiry);
75
76			return $this;
77			}
78
79			/**
80			* @return array
81			*/
82			public function jsonSerialize()
83			{
84			$expiryDate = null;
85			if ($this->expiryDate instanceof \DateTime) {
86			$expiryDate = $this->expiryDate->format(\DateTime::ISO8601);
87			}
88			return [
89			'expiryDate' => $expiryDate,
90			'expiryInterval' => $this->getExpiryInterval(),
91			'url' => $this->url,
92			];
93			}
94			}
95

flipboxfactory / saml-core

Push — master ( ff11b3...fd6c95 )

MetadataOptions::setExpiryInterval() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like