Cp::getMappingAutoSuggestions() - Code Metrics - Inspection of "Enhancements to mapping and NameID customization." - flipboxfactory/saml-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0ca4f0...992805 )

by Damien

created 2019-05-17 05:19 UTC

Cp::getMappingAutoSuggestions() B

↳ Parent: Cp

Complexity

Conditions	4
Paths	6

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	59
rs	8.8945
c	0
b	0
f	0
cc	4
nc	6
nop	0

How to fix Long Method

<?php


namespace flipbox\saml\core\services;


use craft\base\Component;
use craft\elements\User;
use flipbox\saml\core\helpers\MappingHelper;

class Cp extends Component
{

    public function getMappingFieldOptions()
    {
        $user = new User();
        $options = [
            [
                'label' => $user->getAttributeLabel('firstName'),
                'value' => 'firstName',
            ],
            [
                'label' => $user->getAttributeLabel('lastName'),
                'value' => 'lastName',
            ],
            [
                'label' => $user->getAttributeLabel('email'),
                'value' => 'email',
            ],
            [
                'label' => $user->getAttributeLabel('username'),
                'value' => 'username',
            ],
            [
                'label' => $user->getAttributeLabel('uid'),
                'value' => 'uid',
            ],
            [
                'label' => $user->getAttributeLabel('id'),
                'value' => 'id',
            ],
        ];
        foreach ($user->getFieldLayout()->getFields() as $field) {
            if (MappingHelper::isSupportedField($field)) {
                $options[] = [
                    'label' => $field->name,
                    'value' => $field->handle,
                ];
            }
        }

        return $options;
    }

    public function getMappingAutoSuggestions()
    {
        $user = new User();
        $options = [
            [
                'hint' => $user->getAttributeLabel('firstName'),
                'name' => '{firstName}',
            ],
            [
                'hint' => $user->getAttributeLabel('lastName'),
                'name' => '{lastName}',
            ],
            [
                'hint' => $user->getAttributeLabel('email'),
                'name' => '{email}',
            ],
            [
                'hint' => $user->getAttributeLabel('username'),
                'name' => '{username}',
            ],
            [
                'hint' => $user->getAttributeLabel('uid'),
                'name' => '{uid}',
            ],
            [
                'hint' => $user->getAttributeLabel('id'),
                'name' => '{id}',
            ],
        ];

        $contentOptions = [];
        foreach ($user->getFieldLayout()->getFields() as $field) {
            if (! MappingHelper::isSupportedField($field)) {
                continue;
            }

            $fieldType = get_class($field);
            $contentOptions[] = [
                'hint' => $field->name . " ($fieldType)",
                'name' => '{' . $field->handle . '}',
            ];
        }

        $return = [
            [
                'label' => 'Standard Fields',
                'data' => $options,
            ],
        ];

        if (! empty($contentOptions)) {
            $return[] = [
                'label' => 'Content Fields',
                'data' => $contentOptions,
            ];
        }

        return $return;
    }

}

1			<?php
2
3
4			namespace flipbox\saml\core\services;
5
6
7			use craft\base\Component;
8			use craft\elements\User;
9			use flipbox\saml\core\helpers\MappingHelper;
10
11			class Cp extends Component
12			{
13
14			public function getMappingFieldOptions()
15			{
16			$user = new User();
17			$options = [
18			[
19			'label' => $user->getAttributeLabel('firstName'),
20			'value' => 'firstName',
21			],
22			[
23			'label' => $user->getAttributeLabel('lastName'),
24			'value' => 'lastName',
25			],
26			[
27			'label' => $user->getAttributeLabel('email'),
28			'value' => 'email',
29			],
30			[
31			'label' => $user->getAttributeLabel('username'),
32			'value' => 'username',
33			],
34			[
35			'label' => $user->getAttributeLabel('uid'),
36			'value' => 'uid',
37			],
38			[
39			'label' => $user->getAttributeLabel('id'),
40			'value' => 'id',
41			],
42			];
43			foreach ($user->getFieldLayout()->getFields() as $field) {
44			if (MappingHelper::isSupportedField($field)) {
45			$options[] = [
46			'label' => $field->name,
47			'value' => $field->handle,
48			];
49			}
50			}
51
52			return $options;
53			}
54
55			public function getMappingAutoSuggestions()
56			{
57			$user = new User();
58			$options = [
59			[
60			'hint' => $user->getAttributeLabel('firstName'),
61			'name' => '{firstName}',
62			],
63			[
64			'hint' => $user->getAttributeLabel('lastName'),
65			'name' => '{lastName}',
66			],
67			[
68			'hint' => $user->getAttributeLabel('email'),
69			'name' => '{email}',
70			],
71			[
72			'hint' => $user->getAttributeLabel('username'),
73			'name' => '{username}',
74			],
75			[
76			'hint' => $user->getAttributeLabel('uid'),
77			'name' => '{uid}',
78			],
79			[
80			'hint' => $user->getAttributeLabel('id'),
81			'name' => '{id}',
82			],
83			];
84
85			$contentOptions = [];
86			foreach ($user->getFieldLayout()->getFields() as $field) {
87			if (! MappingHelper::isSupportedField($field)) {
88			continue;
89			}
90
91			$fieldType = get_class($field);
92			$contentOptions[] = [
93			'hint' => $field->name . " ($fieldType)",
94			'name' => '{' . $field->handle . '}',
95			];
96			}
97
98			$return = [
99			[
100			'label' => 'Standard Fields',
101			'data' => $options,
102			],
103			];
104
105			if (! empty($contentOptions)) {
106			$return[] = [
107			'label' => 'Content Fields',
108			'data' => $contentOptions,
109			];
110			}
111
112			return $return;
113			}
114
115			}

flipboxfactory / saml-core

Push — master ( 0ca4f0...992805 )

Cp::getMappingAutoSuggestions() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like