for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace flipbox\saml\core\models;
use craft\elements\User;
use yii\base\Model;
class AttributeMap extends Model
{
/**
* @var string
*/
public $craftProperty;
public $attributeName;
public $templateOverride;
public function renderValue(User $user)
$value = null;
$value
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
if ($this->templateOverride) {
$value = \Craft::$app->view->renderObjectTemplate(
$this->templateOverride,
$user
);
} else {
$value = $user->{$this->craftProperty};
}
return $value;
flipboxfactory /
saml-core
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.