flipboxfactory / saml-core

src/services/Metadata.php

Unused Use Statements +4 added lines, -4 removed lines

@@ -2,10 +2,6 @@ 
 
 namespace flipbox\saml\core\services;
 
-use craft\base\Component;
-use flipbox\keychain\records\KeyChainRecord;
-use flipbox\saml\core\helpers\SecurityHelper;
-use flipbox\saml\core\models\SettingsInterface;
 use SAML2\Certificate\Key;
 use SAML2\Constants;
 use SAML2\XML\ds\KeyInfo;
@@ -17,6 +13,10 @@ 
 use SAML2\XML\md\KeyDescriptor;
 use SAML2\XML\md\SPSSODescriptor;
 use SAML2\XML\md\SSODescriptorType;
+use craft\base\Component;
+use flipbox\keychain\records\KeyChainRecord;
+use flipbox\saml\core\helpers\SecurityHelper;
+use flipbox\saml\core\models\SettingsInterface;
 use yii\base\Event;
 use yii\base\InvalidConfigException;
 

src/validators/Response.php

Unused Use Statements +3 added lines, -3 removed lines

@@ -3,13 +3,13 @@
 
 namespace flipbox\saml\core\validators;
 
-use flipbox\saml\core\records\AbstractProvider;
+use SAML2\Assertion\Validation\Result as AssertionResult;
 use SAML2\Configuration\Destination;
+use SAML2\Response as SamlResponse;
 use SAML2\Response\Validation\ConstraintValidator\DestinationMatches;
 use SAML2\Response\Validation\ConstraintValidator\IsSuccessful;
 use SAML2\Response\Validation\Result as ResponseResult;
-use SAML2\Assertion\Validation\Result as AssertionResult;
-use SAML2\Response as SamlResponse;
+use flipbox\saml\core\records\AbstractProvider;
 
 class Response
 {

src/controllers/cp/view/metadata/VariablesTrait.php

Unused Use Statements -2 removed lines

@@ -7,11 +7,9 @@
 namespace flipbox\saml\core\controllers\cp\view\metadata;
 
 use Craft;
-use craft\elements\User;
 use craft\helpers\UrlHelper;
 use flipbox\keychain\KeyChain;
 use flipbox\saml\core\AbstractPlugin;
-use flipbox\saml\core\helpers\MappingHelper;
 use flipbox\saml\core\models\SettingsInterface;
 use flipbox\saml\core\records\ProviderInterface;
 

src/migrations/m190516_200148_attribute_typo.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use craft\db\Migration;
 use flipbox\saml\core\records\AbstractProvider;
-use yii\db\Query;
 
 /**
  * mm190516_200148_attribute_typo migration.

src/controllers/cp/view/AbstractController.php

Doc Comments +1 added lines, -2 removed lines

@@ -124,7 +124,6 @@ 
 
     /**
      * @param ProviderInterface $provider
-     * @param array $variables
      * @return array
      */
     protected function addUrls(ProviderInterface $provider)
@@ -196,7 +195,7 @@ 
     }
 
     /**
-     * @param $endpoints
+     * @param EndpointType[] $endpoints
      * @return EndpointType|null
      */
     protected function getFirstEndpoint($endpoints)

Unused Use Statements +5 added lines, -5 removed lines

@@ -8,16 +8,16 @@
 
 namespace flipbox\saml\core\controllers\cp\view;
 
+use SAML2\XML\md\EndpointType;
+use SAML2\XML\md\IDPSSODescriptor;
+use SAML2\XML\md\IndexedEndpointType;
+use SAML2\XML\md\SPSSODescriptor;
 use flipbox\saml\core\AbstractPlugin;
-use flipbox\saml\core\controllers\AbstractController as BaseController;
 use flipbox\saml\core\EnsureSAMLPlugin;
+use flipbox\saml\core\controllers\AbstractController as BaseController;
 use flipbox\saml\core\models\AbstractSettings;
 use flipbox\saml\core\records\ProviderInterface;
 use flipbox\saml\core\web\assets\bundles\SamlCore;
-use SAML2\XML\md\EndpointType;
-use SAML2\XML\md\IDPSSODescriptor;
-use SAML2\XML\md\IndexedEndpointType;
-use SAML2\XML\md\SPSSODescriptor;
 
 /**
  * Class AbstractController

src/services/bindings/Factory.php

Doc Comments -1 removed lines

@@ -81,7 +81,6 @@
     }
 
     /**
-     * @param SamlMessage $message
      * @param AbstractProvider $provider
      * @return \SAML2\XML\md\IndexedEndpointType|null
      */

Unused Use Statements +5 added lines, -5 removed lines

@@ -2,18 +2,18 @@
 
 namespace flipbox\saml\core\services\bindings;
 
-use craft\base\Component;
-use flipbox\saml\core\exceptions\InvalidMetadata;
-use flipbox\saml\core\records\AbstractProvider;
-use flipbox\saml\core\records\ProviderInterface;
-use SAML2\Constants;
 use SAML2\AuthnRequest;
+use SAML2\Constants;
 use SAML2\HTTPPost;
 use SAML2\HTTPRedirect;
 use SAML2\LogoutRequest;
 use SAML2\LogoutResponse;
 use SAML2\Message as SamlMessage;
 use SAML2\Response;
+use craft\base\Component;
+use flipbox\saml\core\exceptions\InvalidMetadata;
+use flipbox\saml\core\records\AbstractProvider;
+use flipbox\saml\core\records\ProviderInterface;
 
 /**
  * Class Factory

src/services/messages/LogoutResponse.php

Unused Use Statements +2 added lines, -3 removed lines

@@ -6,12 +6,11 @@
 
 namespace flipbox\saml\core\services\messages;
 
+use SAML2\LogoutRequest;
+use SAML2\LogoutResponse as SamlLogoutResponse;
 use craft\base\Component;
 use flipbox\saml\core\models\SettingsInterface;
 use flipbox\saml\core\records\AbstractProvider;
-use SAML2\Constants;
-use SAML2\LogoutRequest;
-use SAML2\LogoutResponse as SamlLogoutResponse;
 use yii\base\Event;
 
 /**

src/AbstractPlugin.php

Unused Use Statements +5 added lines, -5 removed lines

@@ -7,25 +7,25 @@
 
 namespace flipbox\saml\core;
 
+use SAML2\Compat\AbstractContainer;
 use craft\base\Plugin;
 use craft\events\RegisterTemplateRootsEvent;
 use craft\events\RegisterUrlRulesEvent;
 use craft\helpers\StringHelper;
 use craft\helpers\UrlHelper;
-use craft\web\twig\variables\CraftVariable;
 use craft\web\View;
+use craft\web\twig\variables\CraftVariable;
 use flipbox\craft\psr3\Logger;
 use flipbox\saml\core\models\AbstractSettings;
 use flipbox\saml\core\models\SettingsInterface;
 use flipbox\saml\core\services\AbstractCp;
-use flipbox\saml\core\services\bindings\Factory;
 use flipbox\saml\core\services\Cp;
-use flipbox\saml\core\services\messages\LogoutRequest;
-use flipbox\saml\core\services\messages\LogoutResponse;
 use flipbox\saml\core\services\Metadata;
 use flipbox\saml\core\services\ProviderIdentityServiceInterface;
 use flipbox\saml\core\services\ProviderServiceInterface;
-use SAML2\Compat\AbstractContainer;
+use flipbox\saml\core\services\bindings\Factory;
+use flipbox\saml\core\services\messages\LogoutRequest;
+use flipbox\saml\core\services\messages\LogoutResponse;
 use yii\base\Event;
 
 /**

src/models/AbstractSettings.php

Doc Comments +3 added lines

@@ -152,6 +152,9 @@
         return $this->getMyType() === self::SP;
     }
 
+    /**
+     * @param string $url
+     */
     protected function buildEndpointUrl($url)
     {
         return sprintf('/%s/%s', $this->getEndpointPrefix(), $url);