| 1 | <?php |
||
| 19 | abstract class AbstractSettingsController extends AbstractController implements \flipbox\saml\core\EnsureSAMLPlugin |
||
| 20 | { |
||
| 21 | |||
| 22 | /** |
||
| 23 | * @return array |
||
| 24 | */ |
||
| 25 | protected function verbs(): array |
||
| 31 | |||
| 32 | /** |
||
| 33 | * @return mixed |
||
| 34 | * @throws \yii\base\InvalidConfigException |
||
| 35 | */ |
||
| 36 | public function actionSave() |
||
| 52 | |||
| 53 | /** |
||
| 54 | * @return bool |
||
| 55 | * @throws \yii\web\ForbiddenHttpException |
||
| 56 | */ |
||
| 57 | public function checkUpdateAccess(): bool |
||
| 61 | } |
||
| 62 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.