GeneralController::checkAdminAccess() - Code Metrics - flipboxfactory/organizations - Measure and Improve Code Quality continuously with Scrutinizer

GeneralController::checkAdminAccess() A
last analyzed 2020-10-27 19:36 UTC

↳ Parent: GeneralController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	5
ccs	0
cts	5
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	2

<?php

/**
 * @copyright  Copyright (c) Flipbox Digital Limited
 * @license    https://flipboxfactory.com/software/organization/license
 * @link       https://www.flipboxfactory.com/software/organization/
 */

namespace flipbox\organizations\cp\controllers\settings;

use Craft;
use craft\helpers\ArrayHelper;
use flipbox\organizations\cp\actions\general\Update;
use flipbox\organizations\cp\controllers\AbstractController;

/**
 * @author Flipbox Factory <[email protected]>
 * @since 1.0.0
 */
class GeneralController extends AbstractController
{
    /**
     * @return array
     */
    public function behaviors()
    {
        return ArrayHelper::merge(
            parent::behaviors(),
            [
                'error' => [
                    'default' => 'save'
                ],
                'redirect' => [
                    'only' => ['save'],
                    'actions' => [
                        'save' => [200]
                    ]
                ],
                'flash' => [
                    'actions' => [
                        'save' => [
                            200 => Craft::t('organizations', "Settings successfully updated."),
                            401 => Craft::t('organizations', "Failed to update settings.")
                        ]
                    ]
                ]
            ]
        );
    }

    /**
     * @return array
     */
    protected function verbs(): array
    {
        return [
            'save' => ['post', 'put']
        ];
    }

    /**
     * @return mixed
     * @throws \yii\base\InvalidConfigException
     */
    public function actionSave()
    {
        /** @var Update $action */
        $action = Craft::createObject([
            'class' => Update::class,
            'checkAccess' => [$this, 'checkUpdateAccess']
        ], [
            'update',
            $this
        ]);

        return $action->runWithParams([]);
    }

    /**
     * @return bool
     */
    public function checkUpdateAccess(): bool
    {
        return $this->checkAdminAccess();
    }

    /**
     * @return bool
     */
    protected function checkAdminAccess()
    {
        $this->requireLogin();
        return Craft::$app->getUser()->getIsAdmin();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


1			<?php
2
3			/**
4			* @copyright Copyright (c) Flipbox Digital Limited
5			* @license https://flipboxfactory.com/software/organization/license
6			* @link https://www.flipboxfactory.com/software/organization/
7			*/
8
9			namespace flipbox\organizations\cp\controllers\settings;
10
11			use Craft;
12			use craft\helpers\ArrayHelper;
13			use flipbox\organizations\cp\actions\general\Update;
14			use flipbox\organizations\cp\controllers\AbstractController;
15
16			/**
17			* @author Flipbox Factory <[email protected]>
18			* @since 1.0.0
19			*/
20			class GeneralController extends AbstractController
21			{
22			/**
23			* @return array
24			*/
25			public function behaviors()
26			{
27			return ArrayHelper::merge(
28			parent::behaviors(),
29			[
30			'error' => [
31			'default' => 'save'
32			],
33			'redirect' => [
34			'only' => ['save'],
35			'actions' => [
36			'save' => [200]
37			]
38			],
39			'flash' => [
40			'actions' => [
41			'save' => [
42			200 => Craft::t('organizations', "Settings successfully updated."),
43			401 => Craft::t('organizations', "Failed to update settings.")
44			]
45			]
46			]
47			]
48			);
49			}
50
51			/**
52			* @return array
53			*/
54			protected function verbs(): array
55			{
56			return [
57			'save' => ['post', 'put']
58			];
59			}
60
61			/**
62			* @return mixed
63			* @throws \yii\base\InvalidConfigException
64			*/
65			public function actionSave()
66			{
67			/** @var Update $action */
68			$action = Craft::createObject([
69			'class' => Update::class,
70			'checkAccess' => [$this, 'checkUpdateAccess']
71			], [
72			'update',
73			$this
74			]);
75
76			return $action->runWithParams([]);
77			}
78
79			/**
80			* @return bool
81			*/
82			public function checkUpdateAccess(): bool
83			{
84			return $this->checkAdminAccess();
85			}
86
87			/**
88			* @return bool
89			*/
90			protected function checkAdminAccess()
91			{
92			$this->requireLogin();
93			return Craft::$app->getUser()->getIsAdmin();
			0 ignored issues – show Bug introduced 2020-10-27 19:36 UTC by Report Bug Copy Issue Report The method `getUser` does only exist in `yii\web\Application`, but not in `yii\console\Application`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
94			}
95			}
96

flipboxfactory / organizations

GeneralController::checkAdminAccess() A last analyzed 2020-10-27 19:36 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

GeneralController::checkAdminAccess() A
last analyzed 2020-10-27 19:36 UTC