Issues in IntegrationAssociationQuery.php (master) - Issues in master - flipboxfactory/craft-integration - Measure and Improve Code Quality continuously with Scrutinizer

Issues (9)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/queries/IntegrationAssociationQuery.php (5 issues)

Labels

Bug 5

Severity

Minor 5

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * @copyright  Copyright (c) Flipbox Digital Limited
 * @license    https://github.com/flipboxfactory/craft-integration/blob/master/LICENSE
 * @link       https://github.com/flipboxfactory/craft-integration/
 */

namespace flipbox\craft\integration\queries;

use Craft;
use craft\db\QueryAbortedException;
use craft\helpers\Db;
use flipbox\craft\ember\queries\AuditAttributesTrait;
use flipbox\craft\ember\queries\CacheableActiveQuery;
use flipbox\craft\ember\queries\ElementAttributeTrait;
use flipbox\craft\ember\queries\FieldAttributeTrait;
use flipbox\craft\ember\queries\SiteAttributeTrait;
use flipbox\craft\integration\records\IntegrationAssociation;

/**
 * @author Flipbox Factory <[email protected]>
 * @since 2.0.0
 *
 * @method IntegrationAssociation[] getCachedResult()
 * @method IntegrationAssociation[] all()
 * @method IntegrationAssociation one()
 */
class IntegrationAssociationQuery extends CacheableActiveQuery
{
    use AuditAttributesTrait,
        FieldAttributeTrait,
        ElementAttributeTrait,
        ObjectAttributeTrait,
        SiteAttributeTrait;

    /**
     * The sort order attribute
     */
    const SORT_ORDER_ATTRIBUTE = 'sortOrder';

    /**
     * The sort order direction
     */
    const SORT_ORDER_DIRECTION = SORT_ASC;

    /**
     * @var int|null Sort order
     */
    public $sortOrder;

    /**
     * @inheritdoc
     */
    public function init()
    {
        parent::init();

        if ($this->select === null) {
            $this->select = ['*'];
        }

        if ($this->orderBy === null && static::SORT_ORDER_ATTRIBUTE !== null) {
            $this->orderBy = [static::SORT_ORDER_ATTRIBUTE => static::SORT_ORDER_DIRECTION];
        }
    }

    /**
     * @param $value
     * @return $this
     */
    public function sortOrder($value)
    {
        $this->sortOrder = $value;
        return $this;
    }

    /**
     * @param $value
     * @return $this
     */
    public function setSortOrder($value)
    {
        return $this->sortOrder($value);
    }

    /**
     * @inheritdoc
     * @throws QueryAbortedException
     */
    public function prepare($builder)
    {
        // Is the query already doomed?
        if (($this->field !== null && empty($this->field)) ||
            ($this->object !== null && empty($this->object)) ||
            ($this->element !== null && empty($this->element))
        ) {
            throw new QueryAbortedException();
        }

        if ($this->sortOrder !== null) {
            $this->andWhere(Db::parseParam(static::SORT_ORDER_ATTRIBUTE, $this->sortOrder));

        }

        $this->applyElementConditions();
        $this->applyFieldConditions();
        $this->applyObjectConditions();
        $this->applySiteConditions();
        $this->applyAuditAttributeConditions();

        return parent::prepare($builder);
    }

    /**
     * Apply attribute conditions
     */
    protected function applyElementConditions()
    {
        if ($this->element !== null) {
            $this->andWhere(Db::parseParam('elementId', $this->parseElementValue($this->element)));

        }
    }

    /**
     * Apply attribute conditions
     */
    protected function applyFieldConditions()
    {
        if ($this->field !== null) {
            $this->andWhere(Db::parseParam('fieldId', $this->parseFieldValue($this->field)));

        }
    }

    /**
     * Apply attribute conditions
     */
    protected function applySiteConditions()
    {
        if ($this->site !== null) {
            $this->andWhere(Db::parseParam('siteId', $this->parseSiteValue($this->site)));

        } else {
            $this->andWhere(Db::parseParam('siteId', Craft::$app->getSites()->currentSite->id));

        }
    }
}


1			<?php
2
3			/**
4			* @copyright Copyright (c) Flipbox Digital Limited
5			* @license https://github.com/flipboxfactory/craft-integration/blob/master/LICENSE
6			* @link https://github.com/flipboxfactory/craft-integration/
7			*/
8
9			namespace flipbox\craft\integration\queries;
10
11			use Craft;
12			use craft\db\QueryAbortedException;
13			use craft\helpers\Db;
14			use flipbox\craft\ember\queries\AuditAttributesTrait;
15			use flipbox\craft\ember\queries\CacheableActiveQuery;
16			use flipbox\craft\ember\queries\ElementAttributeTrait;
17			use flipbox\craft\ember\queries\FieldAttributeTrait;
18			use flipbox\craft\ember\queries\SiteAttributeTrait;
19			use flipbox\craft\integration\records\IntegrationAssociation;
20
21			/**
22			* @author Flipbox Factory <[email protected]>
23			* @since 2.0.0
24			*
25			* @method IntegrationAssociation[] getCachedResult()
26			* @method IntegrationAssociation[] all()
27			* @method IntegrationAssociation one()
28			*/
29			class IntegrationAssociationQuery extends CacheableActiveQuery
30			{
31			use AuditAttributesTrait,
32			FieldAttributeTrait,
33			ElementAttributeTrait,
34			ObjectAttributeTrait,
35			SiteAttributeTrait;
36
37			/**
38			* The sort order attribute
39			*/
40			const SORT_ORDER_ATTRIBUTE = 'sortOrder';
41
42			/**
43			* The sort order direction
44			*/
45			const SORT_ORDER_DIRECTION = SORT_ASC;
46
47			/**
48			* @var int\|null Sort order
49			*/
50			public $sortOrder;
51
52			/**
53			* @inheritdoc
54			*/
55			public function init()
56			{
57			parent::init();
58
59			if ($this->select === null) {
60			$this->select = ['*'];
61			}
62
63			if ($this->orderBy === null && static::SORT_ORDER_ATTRIBUTE !== null) {
64			$this->orderBy = [static::SORT_ORDER_ATTRIBUTE => static::SORT_ORDER_DIRECTION];
65			}
66			}
67
68			/**
69			* @param $value
70			* @return $this
71			*/
72			public function sortOrder($value)
73			{
74			$this->sortOrder = $value;
75			return $this;
76			}
77
78			/**
79			* @param $value
80			* @return $this
81			*/
82			public function setSortOrder($value)
83			{
84			return $this->sortOrder($value);
85			}
86
87			/**
88			* @inheritdoc
89			* @throws QueryAbortedException
90			*/
91			public function prepare($builder)
92			{
93			// Is the query already doomed?
94			if (($this->field !== null && empty($this->field)) \|\|
95			($this->object !== null && empty($this->object)) \|\|
96			($this->element !== null && empty($this->element))
97			) {
98			throw new QueryAbortedException();
99			}
100
101			if ($this->sortOrder !== null) {
102			$this->andWhere(Db::parseParam(static::SORT_ORDER_ATTRIBUTE, $this->sortOrder));
			0 ignored issues – show Bug introduced 2019-01-08 22:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\craft\helpers\Db::parse...BUTE, $this->sortOrder)` targeting `craft\helpers\Db::parseParam()` can also be of type `string`; however, `flipbox\craft\ember\quer...ActiveQuery::andWhere()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
103			}
104
105			$this->applyElementConditions();
106			$this->applyFieldConditions();
107			$this->applyObjectConditions();
108			$this->applySiteConditions();
109			$this->applyAuditAttributeConditions();
110
111			return parent::prepare($builder);
112			}
113
114			/**
115			* Apply attribute conditions
116			*/
117			protected function applyElementConditions()
118			{
119			if ($this->element !== null) {
120			$this->andWhere(Db::parseParam('elementId', $this->parseElementValue($this->element)));
			0 ignored issues – show Bug introduced 2019-01-08 22:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\craft\helpers\Db::parse...tValue($this->element))` targeting `craft\helpers\Db::parseParam()` can also be of type `string`; however, `flipbox\craft\ember\quer...ActiveQuery::andWhere()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
121			}
122			}
123
124			/**
125			* Apply attribute conditions
126			*/
127			protected function applyFieldConditions()
128			{
129			if ($this->field !== null) {
130			$this->andWhere(Db::parseParam('fieldId', $this->parseFieldValue($this->field)));
			0 ignored issues – show Bug introduced 2019-01-08 22:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\craft\helpers\Db::parse...eldValue($this->field))` targeting `craft\helpers\Db::parseParam()` can also be of type `string`; however, `flipbox\craft\ember\quer...ActiveQuery::andWhere()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
131			}
132			}
133
134			/**
135			* Apply attribute conditions
136			*/
137			protected function applySiteConditions()
138			{
139			if ($this->site !== null) {
140			$this->andWhere(Db::parseParam('siteId', $this->parseSiteValue($this->site)));
			0 ignored issues – show Bug introduced 2019-01-08 22:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\craft\helpers\Db::parse...SiteValue($this->site))` targeting `craft\helpers\Db::parseParam()` can also be of type `string`; however, `flipbox\craft\ember\quer...ActiveQuery::andWhere()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
141			} else {
142			$this->andWhere(Db::parseParam('siteId', Craft::$app->getSites()->currentSite->id));
			0 ignored issues – show Bug introduced 2019-01-08 22:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\craft\helpers\Db::parse...tes()->currentSite->id)` targeting `craft\helpers\Db::parseParam()` can also be of type `string`; however, `flipbox\craft\ember\quer...ActiveQuery::andWhere()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
143			}
144			}
145			}
146

flipboxfactory / craft-integration

Issues (9)

Security Analysis no request data

src/queries/IntegrationAssociationQuery.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like