Inspection of "moving destructive logic to ‘builder’ classes" - flipboxfactory/craft-hubspot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 639fa1...b48ec5 )

by Nate

created 2018-06-29 23:00 UTC

Status

Unused Use Statements +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -8,23 +8,23 @@
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources;
 
+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Create;
+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Delete;
+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Read;
+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Update;
+use League\Pipeline\PipelineBuilderInterface;
+use Psr\SimpleCache\CacheInterface;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\builders\CompanyBuilder;
 use flipbox\hubspot\builders\ObjectBuilderInterface;
 use flipbox\hubspot\connections\ConnectionInterface;
 use flipbox\hubspot\criteria\CompanyCriteria;
 use flipbox\hubspot\criteria\ObjectCriteriaInterface;
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\traits\CacheResolverTrait;
 use flipbox\hubspot\traits\ConnectionResolverTrait;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Create;
-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Delete;
-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Read;
-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Update;
-use League\Pipeline\PipelineBuilderInterface;
-use Psr\SimpleCache\CacheInterface;
 use yii\base\Component;
 
 /**

Please login to merge, or discard this patch.

src/services/resources/CompanyContacts.php 1 patch

Unused Use Statements +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -8,24 +8,24 @@
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources;
 
+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Add;
+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\All;
+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Remove;
+use League\Pipeline\PipelineBuilderInterface;
+use Psr\Http\Message\ResponseInterface;
+use Psr\SimpleCache\CacheInterface;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\builders\CompanyContactsBuilder;
 use flipbox\hubspot\builders\CompanyContactsBuilderInterface;
 use flipbox\hubspot\connections\ConnectionInterface;
 use flipbox\hubspot\criteria\CompanyContactsCriteria;
 use flipbox\hubspot\criteria\ObjectCriteriaInterface;
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\services\resources\traits\ReadObjectTrait;
 use flipbox\hubspot\traits\CacheResolverTrait;
 use flipbox\hubspot\traits\ConnectionResolverTrait;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Add;
-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\All;
-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Remove;
-use League\Pipeline\PipelineBuilderInterface;
-use Psr\Http\Message\ResponseInterface;
-use Psr\SimpleCache\CacheInterface;
 use yii\base\Component;
 
 /**

Please login to merge, or discard this patch.

src/services/resources/ContactListContacts.php 1 patch

Unused Use Statements +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -8,13 +8,18 @@  discard block
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources;
 
+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Add;
+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\All;
+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Remove;
+use League\Pipeline\PipelineBuilderInterface;
+use Psr\SimpleCache\CacheInterface;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\builders\ContactListContactsBuilder;
 use flipbox\hubspot\builders\ObjectBuilderInterface;
 use flipbox\hubspot\connections\ConnectionInterface;
 use flipbox\hubspot\criteria\ContactListContactsCriteria;
 use flipbox\hubspot\criteria\ObjectCriteriaInterface;
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\services\resources\traits\AddObjectTrait;
 use flipbox\hubspot\services\resources\traits\ReadObjectTrait;
@@ -22,11 +27,6 @@  discard block
 block discarded – undo
 use flipbox\hubspot\traits\CacheResolverTrait;
 use flipbox\hubspot\traits\ConnectionResolverTrait;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Add;
-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\All;
-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Remove;
-use League\Pipeline\PipelineBuilderInterface;
-use Psr\SimpleCache\CacheInterface;
 use yii\base\Component;
 
 /**

Please login to merge, or discard this patch.

src/services/resources/ContactLists.php 1 patch

Unused Use Statements +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -8,23 +8,23 @@
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources;
 
+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Create;
+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Delete;
+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Read;
+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Update;
+use League\Pipeline\PipelineBuilderInterface;
+use Psr\SimpleCache\CacheInterface;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\builders\ContactListBuilder;
 use flipbox\hubspot\builders\ObjectBuilderInterface;
 use flipbox\hubspot\connections\ConnectionInterface;
 use flipbox\hubspot\criteria\ContactListCriteria;
 use flipbox\hubspot\criteria\ObjectCriteriaInterface;
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\traits\CacheResolverTrait;
 use flipbox\hubspot\traits\ConnectionResolverTrait;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Create;
-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Delete;
-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Read;
-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Update;
-use League\Pipeline\PipelineBuilderInterface;
-use Psr\SimpleCache\CacheInterface;
 use yii\base\Component;
 
 /**

Please login to merge, or discard this patch.

src/services/resources/Contacts.php 1 patch

Unused Use Statements +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -8,23 +8,23 @@
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources;
 
+use Flipbox\Relay\HubSpot\Builder\Resources\Contact\Create;
+use Flipbox\Relay\HubSpot\Builder\Resources\Contact\Delete;
+use Flipbox\Relay\HubSpot\Builder\Resources\Contact\ReadById;
+use Flipbox\Relay\HubSpot\Builder\Resources\Contact\Update;
+use League\Pipeline\PipelineBuilderInterface;
+use Psr\SimpleCache\CacheInterface;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\builders\ContactBuilder;
 use flipbox\hubspot\builders\ObjectBuilderInterface;
 use flipbox\hubspot\connections\ConnectionInterface;
 use flipbox\hubspot\criteria\ContactCriteria;
 use flipbox\hubspot\criteria\ObjectCriteriaInterface;
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\traits\CacheResolverTrait;
 use flipbox\hubspot\traits\ConnectionResolverTrait;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use Flipbox\Relay\HubSpot\Builder\Resources\Contact\Create;
-use Flipbox\Relay\HubSpot\Builder\Resources\Contact\Delete;
-use Flipbox\Relay\HubSpot\Builder\Resources\Contact\ReadById;
-use Flipbox\Relay\HubSpot\Builder\Resources\Contact\Update;
-use League\Pipeline\PipelineBuilderInterface;
-use Psr\SimpleCache\CacheInterface;
 use yii\base\Component;
 
 /**

Please login to merge, or discard this patch.

src/services/resources/TimelineEvents.php 1 patch

Unused Use Statements +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -9,22 +9,22 @@
 block discarded – undo
 namespace flipbox\hubspot\services\resources;
 
 use Craft;
+use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Read;
+use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Upsert;
+use League\Pipeline\PipelineBuilderInterface;
+use Psr\Http\Message\ResponseInterface;
+use Psr\SimpleCache\CacheInterface;
 use craft\helpers\ArrayHelper;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\builders\TimelineEventBuilderInterface;
 use flipbox\hubspot\connections\IntegrationConnectionInterface;
 use flipbox\hubspot\criteria\TimelineEventCriteriaInterface;
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\queue\jobs\UpsertTimelineEvent;
 use flipbox\hubspot\traits\CacheResolverTrait;
 use flipbox\hubspot\traits\IntegrationConnectionResolverTrait;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Read;
-use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Upsert;
-use League\Pipeline\PipelineBuilderInterface;
-use Psr\Http\Message\ResponseInterface;
-use Psr\SimpleCache\CacheInterface;
 use yii\base\Component;
 
 /**

Please login to merge, or discard this patch.

src/services/resources/traits/AddObjectTrait.php 1 patch

Unused Use Statements +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -8,12 +8,12 @@
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources\traits;
 
-use flipbox\hubspot\builders\ObjectBuilderInterface;
-use flipbox\hubspot\connections\ConnectionInterface;
-use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
 use League\Pipeline\PipelineBuilderInterface;
 use Psr\Http\Message\ResponseInterface;
 use Psr\SimpleCache\CacheInterface;
+use flipbox\hubspot\builders\ObjectBuilderInterface;
+use flipbox\hubspot\connections\ConnectionInterface;
+use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
 
 /**
  * @author Flipbox Factory <[email protected]>

Please login to merge, or discard this patch.

src/services/resources/traits/DeleteObjectTrait.php 1 patch

Unused Use Statements +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -8,12 +8,12 @@
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources\traits;
 
-use flipbox\hubspot\builders\ObjectBuilderInterface;
-use flipbox\hubspot\connections\ConnectionInterface;
-use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
 use League\Pipeline\PipelineBuilderInterface;
 use Psr\Http\Message\ResponseInterface;
 use Psr\SimpleCache\CacheInterface;
+use flipbox\hubspot\builders\ObjectBuilderInterface;
+use flipbox\hubspot\connections\ConnectionInterface;
+use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
 
 /**
  * @author Flipbox Factory <[email protected]>

Please login to merge, or discard this patch.

src/services/resources/traits/RemoveObjectTrait.php 1 patch

Unused Use Statements +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -8,12 +8,12 @@
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources\traits;
 
-use flipbox\hubspot\builders\ObjectBuilderInterface;
-use flipbox\hubspot\connections\ConnectionInterface;
-use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
 use League\Pipeline\PipelineBuilderInterface;
 use Psr\Http\Message\ResponseInterface;
 use Psr\SimpleCache\CacheInterface;
+use flipbox\hubspot\builders\ObjectBuilderInterface;
+use flipbox\hubspot\connections\ConnectionInterface;
+use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
 
 /**
  * @author Flipbox Factory <[email protected]>

Please login to merge, or discard this patch.

		@@ -8,23 +8,23 @@
		block discarded – undo
8	8
9	9	namespace flipbox\hubspot\services\resources;
10	10
	11	+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Create;
	12	+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Delete;
	13	+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Read;
	14	+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Update;
	15	+use League\Pipeline\PipelineBuilderInterface;
	16	+use Psr\SimpleCache\CacheInterface;
	17	+use flipbox\hubspot\HubSpot;
11	18	use flipbox\hubspot\builders\CompanyBuilder;
12	19	use flipbox\hubspot\builders\ObjectBuilderInterface;
13	20	use flipbox\hubspot\connections\ConnectionInterface;
14	21	use flipbox\hubspot\criteria\CompanyCriteria;
15	22	use flipbox\hubspot\criteria\ObjectCriteriaInterface;
16	23	use flipbox\hubspot\helpers\TransformerHelper;
17		-use flipbox\hubspot\HubSpot;
18	24	use flipbox\hubspot\pipeline\Resource;
19	25	use flipbox\hubspot\traits\CacheResolverTrait;
20	26	use flipbox\hubspot\traits\ConnectionResolverTrait;
21	27	use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
22		-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Create;
23		-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Delete;
24		-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Read;
25		-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Update;
26		-use League\Pipeline\PipelineBuilderInterface;
27		-use Psr\SimpleCache\CacheInterface;
28	28	use yii\base\Component;
29	29
30	30	/**

		@@ -8,24 +8,24 @@
		block discarded – undo
8	8
9	9	namespace flipbox\hubspot\services\resources;
10	10
	11	+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Add;
	12	+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\All;
	13	+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Remove;
	14	+use League\Pipeline\PipelineBuilderInterface;
	15	+use Psr\Http\Message\ResponseInterface;
	16	+use Psr\SimpleCache\CacheInterface;
	17	+use flipbox\hubspot\HubSpot;
11	18	use flipbox\hubspot\builders\CompanyContactsBuilder;
12	19	use flipbox\hubspot\builders\CompanyContactsBuilderInterface;
13	20	use flipbox\hubspot\connections\ConnectionInterface;
14	21	use flipbox\hubspot\criteria\CompanyContactsCriteria;
15	22	use flipbox\hubspot\criteria\ObjectCriteriaInterface;
16	23	use flipbox\hubspot\helpers\TransformerHelper;
17		-use flipbox\hubspot\HubSpot;
18	24	use flipbox\hubspot\pipeline\Resource;
19	25	use flipbox\hubspot\services\resources\traits\ReadObjectTrait;
20	26	use flipbox\hubspot\traits\CacheResolverTrait;
21	27	use flipbox\hubspot\traits\ConnectionResolverTrait;
22	28	use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
23		-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Add;
24		-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\All;
25		-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Remove;
26		-use League\Pipeline\PipelineBuilderInterface;
27		-use Psr\Http\Message\ResponseInterface;
28		-use Psr\SimpleCache\CacheInterface;
29	29	use yii\base\Component;
30	30
31	31	/**

		@@ -8,13 +8,18 @@ discard block
		block discarded – undo
8	8
9	9	namespace flipbox\hubspot\services\resources;
10	10
	11	+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Add;
	12	+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\All;
	13	+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Remove;
	14	+use League\Pipeline\PipelineBuilderInterface;
	15	+use Psr\SimpleCache\CacheInterface;
	16	+use flipbox\hubspot\HubSpot;
11	17	use flipbox\hubspot\builders\ContactListContactsBuilder;
12	18	use flipbox\hubspot\builders\ObjectBuilderInterface;
13	19	use flipbox\hubspot\connections\ConnectionInterface;
14	20	use flipbox\hubspot\criteria\ContactListContactsCriteria;
15	21	use flipbox\hubspot\criteria\ObjectCriteriaInterface;
16	22	use flipbox\hubspot\helpers\TransformerHelper;
17		-use flipbox\hubspot\HubSpot;
18	23	use flipbox\hubspot\pipeline\Resource;
19	24	use flipbox\hubspot\services\resources\traits\AddObjectTrait;
20	25	use flipbox\hubspot\services\resources\traits\ReadObjectTrait;
		@@ -22,11 +27,6 @@ discard block
		block discarded – undo
22	27	use flipbox\hubspot\traits\CacheResolverTrait;
23	28	use flipbox\hubspot\traits\ConnectionResolverTrait;
24	29	use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
25		-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Add;
26		-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\All;
27		-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Remove;
28		-use League\Pipeline\PipelineBuilderInterface;
29		-use Psr\SimpleCache\CacheInterface;
30	30	use yii\base\Component;
31	31
32	32	/**

		@@ -9,22 +9,22 @@
		block discarded – undo
9	9	namespace flipbox\hubspot\services\resources;
10	10
11	11	use Craft;
	12	+use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Read;
	13	+use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Upsert;
	14	+use League\Pipeline\PipelineBuilderInterface;
	15	+use Psr\Http\Message\ResponseInterface;
	16	+use Psr\SimpleCache\CacheInterface;
12	17	use craft\helpers\ArrayHelper;
	18	+use flipbox\hubspot\HubSpot;
13	19	use flipbox\hubspot\builders\TimelineEventBuilderInterface;
14	20	use flipbox\hubspot\connections\IntegrationConnectionInterface;
15	21	use flipbox\hubspot\criteria\TimelineEventCriteriaInterface;
16	22	use flipbox\hubspot\helpers\TransformerHelper;
17		-use flipbox\hubspot\HubSpot;
18	23	use flipbox\hubspot\pipeline\Resource;
19	24	use flipbox\hubspot\queue\jobs\UpsertTimelineEvent;
20	25	use flipbox\hubspot\traits\CacheResolverTrait;
21	26	use flipbox\hubspot\traits\IntegrationConnectionResolverTrait;
22	27	use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
23		-use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Read;
24		-use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Upsert;
25		-use League\Pipeline\PipelineBuilderInterface;
26		-use Psr\Http\Message\ResponseInterface;
27		-use Psr\SimpleCache\CacheInterface;
28	28	use yii\base\Component;
29	29
30	30	/**

		@@ -8,12 +8,12 @@
		block discarded – undo
8	8
9	9	namespace flipbox\hubspot\services\resources\traits;
10	10
11		-use flipbox\hubspot\builders\ObjectBuilderInterface;
12		-use flipbox\hubspot\connections\ConnectionInterface;
13		-use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
14	11	use League\Pipeline\PipelineBuilderInterface;
15	12	use Psr\Http\Message\ResponseInterface;
16	13	use Psr\SimpleCache\CacheInterface;
	14	+use flipbox\hubspot\builders\ObjectBuilderInterface;
	15	+use flipbox\hubspot\connections\ConnectionInterface;
	16	+use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
17	17
18	18	/**
19	19	* @author Flipbox Factory <[email protected]>

flipboxfactory / craft-hubspot

Push — develop ( 639fa1...b48ec5 )

Status

Category

Unused Use Statements +7 added lines, -7 removed lines patch added patch discarded remove patch

Unused Use Statements +7 added lines, -7 removed lines patch added patch discarded remove patch

Unused Use Statements +6 added lines, -6 removed lines patch added patch discarded remove patch

Unused Use Statements +7 added lines, -7 removed lines patch added patch discarded remove patch

Unused Use Statements +7 added lines, -7 removed lines patch added patch discarded remove patch

Unused Use Statements +6 added lines, -6 removed lines patch added patch discarded remove patch

Unused Use Statements +3 added lines, -3 removed lines patch added patch discarded remove patch

Unused Use Statements +3 added lines, -3 removed lines patch added patch discarded remove patch

Unused Use Statements +3 added lines, -3 removed lines patch added patch discarded remove patch