Inspection of "return default object, if label not set" - flipboxfactory/craft-hubspot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 1c300a...c4976e )

by Nate

created 2018-08-02 01:24 UTC

Status

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -5,8 +5,8 @@
 block discarded – undo
 use Craft;
 use craft\base\ElementInterface;
 use craft\queue\BaseJob;
-use flipbox\hubspot\fields\Objects;
 use flipbox\hubspot\HubSpot;
+use flipbox\hubspot\fields\Objects;
 use yii\base\Component;
 use yii\base\InvalidConfigException;
 

Please login to merge, or discard this patch.

src/criteria/traits/TransformerCollectionTrait.php 1 patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch

@@ -9,7 +9,6 @@
 block discarded – undo
 namespace flipbox\hubspot\criteria\traits;
 
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\traits\TransformerResolverTrait;
 use flipbox\hubspot\transformers\collections\DynamicTransformerCollection;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
 

Please login to merge, or discard this patch.

src/pipeline/Resource.php 1 patch

Unused Use Statements +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -8,14 +8,14 @@
 block discarded – undo
 
 namespace flipbox\hubspot\pipeline;
 
-use flipbox\hubspot\HubSpot;
-use flipbox\hubspot\pipeline\pipelines\HttpPipeline;
-use flipbox\hubspot\pipeline\stages\TransformerCollectionStage;
-use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
 use Flipbox\Pipeline\Builders\BuilderTrait;
 use Flipbox\Skeleton\Object\AbstractObject;
 use League\Pipeline\PipelineBuilderInterface;
 use Psr\Log\LoggerInterface;
+use flipbox\hubspot\HubSpot;
+use flipbox\hubspot\pipeline\pipelines\HttpPipeline;
+use flipbox\hubspot\pipeline\stages\TransformerCollectionStage;
+use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
 
 /**
  * A Relay pipeline builder intended to make building the Relay and Pipeline easier.

Please login to merge, or discard this patch.

src/services/resources/Limit.php 1 patch

Unused Use Statements +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -8,19 +8,19 @@
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources;
 
+use Flipbox\Relay\Builder\RelayBuilderInterface;
+use Flipbox\Relay\HubSpot\Builder\Resources\Limit\Daily\Read;
+use League\Pipeline\PipelineBuilderInterface;
+use Psr\Http\Message\ResponseInterface;
+use Psr\SimpleCache\CacheInterface;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\connections\ConnectionInterface;
 use flipbox\hubspot\criteria\IntegrationAccessorInterface;
 use flipbox\hubspot\helpers\CacheHelper;
 use flipbox\hubspot\helpers\ConnectionHelper;
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use Flipbox\Relay\Builder\RelayBuilderInterface;
-use Flipbox\Relay\HubSpot\Builder\Resources\Limit\Daily\Read;
-use League\Pipeline\PipelineBuilderInterface;
-use Psr\Http\Message\ResponseInterface;
-use Psr\SimpleCache\CacheInterface;
 use yii\base\Component;
 
 /**

Please login to merge, or discard this patch.

src/services/resources/traits/ReadObjectTrait.php 1 patch

Unused Use Statements +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -8,18 +8,18 @@
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources\traits;
 
+use Flipbox\Relay\Builder\RelayBuilderInterface;
+use League\Pipeline\PipelineBuilderInterface;
+use Psr\Http\Message\ResponseInterface;
+use Psr\SimpleCache\CacheInterface;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\connections\ConnectionInterface;
 use flipbox\hubspot\criteria\ObjectAccessorInterface;
 use flipbox\hubspot\helpers\CacheHelper;
 use flipbox\hubspot\helpers\ConnectionHelper;
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use Flipbox\Relay\Builder\RelayBuilderInterface;
-use League\Pipeline\PipelineBuilderInterface;
-use Psr\Http\Message\ResponseInterface;
-use Psr\SimpleCache\CacheInterface;
 
 /**
  * @author Flipbox Factory <[email protected]>

Please login to merge, or discard this patch.

src/services/resources/CompanyContacts.php 1 patch

Unused Use Statements +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -8,6 +8,14 @@  discard block
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources;
 
+use Flipbox\Relay\Builder\RelayBuilderInterface;
+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Add;
+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\All;
+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Remove;
+use League\Pipeline\PipelineBuilderInterface;
+use Psr\Http\Message\ResponseInterface;
+use Psr\SimpleCache\CacheInterface;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\connections\ConnectionInterface;
 use flipbox\hubspot\criteria\CompanyContactsAccessor;
 use flipbox\hubspot\criteria\CompanyContactsMutator;
@@ -16,19 +24,11 @@  discard block
 block discarded – undo
 use flipbox\hubspot\helpers\CacheHelper;
 use flipbox\hubspot\helpers\ConnectionHelper;
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\services\resources\traits\ReadObjectTrait;
+use flipbox\hubspot\transformers\DynamicModelSuccess;
 use flipbox\hubspot\transformers\collections\DynamicTransformerCollection;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use flipbox\hubspot\transformers\DynamicModelSuccess;
-use Flipbox\Relay\Builder\RelayBuilderInterface;
-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Add;
-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\All;
-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Remove;
-use League\Pipeline\PipelineBuilderInterface;
-use Psr\Http\Message\ResponseInterface;
-use Psr\SimpleCache\CacheInterface;
 use yii\base\Component;
 
 /**

Please login to merge, or discard this patch.

src/services/resources/ContactListContacts.php 1 patch

Unused Use Statements +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -8,6 +8,14 @@  discard block
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources;
 
+use Flipbox\Relay\Builder\RelayBuilderInterface;
+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Add;
+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\All;
+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Remove;
+use League\Pipeline\PipelineBuilderInterface;
+use Psr\Http\Message\ResponseInterface;
+use Psr\SimpleCache\CacheInterface;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\connections\ConnectionInterface;
 use flipbox\hubspot\criteria\ContactListContactsAccessor;
 use flipbox\hubspot\criteria\ContactListContactsMutator;
@@ -16,19 +24,11 @@  discard block
 block discarded – undo
 use flipbox\hubspot\helpers\CacheHelper;
 use flipbox\hubspot\helpers\ConnectionHelper;
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\services\resources\traits\ReadObjectTrait;
+use flipbox\hubspot\transformers\DynamicModelSuccess;
 use flipbox\hubspot\transformers\collections\DynamicTransformerCollection;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use flipbox\hubspot\transformers\DynamicModelSuccess;
-use Flipbox\Relay\Builder\RelayBuilderInterface;
-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Add;
-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\All;
-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Remove;
-use League\Pipeline\PipelineBuilderInterface;
-use Psr\Http\Message\ResponseInterface;
-use Psr\SimpleCache\CacheInterface;
 use yii\base\Component;
 
 /**

Please login to merge, or discard this patch.

src/services/resources/TimelineEvents.php 1 patch

Unused Use Statements +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -9,21 +9,21 @@
 block discarded – undo
 namespace flipbox\hubspot\services\resources;
 
 use Craft;
+use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Read;
+use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Upsert;
+use League\Pipeline\PipelineBuilderInterface;
+use Psr\Http\Message\ResponseInterface;
+use Psr\SimpleCache\CacheInterface;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\connections\IntegrationConnectionInterface;
 use flipbox\hubspot\criteria\TimelineEventAccessorInterface;
 use flipbox\hubspot\criteria\TimelineEventMutatorInterface;
 use flipbox\hubspot\helpers\CacheHelper;
 use flipbox\hubspot\helpers\ConnectionHelper;
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\queue\jobs\UpsertTimelineEvent;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Read;
-use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Upsert;
-use League\Pipeline\PipelineBuilderInterface;
-use Psr\Http\Message\ResponseInterface;
-use Psr\SimpleCache\CacheInterface;
 use yii\base\Component;
 
 /**

Please login to merge, or discard this patch.

src/services/resources/traits/CreateObjectTrait.php 1 patch

Unused Use Statements +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -8,16 +8,16 @@
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources\traits;
 
+use Flipbox\Relay\Builder\RelayBuilderInterface;
+use League\Pipeline\PipelineBuilderInterface;
+use Psr\Http\Message\ResponseInterface;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\connections\ConnectionInterface;
 use flipbox\hubspot\criteria\ObjectMutatorInterface;
 use flipbox\hubspot\helpers\ConnectionHelper;
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use Flipbox\Relay\Builder\RelayBuilderInterface;
-use League\Pipeline\PipelineBuilderInterface;
-use Psr\Http\Message\ResponseInterface;
 
 /**
  * @author Flipbox Factory <[email protected]>

Please login to merge, or discard this patch.

		@@ -5,8 +5,8 @@
		block discarded – undo
5	5	use Craft;
6	6	use craft\base\ElementInterface;
7	7	use craft\queue\BaseJob;
8		-use flipbox\hubspot\fields\Objects;
9	8	use flipbox\hubspot\HubSpot;
	9	+use flipbox\hubspot\fields\Objects;
10	10	use yii\base\Component;
11	11	use yii\base\InvalidConfigException;
12	12

		@@ -9,7 +9,6 @@
		block discarded – undo
9	9	namespace flipbox\hubspot\criteria\traits;
10	10
11	11	use flipbox\hubspot\helpers\TransformerHelper;
12		-use flipbox\hubspot\traits\TransformerResolverTrait;
13	12	use flipbox\hubspot\transformers\collections\DynamicTransformerCollection;
14	13	use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
15	14

		@@ -8,14 +8,14 @@
		block discarded – undo
8	8
9	9	namespace flipbox\hubspot\pipeline;
10	10
11		-use flipbox\hubspot\HubSpot;
12		-use flipbox\hubspot\pipeline\pipelines\HttpPipeline;
13		-use flipbox\hubspot\pipeline\stages\TransformerCollectionStage;
14		-use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
15	11	use Flipbox\Pipeline\Builders\BuilderTrait;
16	12	use Flipbox\Skeleton\Object\AbstractObject;
17	13	use League\Pipeline\PipelineBuilderInterface;
18	14	use Psr\Log\LoggerInterface;
	15	+use flipbox\hubspot\HubSpot;
	16	+use flipbox\hubspot\pipeline\pipelines\HttpPipeline;
	17	+use flipbox\hubspot\pipeline\stages\TransformerCollectionStage;
	18	+use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
19	19
20	20	/**
21	21	* A Relay pipeline builder intended to make building the Relay and Pipeline easier.

		@@ -8,19 +8,19 @@
		block discarded – undo
8	8
9	9	namespace flipbox\hubspot\services\resources;
10	10
	11	+use Flipbox\Relay\Builder\RelayBuilderInterface;
	12	+use Flipbox\Relay\HubSpot\Builder\Resources\Limit\Daily\Read;
	13	+use League\Pipeline\PipelineBuilderInterface;
	14	+use Psr\Http\Message\ResponseInterface;
	15	+use Psr\SimpleCache\CacheInterface;
	16	+use flipbox\hubspot\HubSpot;
11	17	use flipbox\hubspot\connections\ConnectionInterface;
12	18	use flipbox\hubspot\criteria\IntegrationAccessorInterface;
13	19	use flipbox\hubspot\helpers\CacheHelper;
14	20	use flipbox\hubspot\helpers\ConnectionHelper;
15	21	use flipbox\hubspot\helpers\TransformerHelper;
16		-use flipbox\hubspot\HubSpot;
17	22	use flipbox\hubspot\pipeline\Resource;
18	23	use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
19		-use Flipbox\Relay\Builder\RelayBuilderInterface;
20		-use Flipbox\Relay\HubSpot\Builder\Resources\Limit\Daily\Read;
21		-use League\Pipeline\PipelineBuilderInterface;
22		-use Psr\Http\Message\ResponseInterface;
23		-use Psr\SimpleCache\CacheInterface;
24	24	use yii\base\Component;
25	25
26	26	/**

		@@ -8,18 +8,18 @@
		block discarded – undo
8	8
9	9	namespace flipbox\hubspot\services\resources\traits;
10	10
	11	+use Flipbox\Relay\Builder\RelayBuilderInterface;
	12	+use League\Pipeline\PipelineBuilderInterface;
	13	+use Psr\Http\Message\ResponseInterface;
	14	+use Psr\SimpleCache\CacheInterface;
	15	+use flipbox\hubspot\HubSpot;
11	16	use flipbox\hubspot\connections\ConnectionInterface;
12	17	use flipbox\hubspot\criteria\ObjectAccessorInterface;
13	18	use flipbox\hubspot\helpers\CacheHelper;
14	19	use flipbox\hubspot\helpers\ConnectionHelper;
15	20	use flipbox\hubspot\helpers\TransformerHelper;
16		-use flipbox\hubspot\HubSpot;
17	21	use flipbox\hubspot\pipeline\Resource;
18	22	use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
19		-use Flipbox\Relay\Builder\RelayBuilderInterface;
20		-use League\Pipeline\PipelineBuilderInterface;
21		-use Psr\Http\Message\ResponseInterface;
22		-use Psr\SimpleCache\CacheInterface;
23	23
24	24	/**
25	25	* @author Flipbox Factory <[email protected]>

		@@ -8,6 +8,14 @@ discard block
		block discarded – undo
8	8
9	9	namespace flipbox\hubspot\services\resources;
10	10
	11	+use Flipbox\Relay\Builder\RelayBuilderInterface;
	12	+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Add;
	13	+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\All;
	14	+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Remove;
	15	+use League\Pipeline\PipelineBuilderInterface;
	16	+use Psr\Http\Message\ResponseInterface;
	17	+use Psr\SimpleCache\CacheInterface;
	18	+use flipbox\hubspot\HubSpot;
11	19	use flipbox\hubspot\connections\ConnectionInterface;
12	20	use flipbox\hubspot\criteria\CompanyContactsAccessor;
13	21	use flipbox\hubspot\criteria\CompanyContactsMutator;
		@@ -16,19 +24,11 @@ discard block
		block discarded – undo
16	24	use flipbox\hubspot\helpers\CacheHelper;
17	25	use flipbox\hubspot\helpers\ConnectionHelper;
18	26	use flipbox\hubspot\helpers\TransformerHelper;
19		-use flipbox\hubspot\HubSpot;
20	27	use flipbox\hubspot\pipeline\Resource;
21	28	use flipbox\hubspot\services\resources\traits\ReadObjectTrait;
	29	+use flipbox\hubspot\transformers\DynamicModelSuccess;
22	30	use flipbox\hubspot\transformers\collections\DynamicTransformerCollection;
23	31	use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
24		-use flipbox\hubspot\transformers\DynamicModelSuccess;
25		-use Flipbox\Relay\Builder\RelayBuilderInterface;
26		-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Add;
27		-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\All;
28		-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Remove;
29		-use League\Pipeline\PipelineBuilderInterface;
30		-use Psr\Http\Message\ResponseInterface;
31		-use Psr\SimpleCache\CacheInterface;
32	32	use yii\base\Component;
33	33
34	34	/**

		@@ -9,21 +9,21 @@
		block discarded – undo
9	9	namespace flipbox\hubspot\services\resources;
10	10
11	11	use Craft;
	12	+use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Read;
	13	+use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Upsert;
	14	+use League\Pipeline\PipelineBuilderInterface;
	15	+use Psr\Http\Message\ResponseInterface;
	16	+use Psr\SimpleCache\CacheInterface;
	17	+use flipbox\hubspot\HubSpot;
12	18	use flipbox\hubspot\connections\IntegrationConnectionInterface;
13	19	use flipbox\hubspot\criteria\TimelineEventAccessorInterface;
14	20	use flipbox\hubspot\criteria\TimelineEventMutatorInterface;
15	21	use flipbox\hubspot\helpers\CacheHelper;
16	22	use flipbox\hubspot\helpers\ConnectionHelper;
17	23	use flipbox\hubspot\helpers\TransformerHelper;
18		-use flipbox\hubspot\HubSpot;
19	24	use flipbox\hubspot\pipeline\Resource;
20	25	use flipbox\hubspot\queue\jobs\UpsertTimelineEvent;
21	26	use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
22		-use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Read;
23		-use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Upsert;
24		-use League\Pipeline\PipelineBuilderInterface;
25		-use Psr\Http\Message\ResponseInterface;
26		-use Psr\SimpleCache\CacheInterface;
27	27	use yii\base\Component;
28	28
29	29	/**

		@@ -8,16 +8,16 @@
		block discarded – undo
8	8
9	9	namespace flipbox\hubspot\services\resources\traits;
10	10
	11	+use Flipbox\Relay\Builder\RelayBuilderInterface;
	12	+use League\Pipeline\PipelineBuilderInterface;
	13	+use Psr\Http\Message\ResponseInterface;
	14	+use flipbox\hubspot\HubSpot;
11	15	use flipbox\hubspot\connections\ConnectionInterface;
12	16	use flipbox\hubspot\criteria\ObjectMutatorInterface;
13	17	use flipbox\hubspot\helpers\ConnectionHelper;
14	18	use flipbox\hubspot\helpers\TransformerHelper;
15		-use flipbox\hubspot\HubSpot;
16	19	use flipbox\hubspot\pipeline\Resource;
17	20	use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
18		-use Flipbox\Relay\Builder\RelayBuilderInterface;
19		-use League\Pipeline\PipelineBuilderInterface;
20		-use Psr\Http\Message\ResponseInterface;
21	21
22	22	/**
23	23	* @author Flipbox Factory <[email protected]>

flipboxfactory / craft-hubspot

Push — develop ( 1c300a...c4976e )

Status

Category

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch

Unused Use Statements +4 added lines, -4 removed lines patch added patch discarded remove patch

Unused Use Statements +6 added lines, -6 removed lines patch added patch discarded remove patch

Unused Use Statements +5 added lines, -5 removed lines patch added patch discarded remove patch

Unused Use Statements +9 added lines, -9 removed lines patch added patch discarded remove patch

Unused Use Statements +9 added lines, -9 removed lines patch added patch discarded remove patch

Unused Use Statements +6 added lines, -6 removed lines patch added patch discarded remove patch

Unused Use Statements +4 added lines, -4 removed lines patch added patch discarded remove patch