CreateUpsertPayloadFromElement::__invoke() - Code Metrics - Inspection of "wip" - flipboxfactory/craft-hubspot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 2d4f17...d5975b )

by Nate

created 2019-03-06 23:09 UTC

CreateUpsertPayloadFromElement::__invoke() A

↳ Parent: CreateUpsertPayloadFromElement

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	25
ccs	0
cts	19
cp	0
rs	9.52
c	0
b	0
f	0
cc	1
nc	1
nop	2
crap	2

<?php

/**
 * @noinspection PhpUnusedParameterInspection
 *
 * @copyright  Copyright (c) Flipbox Digital Limited
 * @license    https://github.com/flipbox/hubspot/blob/master/LICENSE.md
 * @link       https://github.com/flipbox/hubspot
 */

namespace flipbox\craft\hubspot\transformers;

use craft\base\Element;
use craft\base\ElementInterface;
use flipbox\craft\hubspot\events\CreatePayloadFromElementEvent;
use flipbox\craft\hubspot\fields\Objects;
use flipbox\craft\hubspot\fields\ObjectsFieldInterface;
use flipbox\craft\hubspot\HubSpot;
use yii\base\BaseObject;

/**
 * @author Flipbox Factory <[email protected]>
 * @since 1.0.0
 */
class CreateUpsertPayloadFromElement extends BaseObject
{
    /**
     * An action used to assemble a unique event name.
     *
     * @var string
     */
    public $action;

    /**
     * @param ElementInterface|Element $element
     * @param ObjectsFieldInterface $field
     * @return array
     */
    public function __invoke(
        ElementInterface $element,
        ObjectsFieldInterface $field
    ): array {
        /** @var Objects $field */

        $event = new CreatePayloadFromElementEvent([
            'payload' => $this->createPayload($element, $field)
        ]);

        $name = $event::eventName(
            $field->handle,
            $this->action
        );

        HubSpot::info(sprintf(
            "Create payload: Event '%s', Element '%s'",
            $name,
            $element->id . ' - ' . $element->title
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        ), __METHOD__);

        $element->trigger($name, $event);

        return $event->getPayload();
    }

    /**
     * @param ElementInterface $element
     * @param ObjectsFieldInterface $field
     * @return array
     *
     * @noinspection PhpUnusedParameterInspection
     */
    public function createPayload(
        ElementInterface $element,

        ObjectsFieldInterface $field

    ): array {
        /** @var Element $element */

        return [];
    }
}


1			<?php
2
3			/**
4			* @noinspection PhpUnusedParameterInspection
5			*
6			* @copyright Copyright (c) Flipbox Digital Limited
7			* @license https://github.com/flipbox/hubspot/blob/master/LICENSE.md
8			* @link https://github.com/flipbox/hubspot
9			*/
10
11			namespace flipbox\craft\hubspot\transformers;
12
13			use craft\base\Element;
14			use craft\base\ElementInterface;
15			use flipbox\craft\hubspot\events\CreatePayloadFromElementEvent;
16			use flipbox\craft\hubspot\fields\Objects;
17			use flipbox\craft\hubspot\fields\ObjectsFieldInterface;
18			use flipbox\craft\hubspot\HubSpot;
19			use yii\base\BaseObject;
20
21			/**
22			* @author Flipbox Factory <[email protected]>
23			* @since 1.0.0
24			*/
25			class CreateUpsertPayloadFromElement extends BaseObject
26			{
27			/**
28			* An action used to assemble a unique event name.
29			*
30			* @var string
31			*/
32			public $action;
33
34			/**
35			* @param ElementInterface\|Element $element
36			* @param ObjectsFieldInterface $field
37			* @return array
38			*/
39			public function __invoke(
40			ElementInterface $element,
41			ObjectsFieldInterface $field
42			): array {
43			/** @var Objects $field */
44
45			$event = new CreatePayloadFromElementEvent([
46			'payload' => $this->createPayload($element, $field)
47			]);
48
49			$name = $event::eventName(
50			$field->handle,
51			$this->action
52			);
53
54			HubSpot::info(sprintf(
55			"Create payload: Event '%s', Element '%s'",
56			$name,
57			$element->id . ' - ' . $element->title
			0 ignored issues – show Bug introduced 2019-03-06 23:15 UTC by Report Bug Copy Issue Report Accessing `title` on the interface `craft\base\ElementInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
58			), __METHOD__);
59
60			$element->trigger($name, $event);
61
62			return $event->getPayload();
63			}
64
65			/**
66			* @param ElementInterface $element
67			* @param ObjectsFieldInterface $field
68			* @return array
69			*
70			* @noinspection PhpUnusedParameterInspection
71			*/
72			public function createPayload(
73			ElementInterface $element,
			1 ignored issue – show Unused Code introduced 2019-03-06 23:15 UTC by Report Bug Copy Issue Report The parameter `$element` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
74			ObjectsFieldInterface $field
			1 ignored issue – show Unused Code introduced 2019-03-06 23:15 UTC by Report Bug Copy Issue Report The parameter `$field` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
75			): array {
76			/** @var Element $element */
77
78			return [];
79			}
80			}
81

flipboxfactory / craft-hubspot

Push — develop ( 2d4f17...d5975b )

CreateUpsertPayloadFromElement::__invoke() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like