Inspection of "removing redundant logic" - flipboxfactory/craft-hubspot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( b48ec5...ad5b3d )

by Nate

created 2018-06-30 15:36 UTC

Status

Unused Use Statements -1 removed lines patch added patch discarded remove patch

@@ -9,7 +9,6 @@
 block discarded – undo
 namespace flipbox\hubspot\criteria\traits;
 
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\traits\TransformerResolverTrait;
 use flipbox\hubspot\transformers\collections\DynamicTransformerCollection;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
 

Please login to merge, or discard this patch.

src/helpers/TransformerHelper.php 1 patch

Unused Use Statements +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -8,11 +8,11 @@
 block discarded – undo
 
 namespace flipbox\hubspot\helpers;
 
+use Flipbox\Skeleton\Helpers\ObjectHelper;
+use Flipbox\Transform\Transformers\TransformerInterface;
 use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\transformers\collections\TransformerCollection;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use Flipbox\Skeleton\Helpers\ObjectHelper;
-use Flipbox\Transform\Transformers\TransformerInterface;
 
 /**
  * @author Flipbox Factory <[email protected]>

Please login to merge, or discard this patch.

src/pipeline/Resource.php 1 patch

Unused Use Statements +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -8,14 +8,14 @@
 block discarded – undo
 
 namespace flipbox\hubspot\pipeline;
 
-use flipbox\hubspot\HubSpot;
-use flipbox\hubspot\pipeline\pipelines\HttpPipeline;
-use flipbox\hubspot\pipeline\stages\TransformerCollectionStage;
-use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
 use Flipbox\Pipeline\Builders\BuilderTrait;
 use Flipbox\Skeleton\Object\AbstractObject;
 use League\Pipeline\PipelineBuilderInterface;
 use Psr\Log\LoggerInterface;
+use flipbox\hubspot\HubSpot;
+use flipbox\hubspot\pipeline\pipelines\HttpPipeline;
+use flipbox\hubspot\pipeline\stages\TransformerCollectionStage;
+use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
 
 /**
  * A Relay pipeline builder intended to make building the Relay and Pipeline easier.

Please login to merge, or discard this patch.

src/services/resources/CompanyContacts.php 1 patch

Unused Use Statements +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -8,6 +8,13 @@  discard block
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources;
 
+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Add;
+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\All;
+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Remove;
+use League\Pipeline\PipelineBuilderInterface;
+use Psr\Http\Message\ResponseInterface;
+use Psr\SimpleCache\CacheInterface;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\builders\CompanyContactsBuilder;
 use flipbox\hubspot\builders\CompanyContactsBuilderInterface;
 use flipbox\hubspot\connections\ConnectionInterface;
@@ -16,16 +23,9 @@  discard block
 block discarded – undo
 use flipbox\hubspot\helpers\CacheHelper;
 use flipbox\hubspot\helpers\ConnectionHelper;
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\services\resources\traits\ReadObjectTrait;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Add;
-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\All;
-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Remove;
-use League\Pipeline\PipelineBuilderInterface;
-use Psr\Http\Message\ResponseInterface;
-use Psr\SimpleCache\CacheInterface;
 use yii\base\Component;
 
 /**

Please login to merge, or discard this patch.

src/services/resources/ContactListContacts.php 1 patch

Unused Use Statements +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -8,6 +8,12 @@  discard block
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources;
 
+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Add;
+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\All;
+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Remove;
+use League\Pipeline\PipelineBuilderInterface;
+use Psr\SimpleCache\CacheInterface;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\builders\ContactListContactsBuilder;
 use flipbox\hubspot\builders\ObjectBuilderInterface;
 use flipbox\hubspot\connections\ConnectionInterface;
@@ -16,17 +22,11 @@  discard block
 block discarded – undo
 use flipbox\hubspot\helpers\CacheHelper;
 use flipbox\hubspot\helpers\ConnectionHelper;
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\services\resources\traits\AddObjectTrait;
 use flipbox\hubspot\services\resources\traits\ReadObjectTrait;
 use flipbox\hubspot\services\resources\traits\RemoveObjectTrait;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Add;
-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\All;
-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Remove;
-use League\Pipeline\PipelineBuilderInterface;
-use Psr\SimpleCache\CacheInterface;
 use yii\base\Component;
 
 /**

Please login to merge, or discard this patch.

src/services/resources/TimelineEvents.php 1 patch

Unused Use Statements +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -9,22 +9,22 @@
 block discarded – undo
 namespace flipbox\hubspot\services\resources;
 
 use Craft;
+use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Read;
+use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Upsert;
+use League\Pipeline\PipelineBuilderInterface;
+use Psr\Http\Message\ResponseInterface;
+use Psr\SimpleCache\CacheInterface;
 use craft\helpers\ArrayHelper;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\builders\TimelineEventBuilderInterface;
 use flipbox\hubspot\connections\IntegrationConnectionInterface;
 use flipbox\hubspot\criteria\TimelineEventCriteriaInterface;
 use flipbox\hubspot\helpers\CacheHelper;
 use flipbox\hubspot\helpers\ConnectionHelper;
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\queue\jobs\UpsertTimelineEvent;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Read;
-use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Upsert;
-use League\Pipeline\PipelineBuilderInterface;
-use Psr\Http\Message\ResponseInterface;
-use Psr\SimpleCache\CacheInterface;
 use yii\base\Component;
 
 /**

Please login to merge, or discard this patch.

src/services/resources/traits/CreateObjectTrait.php 1 patch

Unused Use Statements +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -8,16 +8,16 @@
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources\traits;
 
+use Flipbox\Relay\Builder\RelayBuilderInterface;
+use League\Pipeline\PipelineBuilderInterface;
+use Psr\Http\Message\ResponseInterface;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\builders\ObjectBuilderInterface;
 use flipbox\hubspot\connections\ConnectionInterface;
 use flipbox\hubspot\helpers\ConnectionHelper;
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use Flipbox\Relay\Builder\RelayBuilderInterface;
-use League\Pipeline\PipelineBuilderInterface;
-use Psr\Http\Message\ResponseInterface;
 
 /**
  * @author Flipbox Factory <[email protected]>

Please login to merge, or discard this patch.

src/services/resources/traits/DeleteObjectTrait.php 1 patch

Unused Use Statements +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -8,18 +8,18 @@
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources\traits;
 
+use Flipbox\Relay\Builder\RelayBuilderInterface;
+use League\Pipeline\PipelineBuilderInterface;
+use Psr\Http\Message\ResponseInterface;
+use Psr\SimpleCache\CacheInterface;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\builders\ObjectBuilderInterface;
 use flipbox\hubspot\connections\ConnectionInterface;
 use flipbox\hubspot\helpers\CacheHelper;
 use flipbox\hubspot\helpers\ConnectionHelper;
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use Flipbox\Relay\Builder\RelayBuilderInterface;
-use League\Pipeline\PipelineBuilderInterface;
-use Psr\Http\Message\ResponseInterface;
-use Psr\SimpleCache\CacheInterface;
 
 /**
  * @author Flipbox Factory <[email protected]>

Please login to merge, or discard this patch.

src/services/resources/traits/ReadObjectTrait.php 1 patch

Unused Use Statements +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -8,18 +8,18 @@
 block discarded – undo
 
 namespace flipbox\hubspot\services\resources\traits;
 
+use Flipbox\Relay\Builder\RelayBuilderInterface;
+use League\Pipeline\PipelineBuilderInterface;
+use Psr\Http\Message\ResponseInterface;
+use Psr\SimpleCache\CacheInterface;
+use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\connections\ConnectionInterface;
 use flipbox\hubspot\criteria\ObjectCriteriaInterface;
 use flipbox\hubspot\helpers\CacheHelper;
 use flipbox\hubspot\helpers\ConnectionHelper;
 use flipbox\hubspot\helpers\TransformerHelper;
-use flipbox\hubspot\HubSpot;
 use flipbox\hubspot\pipeline\Resource;
 use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
-use Flipbox\Relay\Builder\RelayBuilderInterface;
-use League\Pipeline\PipelineBuilderInterface;
-use Psr\Http\Message\ResponseInterface;
-use Psr\SimpleCache\CacheInterface;
 
 /**
  * @author Flipbox Factory <[email protected]>

Please login to merge, or discard this patch.

		@@ -9,7 +9,6 @@
		block discarded – undo
9	9	namespace flipbox\hubspot\criteria\traits;
10	10
11	11	use flipbox\hubspot\helpers\TransformerHelper;
12		-use flipbox\hubspot\traits\TransformerResolverTrait;
13	12	use flipbox\hubspot\transformers\collections\DynamicTransformerCollection;
14	13	use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
15	14

		@@ -8,11 +8,11 @@
		block discarded – undo
8	8
9	9	namespace flipbox\hubspot\helpers;
10	10
	11	+use Flipbox\Skeleton\Helpers\ObjectHelper;
	12	+use Flipbox\Transform\Transformers\TransformerInterface;
11	13	use flipbox\hubspot\HubSpot;
12	14	use flipbox\hubspot\transformers\collections\TransformerCollection;
13	15	use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
14		-use Flipbox\Skeleton\Helpers\ObjectHelper;
15		-use Flipbox\Transform\Transformers\TransformerInterface;
16	16
17	17	/**
18	18	* @author Flipbox Factory <[email protected]>

		@@ -8,14 +8,14 @@
		block discarded – undo
8	8
9	9	namespace flipbox\hubspot\pipeline;
10	10
11		-use flipbox\hubspot\HubSpot;
12		-use flipbox\hubspot\pipeline\pipelines\HttpPipeline;
13		-use flipbox\hubspot\pipeline\stages\TransformerCollectionStage;
14		-use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
15	11	use Flipbox\Pipeline\Builders\BuilderTrait;
16	12	use Flipbox\Skeleton\Object\AbstractObject;
17	13	use League\Pipeline\PipelineBuilderInterface;
18	14	use Psr\Log\LoggerInterface;
	15	+use flipbox\hubspot\HubSpot;
	16	+use flipbox\hubspot\pipeline\pipelines\HttpPipeline;
	17	+use flipbox\hubspot\pipeline\stages\TransformerCollectionStage;
	18	+use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
19	19
20	20	/**
21	21	* A Relay pipeline builder intended to make building the Relay and Pipeline easier.

		@@ -8,6 +8,13 @@ discard block
		block discarded – undo
8	8
9	9	namespace flipbox\hubspot\services\resources;
10	10
	11	+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Add;
	12	+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\All;
	13	+use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Remove;
	14	+use League\Pipeline\PipelineBuilderInterface;
	15	+use Psr\Http\Message\ResponseInterface;
	16	+use Psr\SimpleCache\CacheInterface;
	17	+use flipbox\hubspot\HubSpot;
11	18	use flipbox\hubspot\builders\CompanyContactsBuilder;
12	19	use flipbox\hubspot\builders\CompanyContactsBuilderInterface;
13	20	use flipbox\hubspot\connections\ConnectionInterface;
		@@ -16,16 +23,9 @@ discard block
		block discarded – undo
16	23	use flipbox\hubspot\helpers\CacheHelper;
17	24	use flipbox\hubspot\helpers\ConnectionHelper;
18	25	use flipbox\hubspot\helpers\TransformerHelper;
19		-use flipbox\hubspot\HubSpot;
20	26	use flipbox\hubspot\pipeline\Resource;
21	27	use flipbox\hubspot\services\resources\traits\ReadObjectTrait;
22	28	use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
23		-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Add;
24		-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\All;
25		-use Flipbox\Relay\HubSpot\Builder\Resources\Company\Contacts\Remove;
26		-use League\Pipeline\PipelineBuilderInterface;
27		-use Psr\Http\Message\ResponseInterface;
28		-use Psr\SimpleCache\CacheInterface;
29	29	use yii\base\Component;
30	30
31	31	/**

		@@ -8,6 +8,12 @@ discard block
		block discarded – undo
8	8
9	9	namespace flipbox\hubspot\services\resources;
10	10
	11	+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Add;
	12	+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\All;
	13	+use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Remove;
	14	+use League\Pipeline\PipelineBuilderInterface;
	15	+use Psr\SimpleCache\CacheInterface;
	16	+use flipbox\hubspot\HubSpot;
11	17	use flipbox\hubspot\builders\ContactListContactsBuilder;
12	18	use flipbox\hubspot\builders\ObjectBuilderInterface;
13	19	use flipbox\hubspot\connections\ConnectionInterface;
		@@ -16,17 +22,11 @@ discard block
		block discarded – undo
16	22	use flipbox\hubspot\helpers\CacheHelper;
17	23	use flipbox\hubspot\helpers\ConnectionHelper;
18	24	use flipbox\hubspot\helpers\TransformerHelper;
19		-use flipbox\hubspot\HubSpot;
20	25	use flipbox\hubspot\pipeline\Resource;
21	26	use flipbox\hubspot\services\resources\traits\AddObjectTrait;
22	27	use flipbox\hubspot\services\resources\traits\ReadObjectTrait;
23	28	use flipbox\hubspot\services\resources\traits\RemoveObjectTrait;
24	29	use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
25		-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Add;
26		-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\All;
27		-use Flipbox\Relay\HubSpot\Builder\Resources\ContactList\Contacts\Remove;
28		-use League\Pipeline\PipelineBuilderInterface;
29		-use Psr\SimpleCache\CacheInterface;
30	30	use yii\base\Component;
31	31
32	32	/**

		@@ -9,22 +9,22 @@
		block discarded – undo
9	9	namespace flipbox\hubspot\services\resources;
10	10
11	11	use Craft;
	12	+use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Read;
	13	+use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Upsert;
	14	+use League\Pipeline\PipelineBuilderInterface;
	15	+use Psr\Http\Message\ResponseInterface;
	16	+use Psr\SimpleCache\CacheInterface;
12	17	use craft\helpers\ArrayHelper;
	18	+use flipbox\hubspot\HubSpot;
13	19	use flipbox\hubspot\builders\TimelineEventBuilderInterface;
14	20	use flipbox\hubspot\connections\IntegrationConnectionInterface;
15	21	use flipbox\hubspot\criteria\TimelineEventCriteriaInterface;
16	22	use flipbox\hubspot\helpers\CacheHelper;
17	23	use flipbox\hubspot\helpers\ConnectionHelper;
18	24	use flipbox\hubspot\helpers\TransformerHelper;
19		-use flipbox\hubspot\HubSpot;
20	25	use flipbox\hubspot\pipeline\Resource;
21	26	use flipbox\hubspot\queue\jobs\UpsertTimelineEvent;
22	27	use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
23		-use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Read;
24		-use Flipbox\Relay\HubSpot\Builder\Resources\Timeline\Event\Upsert;
25		-use League\Pipeline\PipelineBuilderInterface;
26		-use Psr\Http\Message\ResponseInterface;
27		-use Psr\SimpleCache\CacheInterface;
28	28	use yii\base\Component;
29	29
30	30	/**

		@@ -8,16 +8,16 @@
		block discarded – undo
8	8
9	9	namespace flipbox\hubspot\services\resources\traits;
10	10
	11	+use Flipbox\Relay\Builder\RelayBuilderInterface;
	12	+use League\Pipeline\PipelineBuilderInterface;
	13	+use Psr\Http\Message\ResponseInterface;
	14	+use flipbox\hubspot\HubSpot;
11	15	use flipbox\hubspot\builders\ObjectBuilderInterface;
12	16	use flipbox\hubspot\connections\ConnectionInterface;
13	17	use flipbox\hubspot\helpers\ConnectionHelper;
14	18	use flipbox\hubspot\helpers\TransformerHelper;
15		-use flipbox\hubspot\HubSpot;
16	19	use flipbox\hubspot\pipeline\Resource;
17	20	use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
18		-use Flipbox\Relay\Builder\RelayBuilderInterface;
19		-use League\Pipeline\PipelineBuilderInterface;
20		-use Psr\Http\Message\ResponseInterface;
21	21
22	22	/**
23	23	* @author Flipbox Factory <[email protected]>

		@@ -8,18 +8,18 @@
		block discarded – undo
8	8
9	9	namespace flipbox\hubspot\services\resources\traits;
10	10
	11	+use Flipbox\Relay\Builder\RelayBuilderInterface;
	12	+use League\Pipeline\PipelineBuilderInterface;
	13	+use Psr\Http\Message\ResponseInterface;
	14	+use Psr\SimpleCache\CacheInterface;
	15	+use flipbox\hubspot\HubSpot;
11	16	use flipbox\hubspot\builders\ObjectBuilderInterface;
12	17	use flipbox\hubspot\connections\ConnectionInterface;
13	18	use flipbox\hubspot\helpers\CacheHelper;
14	19	use flipbox\hubspot\helpers\ConnectionHelper;
15	20	use flipbox\hubspot\helpers\TransformerHelper;
16		-use flipbox\hubspot\HubSpot;
17	21	use flipbox\hubspot\pipeline\Resource;
18	22	use flipbox\hubspot\transformers\collections\TransformerCollectionInterface;
19		-use Flipbox\Relay\Builder\RelayBuilderInterface;
20		-use League\Pipeline\PipelineBuilderInterface;
21		-use Psr\Http\Message\ResponseInterface;
22		-use Psr\SimpleCache\CacheInterface;
23	23
24	24	/**
25	25	* @author Flipbox Factory <[email protected]>

flipboxfactory / craft-hubspot

Push — develop ( b48ec5...ad5b3d )

Status

Category

Unused Use Statements -1 removed lines patch added patch discarded remove patch

Unused Use Statements +2 added lines, -2 removed lines patch added patch discarded remove patch

Unused Use Statements +4 added lines, -4 removed lines patch added patch discarded remove patch

Unused Use Statements +7 added lines, -7 removed lines patch added patch discarded remove patch

Unused Use Statements +6 added lines, -6 removed lines patch added patch discarded remove patch

Unused Use Statements +6 added lines, -6 removed lines patch added patch discarded remove patch

Unused Use Statements +4 added lines, -4 removed lines patch added patch discarded remove patch

Unused Use Statements +5 added lines, -5 removed lines patch added patch discarded remove patch

Unused Use Statements +5 added lines, -5 removed lines patch added patch discarded remove patch