ElementCriteriaTrait::resolveCriteria() - Code Metrics - Inspection of "adding relay-hubspot as a dependency" - flipboxfactory/craft-hubspot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( f37ae4...1d947e )

by Nate

created 2018-06-26 19:44 UTC

ElementCriteriaTrait::resolveCriteria() A

↳ Parent: ElementCriteriaTrait

Complexity

Conditions	5
Paths	6

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

Metric	Value
dl	0
loc	24
ccs	0
cts	18
cp	0
rs	9.2248
c	0
b	0
f	0
cc	5
nc	6
nop	2
crap	30

<?php

/**
 * @copyright  Copyright (c) Flipbox Digital Limited
 * @license    https://flipboxfactory.com/software/hubspot/license
 * @link       https://www.flipboxfactory.com/software/hubspot/
 */

namespace flipbox\hubspot\services\resources\traits;

use flipbox\hubspot\criteria\ResourceCriteriaInterface;
use flipbox\hubspot\fields\Resources;
use flipbox\ember\helpers\ObjectHelper;
use yii\base\InvalidConfigException;

/**
 * @author Flipbox Factory <[email protected]>
 * @since 1.0.0
 */
trait ElementCriteriaTrait
{
    /**
     * @param array $criteria
     * @return ResourceCriteriaInterface
     */
    public abstract function getCriteria(array $criteria = []): ResourceCriteriaInterface;

    /**
     * @param Resources $field
     * @param null $criteria
     * @return ResourceCriteriaInterface
     */
    protected function resolveCriteria(Resources $field, $criteria = null): ResourceCriteriaInterface
    {
        if ($criteria instanceof ResourceCriteriaInterface) {
            return $criteria;
        }

        if ($criteria === null) {
            return $field->createResourceCriteria();
        }

        if (!is_array($criteria)) {
            $criteria = ['class' => $criteria];
        }

        try {
            $criteria = ObjectHelper::create($criteria, ResourceCriteriaInterface::class);
        } catch (InvalidConfigException $e) {
            $criteria = $this->getCriteria($criteria);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        /** @var ResourceCriteriaInterface $criteria */

        return $criteria;
    }
}


1			<?php
2
3			/**
4			* @copyright Copyright (c) Flipbox Digital Limited
5			* @license https://flipboxfactory.com/software/hubspot/license
6			* @link https://www.flipboxfactory.com/software/hubspot/
7			*/
8
9			namespace flipbox\hubspot\services\resources\traits;
10
11			use flipbox\hubspot\criteria\ResourceCriteriaInterface;
12			use flipbox\hubspot\fields\Resources;
13			use flipbox\ember\helpers\ObjectHelper;
14			use yii\base\InvalidConfigException;
15
16			/**
17			* @author Flipbox Factory <[email protected]>
18			* @since 1.0.0
19			*/
20			trait ElementCriteriaTrait
21			{
22			/**
23			* @param array $criteria
24			* @return ResourceCriteriaInterface
25			*/
26			public abstract function getCriteria(array $criteria = []): ResourceCriteriaInterface;
27
28			/**
29			* @param Resources $field
30			* @param null $criteria
31			* @return ResourceCriteriaInterface
32			*/
33			protected function resolveCriteria(Resources $field, $criteria = null): ResourceCriteriaInterface
34			{
35			if ($criteria instanceof ResourceCriteriaInterface) {
36			return $criteria;
37			}
38
39			if ($criteria === null) {
40			return $field->createResourceCriteria();
41			}
42
43			if (!is_array($criteria)) {
44			$criteria = ['class' => $criteria];
45			}
46
47			try {
48			$criteria = ObjectHelper::create($criteria, ResourceCriteriaInterface::class);
49			} catch (InvalidConfigException $e) {
50			$criteria = $this->getCriteria($criteria);
			0 ignored issues – show Documentation introduced 2018-06-26 20:03 UTC by Report Bug Copy Issue Report `$criteria` is of type `object<yii\base\BaseObject>`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
51			}
52
53			/** @var ResourceCriteriaInterface $criteria */
54
55			return $criteria;
56			}
57			}
58

flipboxfactory / craft-hubspot

Push — develop ( f37ae4...1d947e )

ElementCriteriaTrait::resolveCriteria() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like