flipbox\hubspot\services\resources\traits\UpsertByElementTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
	upsertPipelineByCriteria()	0	1	?
	transformElementId()	0	1	?
	resolveCriteria()	0	1	?
A	upsertByElement()	0	11	1
A	upsertPipelineByElement()	0	27	4

<?php

/**
 * @copyright  Copyright (c) Flipbox Digital Limited
 * @license    https://flipboxfactory.com/software/hubspot/license
 * @link       https://www.flipboxfactory.com/software/hubspot/
 */

namespace flipbox\hubspot\services\resources\traits;

use craft\base\Element;
use craft\base\ElementInterface;
use flipbox\hubspot\criteria\ResourceCriteriaInterface;
use flipbox\hubspot\fields\Resources;
use flipbox\hubspot\helpers\TransformerHelper;
use League\Pipeline\PipelineBuilderInterface;

/**
 * @author Flipbox Factory <hello@flipboxfactory.com>
 * @since 1.0.0
 */
trait UpsertByElementTrait
{
    /**
     * @param ResourceCriteriaInterface $criteria
     * @return PipelineBuilderInterface
     */
    public abstract function upsertPipelineByCriteria(ResourceCriteriaInterface $criteria): PipelineBuilderInterface;

    /**
     * @param ElementInterface $element
     * @param Resources $field
     * @return string|null
     */
    protected abstract function transformElementId(ElementInterface $element, Resources $field);

    /**
     * @param Resources $field
     * @param null $criteria
     * @return ResourceCriteriaInterface
     */
    protected abstract function resolveCriteria(Resources $field, $criteria = null): ResourceCriteriaInterface;

    /**
     * @inheritdoc
     * @return PipelineBuilderInterface
     */
    public function upsertByElement(
        ElementInterface $element,
        Resources $field,
        $criteria = null
    ): PipelineBuilderInterface {
        return $this->upsertPipelineByElement(
            $element,
            $field,
            $criteria
        )($element);
    }

    /**
     * @inheritdoc
     * @return PipelineBuilderInterface
     */
    public function upsertPipelineByElement(
        ElementInterface $element,
        Resources $field,
        $criteria = null
    ): PipelineBuilderInterface {
        /** @var Element $element */
        $criteria = $this->resolveCriteria($field, $criteria);

        if (empty($criteria->getId()) || $criteria->getId() === $field::DEFAULT_HUBSPOT_ID) {
            $criteria->id = $this->transformElementId($element, $field);

Accessing id on the interface flipbox\hubspot\criteria\ResourceCriteriaInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        }

        if (empty($criteria->getPayload())) {
            $criteria->payload = $this->transformElementPayload($element, $field);

Accessing payload on the interface flipbox\hubspot\criteria\ResourceCriteriaInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

It seems like transformElementPayload() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        TransformerHelper::populateTransformerCollection(
            $criteria->getTransformer(),
            [
                'resource' => [get_class($element)]
            ]
        );

        return $this->upsertPipelineByCriteria(
            $criteria
        );
    }
}