flipbox\ember\services\traits\objects\AccessorByString

Complexity

Total Complexity

7

Size/Duplication

Total Lines	72
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
	stringProperty()	0	1	?
A	findByString()	0	6	1
A	getByString()	0	8	2
A	notFoundByStringException()	0	9	1

<?php

/**
 * @copyright  Copyright (c) Flipbox Digital Limited
 * @license    https://github.com/flipboxfactory/craft-ember/blob/master/LICENSE
 * @link       https://github.com/flipboxfactory/craft-ember
 */

namespace flipbox\ember\services\traits\objects;

use flipbox\ember\exceptions\ObjectNotFoundException;
use yii\base\BaseObject;

/**
 * Similar to the inherited Accessor, you can also specific a unique string (typically a handle) to
 * retrieve an object.
 *
 * @author Flipbox Factory <hello@flipboxfactory.com>
 * @since 1.0.0
 */
trait AccessorByString
{
    use Accessor {
        find as parentFind;
    }

    /**
     * @return string
     */
    abstract protected static function stringProperty(): string;

    /*******************************************
     * OVERRIDE
     *******************************************/

    /**
     * @param $identifier
     * @param string|null $toScenario
     * @return BaseObject|null
     */
    public function find($identifier, string $toScenario = null)
    {
        if (!is_numeric($identifier) && is_string($identifier)) {
            return $this->findByString($identifier, $toScenario);

The call to AccessorByString::findByString() has too many arguments starting with $toScenario.

        }

        return $this->parentFind($identifier, $toScenario);

It seems like parentFind() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /*******************************************
     * FIND STRING
     *******************************************/

    /**
     * @param string $string
     * @return BaseObject|null
     */
    public function findByString(string $string)
    {
        return $this->findByCondition(
            [self::stringProperty() => $string]
        );
    }

    /**
     * @param string $string
     * @throws ObjectNotFoundException
     * @return BaseObject|null
     */
    public function getByString(string $string)
    {
        if (null === ($record = $this->findByString($string))) {
            $this->notFoundByStringException($string);
        }

        return $record;
    }

    /**
     * @param string|null $string
     * @throws ObjectNotFoundException
     */
    protected function notFoundByStringException(string $string = null)
    {
        throw new ObjectNotFoundException(
            sprintf(
                'Object does not exist with the string "%s".',
                (string)$string
            )
        );
    }
}