ActiveDataProvider::prepareTotalCount() - Code Metrics - Inspection of "updating docs" - flipboxfactory/craft-ember - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 256ea8...9ceff5 )

by Nate

created 2018-05-08 18:06 UTC

ActiveDataProvider::prepareTotalCount() A

↳ Parent: ActiveDataProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	5
c	1
b	0
f	0
ccs	0
cts	5
cp	0
rs	9.4285
cc	1
eloc	3
nc	1
nop	0
crap	2

<?php

/**
 * @copyright  Copyright (c) Flipbox Digital Limited
 * @license    https://github.com/flipboxfactory/craft-ember/blob/master/LICENSE
 * @link       https://github.com/flipboxfactory/craft-ember
 */

namespace flipbox\ember\data;

use yii\base\InvalidConfigException;
use yii\db\Query;
use yii\db\QueryInterface;

/**
 * @author Flipbox Factory <[email protected]>
 * @since 1.0.2
 *
 * Ref: https://github.com/craftcms/cms/issues/2857
 */
class ActiveDataProvider extends \yii\data\ActiveDataProvider
{
    /**
     * {@inheritdoc}
     */
    protected function prepareModels()
    {
        $query = $this->getQueryClone();
        if (($pagination = $this->getPagination()) !== false) {
            $pagination->totalCount = $this->getTotalCount();
            if ($pagination->totalCount === 0) {
                return [];
            }
            $query->limit($pagination->getLimit())->offset($pagination->getOffset());
        }
        if (($sort = $this->getSort()) !== false) {
            $query->addOrderBy($sort->getOrders());
        }

        return $query->all($this->db);
    }

    /**
     * {@inheritdoc}
     */
    protected function prepareTotalCount()
    {
        $query = $this->getQueryClone();
        return (int)$query->limit(-1)->offset(-1)->orderBy([])->count('*', $this->db);
    }

    /**
     * @return QueryInterface
     * @throws InvalidConfigException
     */
    private function getQueryClone(): QueryInterface
    {
        if (!$this->query instanceof QueryInterface) {
            throw new InvalidConfigException('The "query" property must be an instance of a class that implements the QueryInterface e.g. yii\db\Query or its subclasses.');
        }

        $query = clone $this->query;

        if ($this->query instanceof Query) {
            /** @var Query $query */
            foreach($this->query->getBehaviors() as $name => $behavior) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                $query->attachBehavior($name, clone $behavior);
            }
        }

        return $query;
    }
}


1			<?php
2
3			/**
4			* @copyright Copyright (c) Flipbox Digital Limited
5			* @license https://github.com/flipboxfactory/craft-ember/blob/master/LICENSE
6			* @link https://github.com/flipboxfactory/craft-ember
7			*/
8
9			namespace flipbox\ember\data;
10
11			use yii\base\InvalidConfigException;
12			use yii\db\Query;
13			use yii\db\QueryInterface;
14
15			/**
16			* @author Flipbox Factory <[email protected]>
17			* @since 1.0.2
18			*
19			* Ref: https://github.com/craftcms/cms/issues/2857
20			*/
21			class ActiveDataProvider extends \yii\data\ActiveDataProvider
22			{
23			/**
24			* {@inheritdoc}
25			*/
26			protected function prepareModels()
27			{
28			$query = $this->getQueryClone();
29			if (($pagination = $this->getPagination()) !== false) {
30			$pagination->totalCount = $this->getTotalCount();
31			if ($pagination->totalCount === 0) {
32			return [];
33			}
34			$query->limit($pagination->getLimit())->offset($pagination->getOffset());
35			}
36			if (($sort = $this->getSort()) !== false) {
37			$query->addOrderBy($sort->getOrders());
38			}
39
40			return $query->all($this->db);
41			}
42
43			/**
44			* {@inheritdoc}
45			*/
46			protected function prepareTotalCount()
47			{
48			$query = $this->getQueryClone();
49			return (int)$query->limit(-1)->offset(-1)->orderBy([])->count('*', $this->db);
50			}
51
52			/**
53			* @return QueryInterface
54			* @throws InvalidConfigException
55			*/
56			private function getQueryClone(): QueryInterface
57			{
58			if (!$this->query instanceof QueryInterface) {
59			throw new InvalidConfigException('The "query" property must be an instance of a class that implements the QueryInterface e.g. yii\db\Query or its subclasses.');
60			}
61
62			$query = clone $this->query;
63
64			if ($this->query instanceof Query) {
65			/** @var Query $query */
66			foreach($this->query->getBehaviors() as $name => $behavior) {
			1 ignored issue – show Bug introduced 2018-05-08 18:10 UTC by Report Bug Copy Issue Report The expression `$this->query->getBehaviors()` of type `array<integer,object<yii\base\Behavior>>\|null` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
67			$query->attachBehavior($name, clone $behavior);
68			}
69			}
70
71			return $query;
72			}
73			}
74

flipboxfactory / craft-ember

Push — develop ( 256ea8...9ceff5 )

ActiveDataProvider::prepareTotalCount() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like