UserList::resolveElement() - Code Metrics - Inspection of "simplify / docs" - flipboxfactory/craft-element-lists - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( a740b5...5bfad1 )

by Nate

created 2019-06-14 20:53 UTC

UserList::resolveElement() A

↳ Parent: UserList

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	0
cts	10
cp	0
rs	9.8666
c	0
b	0
f	0
cc	3
nc	3
nop	1
crap	12

<?php

/**
 * @copyright  Copyright (c) Flipbox Digital Limited
 * @license    https://github.com/flipboxfactory/craft-element-lists/LICENSE
 * @link       https://github.com/flipboxfactory/craft-element-lists/
 */

namespace flipbox\craft\element\lists\fields;

use craft\elements\User;
use craft\fields\Users;
use flipbox\craft\element\lists\ElementList;

/**
 * @author Flipbox Factory <[email protected]>
 * @since 1.0.0
 */
class UserList extends Users implements SortableInterface, RelationalInterface
{
    use ElementListTrait;

    /**
     * @inheritdoc
     */
    public static function displayName(): string
    {
        return ElementList::t('User List');
    }

    /**
     * @inheritdoc
     */
    public function settingsAttributes(): array
    {
        return array_merge(
            parent::settingsAttributes(),
            [
                'sortable'
            ]
        );
    }

    /**
     * inheritDoc
     * @return User|null
     */
    public function resolveElement($element)
    {
        if (is_numeric($element)) {
            return \Craft::$app->getUsers()->getUserById($element);
        }

        if (is_string($element)) {
            return \Craft::$app->getUsers()->getUserByUsernameOrEmail($element);
        }

        return User::findOne($element);

    }
}


1			<?php
2
3			/**
4			* @copyright Copyright (c) Flipbox Digital Limited
5			* @license https://github.com/flipboxfactory/craft-element-lists/LICENSE
6			* @link https://github.com/flipboxfactory/craft-element-lists/
7			*/
8
9			namespace flipbox\craft\element\lists\fields;
10
11			use craft\elements\User;
12			use craft\fields\Users;
13			use flipbox\craft\element\lists\ElementList;
14
15			/**
16			* @author Flipbox Factory <[email protected]>
17			* @since 1.0.0
18			*/
19			class UserList extends Users implements SortableInterface, RelationalInterface
20			{
21			use ElementListTrait;
22
23			/**
24			* @inheritdoc
25			*/
26			public static function displayName(): string
27			{
28			return ElementList::t('User List');
29			}
30
31			/**
32			* @inheritdoc
33			*/
34			public function settingsAttributes(): array
35			{
36			return array_merge(
37			parent::settingsAttributes(),
38			[
39			'sortable'
40			]
41			);
42			}
43
44			/**
45			* inheritDoc
46			* @return User\|null
47			*/
48			public function resolveElement($element)
49			{
50			if (is_numeric($element)) {
51			return \Craft::$app->getUsers()->getUserById($element);
52			}
53
54			if (is_string($element)) {
55			return \Craft::$app->getUsers()->getUserByUsernameOrEmail($element);
56			}
57
58			return User::findOne($element);
			0 ignored issues – show Bug Compatibility introduced 2019-06-14 05:39 UTC by Report Bug Copy Issue Report The expression `\craft\elements\User::findOne($element);` of type `craft\base\Element\|null\|craft\base\Element[]` adds the type `craft\base\Element[]` to the return on line 58 which is incompatible with the return type declared by the interface `flipbox\craft\element\li...terface::resolveElement` of type `craft\base\ElementInterface\|null`. Loading history...
59			}
60			}
61

flipboxfactory / craft-element-lists

Push — develop ( a740b5...5bfad1 )

UserList::resolveElement() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like