Associate::run() - Code Metrics - flipboxfactory/craft-element-lists - Measure and Improve Code Quality continuously with Scrutinizer

Associate::run() B
last analyzed 2019-11-05 18:38 UTC

↳ Parent: Associate

Complexity

Conditions	7
Paths	8

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes

Metric	Value
dl	0
loc	41
ccs	0
cts	31
cp	0
rs	8.3306
c	0
b	0
f	0
cc	7
nc	8
nop	5
crap	56

<?php

/**
 * @copyright  Copyright (c) Flipbox Digital Limited
 * @license    https://github.com/flipboxfactory/craft-element-lists/LICENSE
 * @link       https://github.com/flipboxfactory/craft-element-lists/
 */

namespace flipbox\craft\element\lists\actions\source;

use Craft;
use craft\base\Field;
use flipbox\craft\ember\actions\ManageTrait;
use flipbox\craft\ember\helpers\SiteHelper;
use flipbox\craft\element\lists\actions\ResolverTrait;
use flipbox\craft\element\lists\records\Association;
use yii\base\Action;

/**
 * @author Flipbox Factory <[email protected]>
 * @since 2.0.0
 */
class Associate extends Action
{
    use ManageTrait,
        ResolverTrait;

    /**
     * @param string $field
     * @param string $source
     * @param string $target
     * @param int|null $siteId
     * @param int|null $sortOrder
     * @return mixed
     * @throws \yii\web\HttpException
     */
    public function run(
        string $field,
        string $source,
        string $target,
        int $siteId = null,
        int $sortOrder = null
    ) {

        // Resolve
        $field = $this->resolveField($field);
        $source = $this->resolveElement($source);
        $target = $this->resolveElement($target);

        /** @var Field $field */

        $siteId = $this->resolveSiteId($siteId ?: $source->siteId);

        $query = Association::find()
            ->fieldId($field->id)
            ->sourceId($source->getId() ?: false)
            ->targetId($target->getId() ?: false);

        if ($siteId) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $query->siteId($siteId);
        }

        if (!$record = $query->one()) {
            $record = new Association([
                'fieldId' => $field->id,
                'sourceId' => $source->getId(),
                'targetId' => $target->getId(),
                'siteId' => $siteId
            ]);
        }

        if ($sortOrder) {
            $record->sortOrder = $sortOrder;
        }

        return $this->runInternal($record);
    }

    /**
     * @inheritdoc
     * @param Association $record
     * @throws \Exception
     */
    protected function performAction(Association $record): bool
    {
        return $record->save();
    }
}


1			<?php
2
3			/**
4			* @copyright Copyright (c) Flipbox Digital Limited
5			* @license https://github.com/flipboxfactory/craft-element-lists/LICENSE
6			* @link https://github.com/flipboxfactory/craft-element-lists/
7			*/
8
9			namespace flipbox\craft\element\lists\actions\source;
10
11			use Craft;
12			use craft\base\Field;
13			use flipbox\craft\ember\actions\ManageTrait;
14			use flipbox\craft\ember\helpers\SiteHelper;
15			use flipbox\craft\element\lists\actions\ResolverTrait;
16			use flipbox\craft\element\lists\records\Association;
17			use yii\base\Action;
18
19			/**
20			* @author Flipbox Factory <[email protected]>
21			* @since 2.0.0
22			*/
23			class Associate extends Action
24			{
25			use ManageTrait,
26			ResolverTrait;
27
28			/**
29			* @param string $field
30			* @param string $source
31			* @param string $target
32			* @param int\|null $siteId
33			* @param int\|null $sortOrder
34			* @return mixed
35			* @throws \yii\web\HttpException
36			*/
37			public function run(
38			string $field,
39			string $source,
40			string $target,
41			int $siteId = null,
42			int $sortOrder = null
43			) {
44
45			// Resolve
46			$field = $this->resolveField($field);
47			$source = $this->resolveElement($source);
48			$target = $this->resolveElement($target);
49
50			/** @var Field $field */
51
52			$siteId = $this->resolveSiteId($siteId ?: $source->siteId);
53
54			$query = Association::find()
55			->fieldId($field->id)
56			->sourceId($source->getId() ?: false)
57			->targetId($target->getId() ?: false);
58
59			if ($siteId) {
			0 ignored issues – show Bug Best Practice introduced 2019-10-09 22:36 UTC by Report Bug Copy Issue Report The expression `$siteId` of type `null\|integer` is loosely compared to `true`; this is ambiguous if the integer can be zero. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
60			$query->siteId($siteId);
61			}
62
63			if (!$record = $query->one()) {
64			$record = new Association([
65			'fieldId' => $field->id,
66			'sourceId' => $source->getId(),
67			'targetId' => $target->getId(),
68			'siteId' => $siteId
69			]);
70			}
71
72			if ($sortOrder) {
73			$record->sortOrder = $sortOrder;
74			}
75
76			return $this->runInternal($record);
77			}
78
79			/**
80			* @inheritdoc
81			* @param Association $record
82			* @throws \Exception
83			*/
84			protected function performAction(Association $record): bool
85			{
86			return $record->save();
87			}
88			}
89

flipboxfactory / craft-element-lists

Associate::run() B last analyzed 2019-11-05 18:38 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Associate::run() B
last analyzed 2019-11-05 18:38 UTC