Associations::associations() - Code Metrics - Inspection of "updates to dep namespaces" - flipboxfactory/craft-domains - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 54eba4...9cf550 )

by Nate

created 2018-03-15 20:17 UTC

Associations::associations() A

↳ Parent: Associations

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	0
cts	9
cp	0
rs	9.6666
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	3
crap	2

<?php

/**
 * @copyright  Copyright (c) Flipbox Digital Limited
 * @license    https://flipboxfactory.com/software/domains/license
 * @link       https://www.flipboxfactory.com/software/domains/
 */

namespace flipbox\domains\services;

use flipbox\craft\sortable\associations\db\SortableAssociationQueryInterface;
use flipbox\craft\sortable\associations\records\SortableAssociationInterface;
use flipbox\craft\sortable\associations\services\SortableAssociations;
use flipbox\domains\db\DomainsQuery;
use flipbox\domains\records\Domain;
use yii\db\ActiveQuery;

/**
 * @author Flipbox Factory <[email protected]>
 * @since 1.0.0
 */
class Associations extends SortableAssociations
{
    /**
     * @inheritdoc
     */
    const TABLE_ALIAS = Domain::TABLE_ALIAS;

    /**
     * @inheritdoc
     */
    const SOURCE_ATTRIBUTE = Domain::SOURCE_ATTRIBUTE;

    /**
     * @inheritdoc
     */
    const TARGET_ATTRIBUTE = Domain::TARGET_ATTRIBUTE;

    /**
     * @inheritdoc
     * @return DomainsQuery
     */
    public function getQuery($config = []): SortableAssociationQueryInterface
    {
        return new DomainsQuery(Domain::class, $config);
    }

    /**
     * @param SortableAssociationInterface|Domain $record
     * @return SortableAssociationQueryInterface|DomainsQuery
     */
    protected function associationQuery(
        SortableAssociationInterface $record
    ): SortableAssociationQueryInterface {
        return $this->query(
            $record->{static::SOURCE_ATTRIBUTE},
            $record->fieldId,
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $record->siteId
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        );
    }

    /**
     * @param SortableAssociationQueryInterface|DomainsQuery $query
     * @return array
     */
    protected function existingAssociations(
        SortableAssociationQueryInterface $query
    ): array {
        $source = $this->resolveStringAttribute($query, static::SOURCE_ATTRIBUTE);
        $field = $this->resolveStringAttribute($query, 'fieldId');
        $site = $this->resolveStringAttribute($query, 'siteId');

        if ($source === null || $field === null || $site === null) {
            return [];
        }

        return $this->associations($source, $field, $site);
    }

    /**
     * @param $source
     * @param int $fieldId
     * @param int $siteId
     * @return SortableAssociationQueryInterface|ActiveQuery
     */
    private function query(
        $source,
        int $fieldId,
        int $siteId
    ): SortableAssociationQueryInterface {
        return $this->getQuery()
            ->where([
                static::SOURCE_ATTRIBUTE => $source,
                'fieldId' => $fieldId,
                'siteId' => $siteId
            ])
            ->orderBy(['sortOrder' => SORT_ASC]);
    }

    /**
     * @param $source
     * @param int $fieldId
     * @param int $siteId
     * @return array
     */
    private function associations(
        $source,
        int $fieldId,
        int $siteId
    ): array {
        return $this->query($source, $fieldId, $siteId)
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->indexBy(static::TARGET_ATTRIBUTE)
            ->all();
    }
}


1			<?php
2
3			/**
4			* @copyright Copyright (c) Flipbox Digital Limited
5			* @license https://flipboxfactory.com/software/domains/license
6			* @link https://www.flipboxfactory.com/software/domains/
7			*/
8
9			namespace flipbox\domains\services;
10
11			use flipbox\craft\sortable\associations\db\SortableAssociationQueryInterface;
12			use flipbox\craft\sortable\associations\records\SortableAssociationInterface;
13			use flipbox\craft\sortable\associations\services\SortableAssociations;
14			use flipbox\domains\db\DomainsQuery;
15			use flipbox\domains\records\Domain;
16			use yii\db\ActiveQuery;
17
18			/**
19			* @author Flipbox Factory <[email protected]>
20			* @since 1.0.0
21			*/
22			class Associations extends SortableAssociations
23			{
24			/**
25			* @inheritdoc
26			*/
27			const TABLE_ALIAS = Domain::TABLE_ALIAS;
28
29			/**
30			* @inheritdoc
31			*/
32			const SOURCE_ATTRIBUTE = Domain::SOURCE_ATTRIBUTE;
33
34			/**
35			* @inheritdoc
36			*/
37			const TARGET_ATTRIBUTE = Domain::TARGET_ATTRIBUTE;
38
39			/**
40			* @inheritdoc
41			* @return DomainsQuery
42			*/
43			public function getQuery($config = []): SortableAssociationQueryInterface
44			{
45			return new DomainsQuery(Domain::class, $config);
46			}
47
48			/**
49			* @param SortableAssociationInterface\|Domain $record
50			* @return SortableAssociationQueryInterface\|DomainsQuery
51			*/
52			protected function associationQuery(
53			SortableAssociationInterface $record
54			): SortableAssociationQueryInterface {
55			return $this->query(
56			$record->{static::SOURCE_ATTRIBUTE},
57			$record->fieldId,
			1 ignored issue – show Bug introduced 2018-03-15 20:27 UTC by Report Bug Copy Issue Report Accessing `fieldId` on the interface `flipbox\craft\sortable\a...bleAssociationInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
58			$record->siteId
			1 ignored issue – show Bug introduced 2018-03-15 20:27 UTC by Report Bug Copy Issue Report Accessing `siteId` on the interface `flipbox\craft\sortable\a...bleAssociationInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
59			);
60			}
61
62			/**
63			* @param SortableAssociationQueryInterface\|DomainsQuery $query
64			* @return array
65			*/
66			protected function existingAssociations(
67			SortableAssociationQueryInterface $query
68			): array {
69			$source = $this->resolveStringAttribute($query, static::SOURCE_ATTRIBUTE);
70			$field = $this->resolveStringAttribute($query, 'fieldId');
71			$site = $this->resolveStringAttribute($query, 'siteId');
72
73			if ($source === null \|\| $field === null \|\| $site === null) {
74			return [];
75			}
76
77			return $this->associations($source, $field, $site);
78			}
79
80			/**
81			* @param $source
82			* @param int $fieldId
83			* @param int $siteId
84			* @return SortableAssociationQueryInterface\|ActiveQuery
85			*/
86			private function query(
87			$source,
88			int $fieldId,
89			int $siteId
90			): SortableAssociationQueryInterface {
91			return $this->getQuery()
92			->where([
93			static::SOURCE_ATTRIBUTE => $source,
94			'fieldId' => $fieldId,
95			'siteId' => $siteId
96			])
97			->orderBy(['sortOrder' => SORT_ASC]);
98			}
99
100			/**
101			* @param $source
102			* @param int $fieldId
103			* @param int $siteId
104			* @return array
105			*/
106			private function associations(
107			$source,
108			int $fieldId,
109			int $siteId
110			): array {
111			return $this->query($source, $fieldId, $siteId)
			1 ignored issue – show Bug introduced 2018-03-15 20:27 UTC by Report Bug Copy Issue Report The method `indexBy` does only exist in `yii\db\ActiveQuery`, but not in `flipbox\craft\sortable\a...sociationQueryInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
112			->indexBy(static::TARGET_ATTRIBUTE)
113			->all();
114			}
115			}
116

flipboxfactory / craft-domains

Push — develop ( 54eba4...9cf550 )

Associations::associations() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like