ArrayTransform::setIncludes() - Code Metrics - Inspection of "formatting" - flipbox/transform - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b5fb47...8bb9d4 )

by Nate

created 2017-06-05 19:03 UTC

ArrayTransform::setIncludes() B

↳ Parent: ArrayTransform

Complexity

Conditions	7
Paths	12

Size

Total Lines	59
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes

Metric	Value
dl	0
loc	59
ccs	0
cts	34
cp	0
rs	7.5346
c	0
b	0
f	0
cc	7
eloc	25
nc	12
nop	1
crap	56

How to fix Long Method

<?php

/**
 * @author    Flipbox Factory
 * @copyright Copyright (c) 2017, Flipbox Digital
 * @link      https://github.com/flipbox/transform/releases/latest
 * @license   https://github.com/flipbox/transform/blob/master/LICENSE
 */

namespace Flipbox\Transform\Transform;

use Flipbox\Transform\ParamBag;

/**
 * @author Flipbox Factory <[email protected]>
 * @since 1.0.0
 */
class ArrayTransform extends AbstractTransform
{
    /**
     * Scope identifiers that resources can optionally include.
     *
     * @var array
     */
    protected $includes = [];

    /**
     * Scope identifiers that resources must exclude.
     *
     * @var array
     */
    protected $excludes = [];

    /**
     * Scope identifiers that resources must return.
     *
     * @var array
     */
    protected $fields = [];

    /**
     * Auto-include Parents
     *
     * Look at the requested includes and automatically include the parents if they
     * are not explicitly requested. E.g: [foo, bar.baz] becomes [foo, bar, bar.baz]
     *
     * @internal
     *
     * @return void
     */
    protected function autoIncludeParents()
    {
        $parsed = [];

        foreach ($this->includes as $include) {
            $nested = explode('.', $include);

            $part = array_shift($nested);
            $parsed[] = $part;

            while (count($nested) > 0) {
                $part .= '.' . array_shift($nested);
                $parsed[] = $part;
            }
        }

        $this->includes = array_values(array_unique($parsed));
    }

    /*******************************************
     * INCLUDES
     *******************************************/

    /**
     * Get Requested Includes.
     *
     * @return array
     */
    public function getIncludes(): array
    {
        return $this->includes;
    }

    /**
     * Parse Include String.
     *
     * @param array|string $includes Array or csv string of resources to include
     *
     * @return $this
     */
    public function setIncludes($includes)
    {
        // Wipe these before we go again
        $this->includes = $this->params = [];

        if (is_string($includes)) {
            $includes = explode(',', $includes);
        }

        if (!is_array($includes)) {
            throw new \InvalidArgumentException(
                'The parseIncludes() method expects a string or an array. ' . gettype($includes) . ' given'
            );
        }

        foreach ($includes as $include) {
            list($includeName, $allModifiersStr) = array_pad(explode(':', $include, 2), 2, null);

            // Trim it down to a cool level of recursion
            $includeName = $this->trimToAcceptableRecursionLevel($includeName);

            if (in_array($includeName, $this->includes)) {
                continue;
            }
            $this->includes[] = $includeName;

            // No Params? Bored
            if ($allModifiersStr === null) {
                continue;
            }

            // Matches multiple instances of 'something(foo|bar|baz)' in the string
            // I guess it ignores : so you could use anything, but probably don't do that
            preg_match_all('/([\w]+)(\(([^\)]+)\))?/', $allModifiersStr, $allModifiersArr);

            // [0] is full matched strings...
            $modifierCount = count($allModifiersArr[0]);

            $modifierArr = [];

            for ($modifierIt = 0; $modifierIt < $modifierCount; $modifierIt++) {
                // [1] is the modifier
                $modifierName = $allModifiersArr[1][$modifierIt];

                // and [3] is delimited params
                $modifierParamStr = $allModifiersArr[3][$modifierIt];

                // Make modifier array key with an array of params as the value
                $modifierArr[$modifierName] = explode($this->paramDelimiter, $modifierParamStr);
            }

            $this->params[$includeName] = $modifierArr;
        }

        // This should be optional and public someday, but without it includes would never show up
        $this->autoIncludeParents();

        return $this;
    }

    /*******************************************
     * EXCLUDES
     *******************************************/

    /**
     * Get Requested Excludes.
     *
     * @return array
     */
    public function getExcludes(): array
    {
        return $this->excludes;
    }

    /**
     * Parse Exclude String.
     *
     * @param array|string $excludes Array or csv string of resources to exclude
     *
     * @return $this
     */
    public function setExcludes($excludes)
    {
        $this->excludes = [];

        if (is_string($excludes)) {
            $excludes = explode(',', $excludes);
        }

        if (!is_array($excludes)) {
            throw new \InvalidArgumentException(
                'The parseExcludes() method expects a string or an array. ' . gettype($excludes) . ' given'
            );
        }

        foreach ($excludes as $excludeName) {
            $excludeName = $this->trimToAcceptableRecursionLevel($excludeName);

            if (in_array($excludeName, $this->excludes)) {
                continue;
            }

            $this->excludes[] = $excludeName;
        }

        return $this;
    }

    /*******************************************
     * FIELDS
     *******************************************/

    /**
     * Parse field parameter.
     *
     * @param array $fields Array of fields to include. It must be an array
     *                         whose keys are resource types and values a string
     *                         of the fields to return, separated by a comma
     *
     * @return $this
     */
    public function setFields(array $fields)
    {
        $this->fields = [];

        foreach ($fields as $type => $field) {
            //Remove empty and repeated fields
            $this->fields[$type] = array_unique(array_filter(explode(',', $field)));
        }

        return $this;
    }

    /**
     * Get requested fields.
     *
     * @return array
     */
    public function getFields(): array
    {
        return $this->fields;
    }

    /**
     * Get field params for the specified type.
     *
     * @param string $type
     *
     * @return ParamBag|null
     */
    public function getField($type)
    {
        return !isset($this->fields[$type]) ?
            null :
            new ParamBag($this->fields[$type]);
    }
}


1			<?php
2
3			/**
4			* @author Flipbox Factory
5			* @copyright Copyright (c) 2017, Flipbox Digital
6			* @link https://github.com/flipbox/transform/releases/latest
7			* @license https://github.com/flipbox/transform/blob/master/LICENSE
8			*/
9
10			namespace Flipbox\Transform\Transform;
11
12			use Flipbox\Transform\ParamBag;
13
14			/**
15			* @author Flipbox Factory <[email protected]>
16			* @since 1.0.0
17			*/
18			class ArrayTransform extends AbstractTransform
19			{
20			/**
21			* Scope identifiers that resources can optionally include.
22			*
23			* @var array
24			*/
25			protected $includes = [];
26
27			/**
28			* Scope identifiers that resources must exclude.
29			*
30			* @var array
31			*/
32			protected $excludes = [];
33
34			/**
35			* Scope identifiers that resources must return.
36			*
37			* @var array
38			*/
39			protected $fields = [];
40
41			/**
42			* Auto-include Parents
43			*
44			* Look at the requested includes and automatically include the parents if they
45			* are not explicitly requested. E.g: [foo, bar.baz] becomes [foo, bar, bar.baz]
46			*
47			* @internal
48			*
49			* @return void
50			*/
51			protected function autoIncludeParents()
52			{
53			$parsed = [];
54
55			foreach ($this->includes as $include) {
56			$nested = explode('.', $include);
57
58			$part = array_shift($nested);
59			$parsed[] = $part;
60
61			while (count($nested) > 0) {
62			$part .= '.' . array_shift($nested);
63			$parsed[] = $part;
64			}
65			}
66
67			$this->includes = array_values(array_unique($parsed));
68			}
69
70			/*******************************************
71			* INCLUDES
72			*******************************************/
73
74			/**
75			* Get Requested Includes.
76			*
77			* @return array
78			*/
79			public function getIncludes(): array
80			{
81			return $this->includes;
82			}
83
84			/**
85			* Parse Include String.
86			*
87			* @param array\|string $includes Array or csv string of resources to include
88			*
89			* @return $this
90			*/
91			public function setIncludes($includes)
92			{
93			// Wipe these before we go again
94			$this->includes = $this->params = [];
95
96			if (is_string($includes)) {
97			$includes = explode(',', $includes);
98			}
99
100			if (!is_array($includes)) {
101			throw new \InvalidArgumentException(
102			'The parseIncludes() method expects a string or an array. ' . gettype($includes) . ' given'
103			);
104			}
105
106			foreach ($includes as $include) {
107			list($includeName, $allModifiersStr) = array_pad(explode(':', $include, 2), 2, null);
108
109			// Trim it down to a cool level of recursion
110			$includeName = $this->trimToAcceptableRecursionLevel($includeName);
111
112			if (in_array($includeName, $this->includes)) {
113			continue;
114			}
115			$this->includes[] = $includeName;
116
117			// No Params? Bored
118			if ($allModifiersStr === null) {
119			continue;
120			}
121
122			// Matches multiple instances of 'something(foo\|bar\|baz)' in the string
123			// I guess it ignores : so you could use anything, but probably don't do that
124			preg_match_all('/([\w]+)(\(([^\)]+)\))?/', $allModifiersStr, $allModifiersArr);
125
126			// [0] is full matched strings...
127			$modifierCount = count($allModifiersArr[0]);
128
129			$modifierArr = [];
130
131			for ($modifierIt = 0; $modifierIt < $modifierCount; $modifierIt++) {
132			// [1] is the modifier
133			$modifierName = $allModifiersArr[1][$modifierIt];
134
135			// and [3] is delimited params
136			$modifierParamStr = $allModifiersArr[3][$modifierIt];
137
138			// Make modifier array key with an array of params as the value
139			$modifierArr[$modifierName] = explode($this->paramDelimiter, $modifierParamStr);
140			}
141
142			$this->params[$includeName] = $modifierArr;
143			}
144
145			// This should be optional and public someday, but without it includes would never show up
146			$this->autoIncludeParents();
147
148			return $this;
149			}
150
151			/*******************************************
152			* EXCLUDES
153			*******************************************/
154
155			/**
156			* Get Requested Excludes.
157			*
158			* @return array
159			*/
160			public function getExcludes(): array
161			{
162			return $this->excludes;
163			}
164
165			/**
166			* Parse Exclude String.
167			*
168			* @param array\|string $excludes Array or csv string of resources to exclude
169			*
170			* @return $this
171			*/
172			public function setExcludes($excludes)
173			{
174			$this->excludes = [];
175
176			if (is_string($excludes)) {
177			$excludes = explode(',', $excludes);
178			}
179
180			if (!is_array($excludes)) {
181			throw new \InvalidArgumentException(
182			'The parseExcludes() method expects a string or an array. ' . gettype($excludes) . ' given'
183			);
184			}
185
186			foreach ($excludes as $excludeName) {
187			$excludeName = $this->trimToAcceptableRecursionLevel($excludeName);
188
189			if (in_array($excludeName, $this->excludes)) {
190			continue;
191			}
192
193			$this->excludes[] = $excludeName;
194			}
195
196			return $this;
197			}
198
199			/*******************************************
200			* FIELDS
201			*******************************************/
202
203			/**
204			* Parse field parameter.
205			*
206			* @param array $fields Array of fields to include. It must be an array
207			* whose keys are resource types and values a string
208			* of the fields to return, separated by a comma
209			*
210			* @return $this
211			*/
212			public function setFields(array $fields)
213			{
214			$this->fields = [];
215
216			foreach ($fields as $type => $field) {
217			//Remove empty and repeated fields
218			$this->fields[$type] = array_unique(array_filter(explode(',', $field)));
219			}
220
221			return $this;
222			}
223
224			/**
225			* Get requested fields.
226			*
227			* @return array
228			*/
229			public function getFields(): array
230			{
231			return $this->fields;
232			}
233
234			/**
235			* Get field params for the specified type.
236			*
237			* @param string $type
238			*
239			* @return ParamBag\|null
240			*/
241			public function getField($type)
242			{
243			return !isset($this->fields[$type]) ?
244			null :
245			new ParamBag($this->fields[$type]);
246			}
247			}
248

flipbox / transform

Push — master ( b5fb47...8bb9d4 )

ArrayTransform::setIncludes() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like