NestedResourceTrait::__invoke() - Code Metrics - Inspection of "initial commit" - flipbox/transform - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 57919c...74fef5 )

by Nate

created 2017-04-18 08:42 UTC

NestedResourceTrait::__invoke() A

↳ Parent: NestedResourceTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	3

<?php

/**
 * @package   Transform
 * @author    Flipbox Factory
 * @copyright Copyright (c) 2017, Flipbox Digital
 * @link      https://github.com/flipbox/transform/releases/latest
 * @license   https://github.com/flipbox/transform/blob/master/LICENSE
 */

namespace flipbox\transform\transformers;

use flipbox\transform\Scope;

/**
 * @package flipbox\transform\transformers
 * @author Flipbox Factory <[email protected]>
 * @since 1.0.0
 */
trait NestedResourceTrait
{

    /**
     * @var Scope
     */
    public $scope;

    /**
     * @return array
     */
    public function getIncludes(): array
    {
        return [];
    }

    /**
     * @inheritdoc
     */
    public function __invoke($data, Scope $scope, string $identifier = null): array
    {
        $this->scope = $scope;
        return $this->transform($identifier);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

}

1			<?php
2
3			/**
4			* @package Transform
5			* @author Flipbox Factory
6			* @copyright Copyright (c) 2017, Flipbox Digital
7			* @link https://github.com/flipbox/transform/releases/latest
8			* @license https://github.com/flipbox/transform/blob/master/LICENSE
9			*/
10
11			namespace flipbox\transform\transformers;
12
13			use flipbox\transform\Scope;
14
15			/**
16			* @package flipbox\transform\transformers
17			* @author Flipbox Factory <[email protected]>
18			* @since 1.0.0
19			*/
20			trait NestedResourceTrait
21			{
22
23			/**
24			* @var Scope
25			*/
26			public $scope;
27
28			/**
29			* @return array
30			*/
31			public function getIncludes(): array
32			{
33			return [];
34			}
35
36			/**
37			* @inheritdoc
38			*/
39			public function __invoke($data, Scope $scope, string $identifier = null): array
40			{
41			$this->scope = $scope;
42			return $this->transform($identifier);
			0 ignored issues – show Bug introduced 2017-04-18 08:45 UTC by Report Bug Copy Issue Report It seems like `transform()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
43			}
44
45			}

flipbox / transform

Push — master ( 57919c...74fef5 )

NestedResourceTrait::__invoke() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like