ObjectByIdOrString::find() - Code Metrics - Inspection of "updating doc blocks + adding merge" - flipbox/spark - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 58a092...20e86c )

by Nate

created 2017-05-16 21:24 UTC

ObjectByIdOrString::find() A

↳ Parent: ObjectByIdOrString

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	6

Duplication

Lines	14
Ratio	100 %

Importance

Changes

Metric	Value
dl	14
loc	14
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	6
nc	3
nop	2

<?php

/**
 * @copyright  Copyright (c) Flipbox Digital Limited
 * @license    https://github.com/flipbox/spark/blob/master/LICENSE
 * @link       https://github.com/flipbox/spark
 */

namespace flipbox\spark\services;

use flipbox\spark\Records\Record;
use yii\base\Object as BaseObject;

/**
 * @author Flipbox Factory <[email protected]>
 * @since 2.1.0
 */
abstract class ObjectByIdOrString extends ObjectById

{

    use traits\ObjectByString;

    /**
     * @inheritdoc
     */
    public function find($identifier, string $toScenario = null)
    {

        if ($model = parent::find($identifier, $toScenario)) {
            return $model;
        }

        if (!is_string($identifier)) {
            return null;
        }

        return $this->findByString($identifier, $toScenario);

    }

    /*******************************************
     * CACHE
     *******************************************/

    /**
     * @inheritdoc
     */
    public function findCache($identifier)
    {

        if ($model = parent::findCache($identifier)) {
            return $model;
        }

        if (!is_string($identifier)) {
            return null;
        }

        return $this->findCacheByString($identifier);

    }

    /**
     * @inheritdoc
     */
    public function addToCache(BaseObject $object)
    {

        parent::addToCache($object);

        $this->cacheByString($object);

        return $this;

    }


    /**
     * @inheritdoc
     */
    public function findCacheByRecord(Record $record)
    {

        if ($model = parent::findCacheByRecord($record)) {
            return $model;
        }

        return $this->findCacheByRecordByString($record);

    }

}

1		<?php
2
3		/**
4		* @copyright Copyright (c) Flipbox Digital Limited
5		* @license https://github.com/flipbox/spark/blob/master/LICENSE
6		* @link https://github.com/flipbox/spark
7		*/
8
9		namespace flipbox\spark\services;
10
11		use flipbox\spark\Records\Record;
12		use yii\base\Object as BaseObject;
13
14		/**
15		* @author Flipbox Factory <[email protected]>
16		* @since 2.1.0
17		*/
18	View Code Duplication	abstract class ObjectByIdOrString extends ObjectById
		1 ignored issue – show Duplication introduced 2017-05-16 21:28 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19		{
20
21		use traits\ObjectByString;
22
23		/**
24		* @inheritdoc
25		*/
26		public function find($identifier, string $toScenario = null)
27		{
28
29		if ($model = parent::find($identifier, $toScenario)) {
30		return $model;
31		}
32
33		if (!is_string($identifier)) {
34		return null;
35		}
36
37		return $this->findByString($identifier, $toScenario);
38
39		}
40
41		/*******************************************
42		* CACHE
43		*******************************************/
44
45		/**
46		* @inheritdoc
47		*/
48		public function findCache($identifier)
49		{
50
51		if ($model = parent::findCache($identifier)) {
52		return $model;
53		}
54
55		if (!is_string($identifier)) {
56		return null;
57		}
58
59		return $this->findCacheByString($identifier);
60
61		}
62
63		/**
64		* @inheritdoc
65		*/
66		public function addToCache(BaseObject $object)
67		{
68
69		parent::addToCache($object);
70
71		$this->cacheByString($object);
72
73		return $this;
74
75		}
76
77
78		/**
79		* @inheritdoc
80		*/
81		public function findCacheByRecord(Record $record)
82		{
83
84		if ($model = parent::findCacheByRecord($record)) {
85		return $model;
86		}
87
88		return $this->findCacheByRecordByString($record);
89
90		}
91
92		}

flipbox / spark

Push — master ( 58a092...20e86c )

ObjectByIdOrString::find() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like