ObjectAccessor - Code Metrics - Inspection of "commit message" - flipbox/spark - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5a9c7e...e00e24 )

by Nate

created 2017-03-28 00:16 UTC

ObjectAccessor C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	706
Duplicated Lines	34.99 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

Metric	Value
wmc	69
lcom	1
cbo	8
dl	247
loc	706
rs	5
c	0
b	0
f	0

34 Methods

Rating	Name	Duplication	Size	Complexity
	objectClass()	0	1	?
A	objectClassInstance()	0	4	1
B	create()	24	24	4
A	createFromRecord()	0	20	3
B	findAll()	24	24	4
A	getAll()	0	12	2
B	find()	22	22	4
A	get()	0	13	2
B	findById()	25	25	3
A	getById()	13	13	2
A	freshFindById()	14	14	2
A	freshGetById()	12	12	2
A	findAllByQuery()	12	12	2
A	findByQuery()	11	11	2
A	findAllByCondition()	17	17	3
A	getAllByCondition()	0	12	2
A	findByCondition()	11	11	2
A	getByCondition()	0	12	2
A	findAllByCriteria()	18	18	3
A	getAllByCriteria()	0	12	2
A	findByCriteria()	11	11	2
A	getByCriteria()	0	12	2
A	findByRecord()	17	17	2
A	getByRecord()	0	4	1
A	findCache()	16	16	3
A	findCacheById()	0	13	2
A	isCachedById()	0	4	1
A	cacheById()	0	14	2
A	findCacheByRecord()	0	12	2
A	addToCache()	0	7	1
A	notFoundException()	0	10	1
A	notFoundByIdException()	0	11	1
A	notFoundByCriteriaException()	0	11	1
A	notFoundByConditionException()	0	11	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like ObjectAccessor often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use ObjectAccessor, and based on these observations, apply Extract Interface, too.

<?php

/**
 * @package    Spark
 * @author     Flipbox Factory <[email protected]>
 * @copyright  2010-2016 Flipbox Digital Limited
 * @license    https://github.com/FlipboxFactory/Craft3-Spark/blob/master/LICENSE
 * @link       https://github.com/FlipboxFactory/Craft3-Spark
 * @since      Class available since Release 1.0.0
 */

namespace flipbox\spark\services;

use craft\helpers\Json as JsonHelper;
use flipbox\spark\exceptions\ObjectNotFoundException;
use flipbox\spark\helpers\ArrayHelper;
use flipbox\spark\helpers\ObjectHelper;
use flipbox\spark\objects\Object;
use flipbox\spark\Records\Record;
use flipbox\spark\services\traits\ObjectRecordBehavior;
use yii\base\Component;
use yii\base\InvalidConfigException;
use yii\db\QueryInterface;

abstract class ObjectAccessor extends Component
{

    use ObjectRecordBehavior;

    /**
     * @var Object[]
     */
    protected $_cacheAll;

    /**
     * @var Object[]
     */
    protected $_cacheById = [];

    /*******************************************
     * OBJECT CLASSES
     *******************************************/

    /**
     * @return string
     */
    public abstract static function objectClass(): string;


    /**
     * @return string
     */
    public static function objectClassInstance(): string
    {
        return Object::class;
    }

    /*******************************************
     * CREATE
     *******************************************/

    /**
     * @param array $config
     * @throws InvalidConfigException
     * @return Object
     */
    public function create($config = []): Object

    {

        // Treat records as known data and set via config
        if ($config instanceof Record) {
            return $this->createFromRecord($config);
        }

        // Force Array
        if (!is_array($config)) {
            $config = ArrayHelper::toArray($config, [], false);
        }

        // Auto-set the class
        if ($class = static::objectClass()) {
            $config['class'] = $class;
        }

        return ObjectHelper::create(
            $config,
            static::objectClassInstance()
        );

    }

    /**
     * @param Record $record
     * @param string|null $toScenario
     * @throws InvalidConfigException
     * @return Object
     */
    protected function createFromRecord(Record $record, string $toScenario = null): Object
    {

        if (null !== $toScenario) {
            $record->setScenario($toScenario);
        }

        $config = $record->toArray();

        // Auto-set the class
        if ($class = static::objectClass()) {
            $config['class'] = $class;
        }

        return ObjectHelper::create(
            $config,
            static::objectClassInstance()
        );

    }


    /*******************************************
     * FIND/GET ALL
     *******************************************/

    /**
     * @param string $toScenario
     * @return Object[]
     */
    public function findAll(string $toScenario = null)

    {

        // Check addToCache
        if (is_null($this->_cacheAll)) {

            $this->_cacheAll = [];

            // Find record in db
            if ($records = $this->findAllRecords()) {

                foreach ($records as $record) {

                    $this->_cacheAll[] = $this->findByRecord($record, $toScenario);

                }

            }

        }

        return $this->_cacheAll;

    }

    /**
     * @param string $toScenario
     * @return Object[]
     * @throws ObjectNotFoundException
     */
    public function getAll(string $toScenario = null): array
    {

        if (!$objects = $this->findAll($toScenario)) {

            $this->notFoundException();

        }

        return $objects;

    }

    /*******************************************
     * FIND/GET
     *******************************************/

    /**
     * @param $identifier
     * @param string $toScenario
     * @return Object|null
     */
    public function find($identifier, string $toScenario = null)

    {

        if ($identifier instanceof Object) {

            $this->addToCache($identifier);

            return $identifier;

        } elseif ($identifier instanceof Record) {

            return $this->findByRecord($identifier, $toScenario);

        } elseif (is_numeric($identifier)) {

            return $this->findById($identifier, $toScenario);

        }

        return null;

    }

    /**
     * @param $identifier
     * @param string $toScenario
     * @return Object
     * @throws ObjectNotFoundException
     */
    public function get($identifier, string $toScenario = null): Object
    {

        // Find model by ID
        if (!$object = $this->find($identifier, $toScenario)) {

            $this->notFoundException();

        }

        return $object;

    }

    /*******************************************
     * FIND/GET BY ID
     *******************************************/

    /**
     * @param int $id
     * @param string|null $toScenario
     * @return Object|null
     */
    public function findById(int $id, string $toScenario = null)

    {

        // Check cache
        if (!$object = $this->findCacheById($id)) {

            // Find record in db
            if ($record = $this->findRecordById($id)) {

                // Perhaps in cache
                $object = $this->findByRecord($record, $toScenario);

            } else {

                $this->_cacheById[$id] = null;

                return null;

            }

        }

        return $object;

    }

    /**
     * @param int $id
     * @param string|null $toScenario
     * @return Object
     * @throws ObjectNotFoundException
     */
    public function getById(int $id, string $toScenario = null): Object

    {

        // Find by ID
        if (!$object = $this->findById($id, $toScenario)) {

            $this->notFoundByIdException($id);

        }

        return $object;

    }

    /**
     * @param int $id
     * @param string|null $toScenario
     * @return Object|null
     */
    public function freshFindById(int $id, string $toScenario = null)

    {

        // Find record in db
        if ($record = $this->findRecordById($id)) {

            // Create
            return $this->createFromRecord($record, $toScenario);

        }

        return null;

    }

    /**
     * @param int $id
     * @param string|null $toScenario
     * @return Object
     * @throws ObjectNotFoundException
     */
    public function freshGetById(int $id, string $toScenario = null): Object

    {

        if (!$object = $this->freshFindById($id, $toScenario)) {

            $this->notFoundByIdException($id);

        }

        return $object;

    }

    /*******************************************
     * FIND/GET BY QUERY
     *******************************************/

    /**
     * @param QueryInterface $query
     * @param string $toScenario
     * @return Object[]
     */
    public function findAllByQuery(QueryInterface $query, string $toScenario = null): array

    {

        $objects = array();

        foreach ($query->all() as $record) {
            $objects[] = $this->findByRecord($record, $toScenario);
        }

        return $objects;

    }

    /**
     * @param QueryInterface $query
     * @param string $toScenario
     * @return Object|null
     */
    public function findByQuery(QueryInterface $query, string $toScenario = null)

    {

        /** @var Record $record */
        if (!$record = $query->one()) {
            return null;
        }

        return $this->findByRecord($record, $toScenario);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

    }

    /*******************************************
     * FIND/GET BY CONDITION
     *******************************************/

    /**
     * @param $condition
     * @param string $toScenario
     * @return Object[]
     */
    public function findAllByCondition($condition, string $toScenario = null): array

    {

        $objects = [];

        // Find record in db
        if ($records = $this->findAllRecordsByCondition($condition)) {

            foreach ($records as $record) {
                $objects[] = $this->findByRecord($record, $toScenario);
            }

        }

        return $objects;

    }

    /**
     * @param $condition
     * @param string $toScenario
     * @return Object[]
     * @throws ObjectNotFoundException
     */
    public function getAllByCondition($condition, string $toScenario = null): array
    {

        if (!$objects = $this->findAllByCondition($condition, $toScenario)) {

            $this->notFoundByConditionException($condition);

        }

        return $objects;

    }

    /**
     * @param $condition
     * @param string $toScenario
     * @return Object|null
     */
    public function findByCondition($condition, string $toScenario = null)

    {

        // Find record in db
        if ($record = $this->findRecordByCondition($condition)) {
            return $this->findByRecord($record, $toScenario);
        }

        return null;

    }

    /**
     * @param $condition
     * @param string $toScenario
     * @return Object
     * @throws ObjectNotFoundException
     */
    public function getByCondition($condition, string $toScenario = null): Object
    {

        if (!$object = $this->findByCondition($condition, $toScenario)) {

            $this->notFoundByConditionException($condition);

        }

        return $object;

    }

    /*******************************************
     * FIND/GET BY CRITERIA
     *******************************************/

    /**
     * @param $criteria
     * @param string $toScenario
     * @return Object[]
     */
    public function findAllByCriteria($criteria, string $toScenario = null): array

    {

        $objects = [];

        // Find record in db
        if ($records = $this->findAllRecordsByCriteria($criteria)
        ) {

            foreach ($records as $record) {
                $objects[] = $this->findByRecord($record, $toScenario);
            }

        }

        return $objects;

    }

    /**
     * @param $criteria
     * @param string $toScenario
     * @return Object[]
     * @throws ObjectNotFoundException
     */
    public function getAllByCriteria($criteria, string $toScenario = null): array
    {

        if (!$objects = $this->findAllByCriteria($criteria, $toScenario)) {

            $this->notFoundByCriteriaException($criteria);

        }

        return $objects;

    }

    /**
     * @param $criteria
     * @param string $toScenario
     * @return Object|null
     */
    public function findByCriteria($criteria, string $toScenario = null)

    {

        // Find record in db
        if ($record = $this->findRecordByCriteria($criteria)) {
            return $this->findByRecord($record, $toScenario);
        }

        return null;

    }

    /**
     * @param $criteria
     * @param string $toScenario
     * @return Object
     * @throws ObjectNotFoundException
     */
    public function getByCriteria($criteria, string $toScenario = null): Object
    {

        if (!$object = $this->findByCriteria($criteria, $toScenario)) {

            $this->notFoundByCriteriaException($criteria);

        }

        return $object;

    }


    /*******************************************
     * FIND/GET BY RECORD
     *******************************************/

    /**
     * @param Record $record
     * @param string $toScenario
     * @return Object
     */
    public function findByRecord(Record $record, string $toScenario = null): Object

    {

        // Check addToCache
        if (!$object = $this->findCacheByRecord($record)) {

            // New model
            $object = $this->createFromRecord($record, $toScenario);

            // Cache it
            $this->addToCache($object);

        }

        return $object;

    }

    /**
     * @param Record $record
     * @param string $toScenario
     * @return Object
     */
    public function getByRecord(Record $record, string $toScenario = null): Object
    {
        return $this->findByRecord($record, $toScenario);
    }


    /*******************************************
     * CACHE
     *******************************************/

    /**
     * @param $identifier
     * @return Object|null
     */
    public function findCache($identifier)

    {

        if ($identifier instanceof Record) {

            return $this->findCacheByRecord($identifier);

        } elseif (is_numeric($identifier)) {

            return $this->findCacheById($identifier);

        }

        return null;

    }

    /**
     * Find an existing cache by ID
     *
     * @param $id
     * @return Object|null
     */
    public function findCacheById(int $id)
    {

        // Check if already in addToCache
        if ($this->isCachedById($id)) {

            return $this->_cacheById[$id];

        }

        return null;

    }

    /**
     * Identify whether in cache by ID
     *
     * @param $id
     * @return bool
     */
    protected function isCachedById(int $id)
    {
        return array_key_exists($id, $this->_cacheById);
    }

    /**
     * @param Object $object
     * @return $this
     */
    protected function cacheById(Object $object)
    {

        // Check if already in cache
        if (!$id = $this->isCachedById($object->id)) {

            // Cache it
            $this->_cacheById[$id] = $object;

        }

        return $this;

    }

    /**
     * @param Record $record
     * @return Object|null
     */
    public function findCacheByRecord(Record $record)
    {

        // Check if already in addToCache by id
        if ($id = $this->isCachedById($record->id)) {

            return $this->findCacheById($id);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        }

        return null;
    }

    /**
     * @param Object $object
     * @return static
     */
    public function addToCache(Object $object)
    {

        $this->cacheById($object);

        return $this;
    }


    /*******************************************
     * EXCEPTIONS
     *******************************************/

    /**
     * @throws ObjectNotFoundException
     */
    protected function notFoundException()
    {

        throw new ObjectNotFoundException(
            sprintf(
                "Object does not exist."
            )
        );

    }

    /**
     * @param int|null $id
     * @throws ObjectNotFoundException
     */
    protected function notFoundByIdException(int $id = null)
    {

        throw new ObjectNotFoundException(
            sprintf(
                'Object does not exist with the id "%s".',
                (string)$id
            )
        );

    }

    /**
     * @param null $criteria
     * @throws ObjectNotFoundException
     */
    protected function notFoundByCriteriaException($criteria = null)
    {

        throw new ObjectNotFoundException(
            sprintf(
                'Object does not exist with the criteria "%s".',
                (string)JsonHelper::encode($criteria)
            )
        );

    }

    /**
     * @param null $condition
     * @throws ObjectNotFoundException
     */
    protected function notFoundByConditionException($condition = null)
    {

        throw new ObjectNotFoundException(
            sprintf(
                'Object does not exist with the condition "%s".',
                (string)JsonHelper::encode($condition)
            )
        );

    }

}


flipbox / spark