flipbox /
skeleton
| Conditions | 17 |
| Paths | 13 |
| Total Lines | 92 |
| Code Lines | 47 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 306 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 26 | public static function encode($var): string |
||
| 27 | { |
||
| 28 | switch (gettype($var)) { |
||
| 29 | case 'boolean': |
||
| 30 | return $var ? 'true' : 'false'; |
||
| 31 | |||
| 32 | case 'NULL': |
||
| 33 | return 'null'; |
||
| 34 | |||
| 35 | case 'integer': |
||
| 36 | return (int)$var; |
||
| 37 | |||
| 38 | case 'double': |
||
| 39 | case 'float': |
||
| 40 | return str_replace(',', '.', (float)$var); // locale-independent representation |
||
| 41 | |||
| 42 | case 'string': |
||
| 43 | return json_encode($var); |
||
| 44 | |||
| 45 | case 'array': |
||
| 46 | /* |
||
| 47 | * As per JSON spec if any array key is not an integer |
||
| 48 | * we must treat the the whole array as an object. We |
||
| 49 | * also try to catch a sparsely populated associative |
||
| 50 | * array with numeric keys here because some JS engines |
||
| 51 | * will create an array with empty indexes up to |
||
| 52 | * max_index which can cause memory issues and because |
||
| 53 | * the keys, which may be relevant, will be remapped |
||
| 54 | * otherwise. |
||
| 55 | * |
||
| 56 | * As per the ECMA and JSON specification an object may |
||
| 57 | * have any string as a property. Unfortunately due to |
||
| 58 | * a hole in the ECMA specification if the key is a |
||
| 59 | * ECMA reserved word or starts with a digit the |
||
| 60 | * parameter is only accessible using ECMAScript's |
||
| 61 | * bracket notation. |
||
| 62 | */ |
||
| 63 | |||
| 64 | // treat as a JSON object |
||
| 65 | if (is_array($var) && |
||
| 66 | count($var) && |
||
| 67 | (array_keys($var) !== range(0, sizeof($var) - 1)) |
||
| 68 | ) { |
||
| 69 | return '{' . |
||
| 70 | join( |
||
| 71 | ',', |
||
| 72 | array_map( |
||
| 73 | [ |
||
| 74 | JsonHelper::class, |
||
| 75 | 'nameValue' |
||
| 76 | ], |
||
| 77 | array_keys($var), |
||
| 78 | array_values($var) |
||
| 79 | ) |
||
| 80 | ) . '}'; |
||
| 81 | } |
||
| 82 | |||
| 83 | // treat it like a regular array |
||
| 84 | return '[' . join(',', array_map(array(JsonHelper::class, 'encode'), $var)) . ']'; |
||
| 85 | |||
| 86 | case 'object': |
||
| 87 | // Check for the JsonSerializable interface available in PHP5.4 |
||
| 88 | // Note that instanceof returns false in case it doesn't know the interface. |
||
| 89 | if (interface_exists('JsonSerializable', false) && $var instanceof JsonSerializable) { |
||
|
Bug
introduced
by
|
|||
| 90 | // We use the function defined in the interface instead of json_encode. |
||
| 91 | // This way even for PHP < 5.4 one could define the interface and use it. |
||
| 92 | return self::encode($var->jsonSerialize()); |
||
| 93 | } elseif ($var instanceof \Traversable) { |
||
| 94 | $vars = []; |
||
| 95 | foreach ($var as $k => $v) { |
||
| 96 | $vars[$k] = $v; |
||
| 97 | } |
||
| 98 | } else { |
||
| 99 | $vars = get_object_vars($var); |
||
| 100 | } |
||
| 101 | return '{' . |
||
| 102 | join( |
||
| 103 | ',', |
||
| 104 | array_map( |
||
| 105 | [ |
||
| 106 | JsonHelper::class, |
||
| 107 | 'nameValue' |
||
| 108 | ], |
||
| 109 | array_keys($vars), |
||
| 110 | array_values($vars) |
||
| 111 | ) |
||
| 112 | ) . '}'; |
||
| 113 | |||
| 114 | default: |
||
| 115 | return ''; |
||
| 116 | } |
||
| 117 | } |
||
| 118 | |||
| 133 |
Loading history...