flipbox\organization\modules\configuration\controllers\LayoutController::actionSave()

Complexity

Conditions	5
Paths	8

Size

Total Lines	64
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

0

<?php
    public function actionSave()
    {

        // Admins and Post requests only
        $this->requireAdmin();
        $this->requirePostRequest();

        $request = Craft::$app->getRequest();
        $session = Craft::$app->getSession();

        /** @var Settings $model */
        $model = $this->module->module->getSettings();

        // Handle each site's url/template settings
        foreach (Craft::$app->getSites()->getAllSites() as $site) {
            $namespace = 'sites.' . $site->handle;

            $siteSettings = $model->getSite($site->id);
            $siteSettings->hasUrls = !empty($postedSettings['uriFormat']);

The variable $postedSettings seems to never exist, and therefore empty should always return true. Did you maybe rename this variable?

            // Group the field layout
            $siteSettings->setFieldLayout(
                Craft::$app->getFields()->assembleLayoutFromPost($namespace)
            );
        }

        // Save settings
        if (!$this->module->getLayout()->save($model)) {
            // Ajax request
            if (!$request->getAcceptsJson()) {
                // Fail message
                $message = Craft::t('organization', 'Settings NOT saved successfully.');

                // Flash fail message
                $session->setError($message);

                // Send the element back to the template
                Craft::$app->getUrlManager()->setRouteParams([
                    'settings' => $model
                ]);

                // Redirect
                return $this->redirectToPostedUrl($model);
            }

            return $this->asJson([
                'success' => false,
                'errors' => $model->getErrors(),
            ]);
        }

        // Ajax request
        if (!$request->getAcceptsJson()) {
            // Success message
            $message = Craft::t('organization', 'Settings saved successfully.');

            // Flash success message
            $session->setNotice($message);

            return $this->redirectToPostedUrl($model);
        }

        return $this->asJson($model);
    }
}