flack / openpsa

static/org.openpsa.widgets/ui.js

const org_openpsa_layout = {
    clip_toolbar: function() {
        if ($('#org_openpsa_toolbar > ul.view_toolbar').length === 0) {
            // there seem to be no toolbar buttons, so we don't need to do anything
            return;
        }
        var container = $('#toolbar_dropdown').length > 0 ? $('#toolbar_dropdown') : $('<li class="enabled submenu"><a><i class="fa fa-caret-down"></i> <span class="toolbar_label">' + TOOLBAR_MORE_LABEL + '</span></a><ul class="midcom_toolbar"></ul></li>')
            .attr('id', 'toolbar_dropdown')
            .data('event_attached', false)
            .mouseover(function() {
                var self = $(this);
                if (self.data('timeout')) {
                    clearTimeout(self.data('timeout'));
                    self.removeData('timeout');
                    return;
                }
                self.addClass('expanded');
            })
            .mouseout(function() {
                var self = $(this);
                self.data('timeout', setTimeout(function() {
                    self.removeClass('expanded');
                    self.removeData('timeout');
                }, 500));
            })
            .css('display', 'none')
            .appendTo('#org_openpsa_toolbar > ul.view_toolbar'),

            dropdown = container.find('ul.midcom_toolbar'),
            toolbarWidth = $('#org_openpsa_toolbar').width() - ($('#org_openpsa_toolbar .navigation_toolbar').width() || 0),
            over = false;

        $('#org_openpsa_toolbar > .view_toolbar > li:not(#toolbar_dropdown)').each(function() {
            if (!over && ($(this).position().left + $(this).width() + container.width()) > toolbarWidth) {
                over = true;
            }
            if (over) {
                if (!container.data('event_attached')) {
                    dropdown.append($(this).detach());
                } else {
                    dropdown.prepend($(this).detach());
                }
            }
        });
        if (!over) {
            dropdown.children('li:not(#toolbar_dropdown)').each(function() {
                var item = $(this)
                    .clone()
                    .css('visibility', 'hidden')
                    .insertBefore(container),

                    positionLast = $('#org_openpsa_toolbar .view_toolbar li:last-child').position().left + $('#org_openpsa_toolbar .view_toolbar li:last-child').width();

                if (positionLast < toolbarWidth) {
                    $(this).remove();
                    item.css('visibility', 'visible');

There is no return statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding return undefined; explicitly.

                } else {
                    item.remove();
                    return false;
                }
            });
        }

        if (dropdown.children('li').length > 0) {
            container.css('display', 'inline-block');
        } else {
            container.css('display', 'none');
        }
        if (!container.data('event_attached')) {
            $(window).resize(function(){org_openpsa_layout.clip_toolbar();});
            container.data('event_attached', true);
            container.parent().addClass('clip-initialized');
        }
    },

    add_splitter: function() {
        $('<div></div>')
            .attr('id', 'template_openpsa2_resizer')
            .css('left', $('#leftframe').width())
            .appendTo('#container');

        $('#template_openpsa2_resizer').draggable({
            axis: 'x',
            containment: 'window',
            stop: function(event, ui) {
                var offset = Math.max((ui.offset.left), 0);

                $('#leftframe').css('width', offset + 'px');

                $.post(MIDCOM_PAGE_PREFIX + '__mfa/asgard/preferences/ajax/', {openpsa2_offset: offset + 2});
                $(window).trigger('resize');
            }
        });
    },

    initialize_search: function(providers, config) {
        if (typeof providers !== 'object' || providers.length === 0) {
            return;
        }
        
        let defaults = {
            field: '#org_openpsa_search_query',
            current: providers[0].identifier
        };

        if (typeof config === 'string'){
            config = {field: defaults.field, current: config};
        }

        config = Object.assign(defaults, config);

        var field = $(config.field),
            form = field.closest('form'), 
            selector = $('<ul class="org_openpsa_search_providers"></ul>'),
            li_class = '';

        function enable_provider(provider) {
            field
                .attr('placeholder', provider.placeholder || '')
                .focus();
            form.attr('action', provider.url);

            if (provider.autocomplete) {
                field.category_complete({
                    source: function (request, response) {
                        $.ajax({
                            url: provider.url + '/autocomplete/',
                            dataType: 'json',
                            data: {query: request.term},
                            success: response,
                            error: function(jqXHR, textStatus, errorThrown) {
                                field.trigger('autocompleteerror', [jqXHR, textStatus, errorThrown]);
                                response([]);
                            }
                        });
                    },
                    select: function (event, ui) {
                        if (ui.item) {
                            location.href = ui.item.url;
                        }
                    },
                    minLength: 2,
                    autoFocus: true
                });
            }
        }

        providers.forEach(function(provider) {
            li_class = 'provider';
            if (config.current === provider.identifier) {
                li_class += ' current';
                enable_provider(provider);
            }

            $('<li class="' + li_class + '">' + provider.placeholder + '</li>')
                .data('provider', provider)
                .click(function() {
                    var old_item = form.find('.org_openpsa_search_providers .current');

                    if (old_item.data('provider').autocomplete) {
                        field.category_complete('destroy');
                    }

                    old_item.removeClass('current');
                    $(this).addClass('current');

                    enable_provider(provider);

                    form.find('.org_openpsa_search_trigger').click();

                    $.post(MIDCOM_PAGE_PREFIX + '__mfa/asgard/preferences/ajax/', {openpsa2_search_provider: provider.identifier});
                })
                .appendTo(selector);
        });

        var search = location.search.replace(/^.*?[\?|&]query=([^&]*).*/, '$1');
        if (search !== '' && search !== location.search) {
            field.val(decodeURIComponent(search));
        }

        selector.insertBefore(field);

        $('<div class="org_openpsa_search_trigger"><i class="fa fa-search"></i></div>')
            .click(function() {
                form.find('.org_openpsa_search_providers').toggle();
                $(this).toggleClass('focused');
            })
            .insertBefore(field);

        field.show();
    }
};