flack / openpsa

lib/errors.php

Spacing +1 added lines, -1 removed lines

@@ -140,7 +140,7 @@
             return;
         }
 
-        if (   !is_writable($config['filename'])
+        if (!is_writable($config['filename'])
             && !is_writable(dirname($config['filename']))) {
             debug_add("Error logging file {$config['filename']} is not writable", MIDCOM_LOG_WARN);
             return;

lib/midcom/admin/folder/handler/move.php

Braces +2 added lines, -1 removed lines

@@ -47,7 +47,8 @@
                 $target = new midcom_db_topic($request->request->getInt('move_to'));
                 $this->_move_object($target);
                 midcom::get()->uimessages->add($this->_l10n->get($this->_component), sprintf($this->_l10n->get('moved %s to %s'), $this->_topic->get_label(), $target->get_label()));
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 midcom::get()->uimessages->add($this->_l10n->get($this->_component), $e->getMessage(), 'error');
             }
         }

Spacing +3 added lines, -3 removed lines

@@ -33,7 +33,7 @@ 
     {
         $this->_object = midcom::get()->dbfactory->get_object_by_guid($guid);
 
-        if (   !($this->_object instanceof midcom_db_topic)
+        if (!($this->_object instanceof midcom_db_topic)
             && !($this->_object instanceof midcom_db_article)) {
             throw new midcom_error_notfound("Moving only topics and articles is supported.");
         }
@@ -74,7 +74,7 @@ 
             $folder = midcom_core_context::get()->get_key(MIDCOM_CONTEXT_ROOTTOPIC);
         }
 
-        if (   $this->_object instanceof midcom_db_topic
+        if ($this->_object instanceof midcom_db_topic
             && $folder->up == $this->_object->id) {
             $tree_disabled = true;
         }
@@ -87,7 +87,7 @@ 
             $selected = ' checked="checked"';
         }
 
-        if (   !($this->_object instanceof midcom_db_topic)
+        if (!($this->_object instanceof midcom_db_topic)
             && $folder->component !== $this->current_folder->component) {
             // Non-topic objects may only be moved under folders of same component
             $class = 'wrong_component';

lib/org/openpsa/products/product/group.php

Spacing +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
         }
 
         $result_cache[$cache_key] = [];
-        $ret =& $result_cache[$cache_key];
+        $ret = & $result_cache[$cache_key];
 
         if (empty($up)) {
             // TODO: use reflection to see what kind of property this is ?

lib/org/openpsa/relatedto/handler/journal/list.php

Spacing +1 added lines, -1 removed lines

@@ -149,7 +149,7 @@
             }
 
             $reflector = midcom_helper_reflector::get($linked_object);
-            $link_html = "<a href='" . midcom::get()->permalinks->create_permalink($linked_object->guid) . "'>" . $reflector->get_object_label($linked_object) ."</a>";
+            $link_html = "<a href='" . midcom::get()->permalinks->create_permalink($linked_object->guid) . "'>" . $reflector->get_object_label($linked_object) . "</a>";
             $data['linked_objects'][$entry->linkGuid] = $link_html;
             $data['linked_raw_objects'][$entry->linkGuid] = $reflector->get_object_label($linked_object);
         }

Braces +2 added lines, -1 removed lines

@@ -142,7 +142,8 @@
             //create reflector with linked object to get the right label
             try {
                 $linked_object = midcom::get()->dbfactory->get_object_by_guid($entry->linkGuid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 unset($data['entries'][$i]);
                 $e->log();
                 continue;

lib/org/openpsa/mail/template.php

Spacing +1 added lines, -1 removed lines

@@ -103,7 +103,7 @@
         foreach ($parameters as $key => $value) {
             $this->_patterns[] = "/__({$key})__/";
 
-            if (   is_array($value)
+            if (is_array($value)
                 || is_object($value)) {
                 $this->_patterns[] = "/__({$key})_([^ \.>\"-]*?)__/";
             }

lib/midcom/helper/imagefilter.php

Spacing +3 added lines, -3 removed lines

@@ -341,7 +341,7 @@ 
         $tmpfile = null;
         $imagesize = getimagesize($this->_filename);
 
-        if (   $imagesize[2] == IMAGETYPE_JPEG
+        if ($imagesize[2] == IMAGETYPE_JPEG
             && $this->_jpegtran_available()) {
             /* jpegtran */
             $operations = [
@@ -409,7 +409,7 @@ 
         $imagesize = getimagesize($this->_filename);
 
         // Try lossless jpegtran rotation if possible
-        if (   $imagesize[2] == IMAGETYPE_JPEG
+        if ($imagesize[2] == IMAGETYPE_JPEG
             && ($rotate % 90 == 0)
             && $this->_jpegtran_available()) {
             $tmpfile = $this->_get_tempfile();
@@ -539,7 +539,7 @@ 
      */
     public function fill($x = null, $y = null, $color = null, string $gravity = 'center')
     {
-        if (   empty($x)
+        if (empty($x)
             || empty($y)
             || empty($color)) {
             //This is a bit silly, but here for backwards compatibility...

lib/org/openpsa/invoices/invoice/pdf.php

Spacing +1 added lines, -1 removed lines

@@ -97,7 +97,7 @@
             $attachment->update();
         } else {
             $attachment = $this->invoice->create_attachment($filename, $this->invoice->get_label(), "application/pdf");
-            if (   !$attachment
+            if (!$attachment
                 || !$this->invoice->set_parameter("midcom.helper.datamanager2.type.blobs", "guids_pdf_file", $attachment->guid . ":" . $attachment->guid)) {
                 throw new midcom_error("Failed to create invoice attachment for pdf: " . midcom_connection::get_error_string());
             }

lib/midcom/services/auth/backend.php

Spacing +2 added lines, -2 removed lines

@@ -100,7 +100,7 @@ 
             return null;
         }
 
-        if (   midcom::get()->config->get('auth_check_client_ip')
+        if (midcom::get()->config->get('auth_check_client_ip')
             && $data['clientip'] != $request->getClientIp()) {
             debug_add("The session had mismatching client IP.", MIDCOM_LOG_INFO);
             debug_add("Expected {$data['clientip']}, got {$request->getClientIp()}.");
@@ -114,7 +114,7 @@ 
             return null;
         }
 
-        if (   !$this->check_timestamp($data['timestamp'], $user)
+        if (!$this->check_timestamp($data['timestamp'], $user)
             || !$this->authenticate($user->username, '', true)) {
             $this->logout($user);
             return null;

Braces +2 added lines, -1 removed lines

@@ -79,7 +79,8 @@
         if (!array_key_exists($id, $this->_user_cache)) {
             try {
                 $this->_user_cache[$id] = new midcom_core_user($param);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 // Keep it silent while missing user object can mess here
                 $this->_user_cache[$id] = null;
             }

lib/midgard/admin/asgard/handler/undelete.php

Spacing +1 added lines, -1 removed lines

@@ -149,7 +149,7 @@
             $child_indent = $indent + 20;
             echo "{$prefix}<tbody class=\"children\">\n";
             foreach ($child_types as $type => $children) {
-                if (   count($children) < 10
+                if (count($children) < 10
                     || isset($_GET['show_children'][$object->guid][$type])) {
                         foreach ($children as $child) {
                             $this->show_type($child, $child_indent, "{$prefix}    ", false);