flack / openpsa

lib/org/openpsa/documents/document.php

Spacing +2 added lines, -2 removed lines

@@ -84,7 +84,7 @@ 
             return;
         }
         $parent = $this->get_parent();
-        if (   $parent
+        if ($parent
             && $parent->component == 'org.openpsa.documents') {
             midcom::get()->auth->request_sudo('org.openpsa.documents');
 
@@ -154,7 +154,7 @@ 
             $backup_attachment = $backup->create_attachment($original_attachment->name, $original_attachment->title, $original_attachment->mimetype);
 
             $original_handle = $original_attachment->open('r');
-            if (   !$backup_attachment
+            if (!$backup_attachment
                 || !$original_handle) {
                 // Failed to copy the attachment, abort
                 return $backup->delete();

lib/org/openpsa/widgets/contact.php

Spacing +7 added lines, -7 removed lines

@@ -159,12 +159,12 @@ 
             }
         }
 
-        if (   $this->_config->get('jabber_enable_presence')
+        if ($this->_config->get('jabber_enable_presence')
             && $person->get_parameter('org.openpsa.jabber', 'jid')) {
             $this->contact_details['jid'] = $person->get_parameter('org.openpsa.jabber', 'jid');
         }
 
-        if (   $this->_config->get('skype_enable_presence')
+        if ($this->_config->get('skype_enable_presence')
             && $person->get_parameter('org.openpsa.skype', 'name')) {
             $this->contact_details['skype'] = $person->get_parameter('org.openpsa.skype', 'name');
         }
@@ -201,7 +201,7 @@ 
         if (!empty($attachments[$type])) {
             return '<img class="photo" src="' . midcom_db_attachment::get_url($attachments[$type]) . '">';
         }
-        if (   $this->_config->get('gravatar_enable')
+        if ($this->_config->get('gravatar_enable')
             && !empty($this->contact_details['email'])) {
             $size = ($type == 'view') ? 500 : 32;
             $gravatar_url = "https://www.gravatar.com/avatar/" . md5(strtolower(trim($this->contact_details['email']))) . "?s=" . $size . '&d=identicon';
@@ -313,7 +313,7 @@ 
 
     private function _show_groups()
     {
-        if (   !$this->show_groups
+        if (!$this->show_groups
             || empty($this->contact_details['id'])) {
             return;
         }
@@ -377,7 +377,7 @@ 
                     $default_shown = true;
                     $cards_to_show[] = $cardname;
                 }
-            } elseif (    $customer->$property
+            } elseif ($customer->$property
                       || ($customer->street && !$inherited_cards_only && !$default_shown)) {
                 $inherited_cards_only = false;
                 $multiple_addresses = true;
@@ -398,8 +398,8 @@ 
 
         foreach ($cards_to_show as $cardname) {
             echo '<div class="vcard">';
-            if (   $multiple_addresses
-                || (   $cardname != 'visiting'
+            if ($multiple_addresses
+                || ($cardname != 'visiting'
                     && !$inherited_cards_only)) {
                 echo '<div style="text-align:center"><em>' . midcom::get()->i18n->get_string($cardname . ' address', 'org.openpsa.contacts') . "</em></div>\n";
             }

Braces +4 added lines, -2 removed lines

@@ -113,7 +113,8 @@ 
 
         try {
             $person = midcom_db_person::get_cached($src);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             return $cache[$src] = new self(new midcom_db_person);
         }
 
@@ -313,7 +314,8 @@ 
         foreach ($mc->get_rows(['gid', 'extra']) as $data) {
             try {
                 $group = org_openpsa_contacts_group_dba::get_cached($data['gid']);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
                 continue;
             }

lib/midcom/admin/rcs/style/midcom-admin-rcs-history.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
         echo "                    <td><a href='" . $data['router']->generate('preview', ['guid' => $guid, 'revision' => $number]) . "'>{$revision['version']}</a></td>\n";
         echo "                    <td>" . $formatter->datetime($revision['date']) . "</td>\n";
 
-        if (   $revision['user']
+        if ($revision['user']
             && $user = midcom::get()->auth->get_user($revision['user'])) {
             $person_label = $user->get_storage()->name;
             echo "                    <td>{$person_label}</td>\n";

src/midcom/datamanager/template/plaintext.php

Spacing +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
 
     public function form_widget_simple(FormView $view, array $data)
     {
-        if (   !empty($data['value'])
+        if (!empty($data['value'])
             || is_numeric($data['value'])) {
             return $data['value'];
         }

src/midcom/datamanager/template/view.php

Spacing +1 added lines, -1 removed lines

@@ -143,7 +143,7 @@
 
     public function form_widget_simple(FormView $view, array $data)
     {
-        if (   !empty($data['value'])
+        if (!empty($data['value'])
             || is_numeric($data['value'])) {
             return $this->escape($data['value']);
         }

lib/midcom/core/dbaproxy.php

Braces +2 added lines, -1 removed lines

@@ -64,7 +64,8 @@
         try {
             $this->__object = $this->__midcom_class_name__::get_cached($this->__identifier);
             return true;
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
         return false;

lib/org/openpsa/directmarketing/sender/backend/email.php

Spacing +1 added lines, -1 removed lines

@@ -166,7 +166,7 @@
         $address = addslashes($address);
         return preg_replace_callback(
             '/href="(http:\/\/.*?)"/i',
-            function ($match) use ($address) {
+            function($match) use ($address) {
                 return 'href="' . str_replace("URL", rawurlencode($match[1]), $address) . '"';
             },
             $html);

Indentation +7 added lines, -7 removed lines

@@ -148,13 +148,13 @@
     }
 
     /**
-    * Inserts a link detector to the given HTML source. All outgoing
-    * HTTP links in the source HTML are replaced with the given
-    * link detector address so that the token "URL" is replaced with
-    * encoded form of the original link. It is expected that the link detector
-    * address points to a script that records the passed link and
-    * forwards the client to the real link target.
-    */
+     * Inserts a link detector to the given HTML source. All outgoing
+     * HTTP links in the source HTML are replaced with the given
+     * link detector address so that the token "URL" is replaced with
+     * encoded form of the original link. It is expected that the link detector
+     * address points to a script that records the passed link and
+     * forwards the client to the real link target.
+     */
     private function _insert_link_detector(string $html, string $address) : string
     {
         $address = addslashes($address);

lib/midcom/services/auth/main.php

Braces +2 added lines, -1 removed lines

@@ -575,7 +575,8 @@
                     $param = $param->__object;
                 }
                 $this->_group_cache[$id] = new midcom_core_group($param);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 debug_add("Group with identifier {$id} could not be loaded: " . $e->getMessage(), MIDCOM_LOG_WARN);
                 $this->_group_cache[$id] = null;
             }

Spacing +1 added lines, -1 removed lines

@@ -221,7 +221,7 @@
             return true;
         }
         if ($user === null) {
-            $user =& $this->user;
+            $user = & $this->user;
         }
 
         if ($user == 'EVERYONE') {

lib/midgard/admin/asgard/schemadb.php

Spacing +4 added lines, -4 removed lines

@@ -64,7 +64,7 @@ 
 
     protected function add_string_field(string $key, string $type)
     {
-        if (   $key == 'component'
+        if ($key == 'component'
             && $type == midcom_db_topic::class) {
             $this->_add_component_dropdown($key);
             return;
@@ -134,12 +134,12 @@ 
         parent::add_longtext_field($key);
 
         // Check the user preference and configuration
-        if (   in_array($key, ['content', 'description'])
+        if (in_array($key, ['content', 'description'])
             && midgard_admin_asgard_plugin::get_preference('tinymce_enabled')) {
             $this->schema['fields'][$key]['widget'] = 'tinymce';
         }
 
-        if (   in_array($key, ['value', 'code'])
+        if (in_array($key, ['value', 'code'])
             && midgard_admin_asgard_plugin::get_preference('codemirror_enabled')) {
             $this->schema['fields'][$key]['widget'] = 'codemirror';
         }
@@ -257,7 +257,7 @@ 
         if ($score1 > $score2) {
             return 1;
         }
-        if (   $score1 < 3
+        if ($score1 < 3
             || $score1 > 6) {
             return strnatcmp($first, $second);
         }