flack / openpsa

lib/midgard/admin/asgard/handler/object/manage.php

Spacing +2 added lines, -2 removed lines

@@ -223,10 +223,10 @@
             $new_type_reflector = midcom_helper_reflector::get($new_type);
             $link_properties = $new_type_reflector->get_link_properties();
             foreach ($link_properties as $property => $link) {
-                if (   ($link['class'] && midcom_helper_reflector::is_same_class($link['class'], $this->_object->__mgdschema_class_name__))
+                if (($link['class'] && midcom_helper_reflector::is_same_class($link['class'], $this->_object->__mgdschema_class_name__))
                     || $link['type'] == MGD_TYPE_GUID) {
                     $defaults[$property] = $this->_object->{$link['target']};
-                } elseif (   $property == $parent_property
+                } elseif ($property == $parent_property
                           && midcom_helper_reflector::is_same_class($new_type, $this->_object->__mgdschema_class_name__)) {
                     $defaults[$property] = $this->_object->$parent_property;
                 }

lib/midcom/services/auth/main.php

Spacing +1 added lines, -1 removed lines

@@ -221,7 +221,7 @@
             return true;
         }
         if ($user === null) {
-            $user =& $this->user;
+            $user = & $this->user;
         }
 
         if ($user == 'EVERYONE') {

lib/org/openpsa/contacts/person.php

Spacing +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
 
     public function __set($name, $value)
     {
-        if (   $name == 'homepage'
+        if ($name == 'homepage'
             && !empty($value)
             && $value != $this->homepage) {
             $this->_register_prober = true;

lib/midgard/admin/asgard/stylehelper.php

Spacing +5 added lines, -5 removed lines

@@ -22,7 +22,7 @@ 
 
     public function __construct(array &$data)
     {
-        $this->_data =& $data;
+        $this->_data = & $data;
         midcom::get()->head->enable_jquery_ui(['accordion']);
     }
 
@@ -32,14 +32,14 @@ 
             return;
         }
 
-        if (   midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_style')
-            && (   $this->_data['handler_id'] !== 'object_create'
+        if (midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_style')
+            && ($this->_data['handler_id'] !== 'object_create'
                 || $this->_data['current_type'] == 'midgard_element')) {
             // Suggest element names to create under a style
             $this->_data['help_style_elementnames'] = $this->_get_style_elements_and_nodes($this->_data['object']->id);
             midcom_show_style('midgard_admin_asgard_stylehelper_elementnames');
 
-        } elseif (   midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_element')
+        } elseif (midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_element')
                   && $this->_get_help_element()) {
             midcom_show_style('midgard_admin_asgard_stylehelper_element');
         }
@@ -47,7 +47,7 @@ 
 
     private function _get_help_element() : bool
     {
-        if (   empty($this->_data['object']->name)
+        if (empty($this->_data['object']->name)
             || empty($this->_data['object']->style)) {
             // We cannot help with empty elements
             return false;

lib/net/nehmer/blog/handler/view.php

Spacing +2 added lines, -2 removed lines

@@ -48,7 +48,7 @@ 
             ]);
         }
 
-        if (   $this->_article->topic === $this->_topic->id
+        if ($this->_article->topic === $this->_topic->id
             && $this->_article->can_do('midgard:delete')) {
             $delete = $this->get_workflow('delete', ['object' => $this->_article]);
             $buttons[] = $delete->get_button("delete/{$this->_article->guid}/");
@@ -83,7 +83,7 @@ 
         if ($this->_config->get('comments_enable')) {
             if ($node = net_nehmer_comments_interface::get_node($this->_topic, $this->_config->get('comments_topic'))) {
                 $data['comments_url'] = $node[MIDCOM_NAV_RELATIVEURL] . "comment/{$this->_article->guid}";
-                if (   $this->_topic->can_do('midgard:update')
+                if ($this->_topic->can_do('midgard:update')
                     && $this->_topic->can_do('net.nehmer.comments:moderation')) {
                     net_nehmer_comments_viewer::add_head_elements();
                 }

lib/org/openpsa/directmarketing/midcom/interfaces.php

Spacing +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
     public function _on_watched_dba_delete(midcom_core_dbaobject $object)
     {
         $qb = org_openpsa_directmarketing_campaign_member_dba::new_query_builder();
-        if (   $object instanceof midcom_db_person
+        if ($object instanceof midcom_db_person
             || $object instanceof org_openpsa_contacts_person_dba) {
             $qb->add_constraint('person', '=', $object->id);
         } elseif ($object instanceof org_openpsa_directmarketing_campaign_dba) {

lib/errors.php

Spacing +1 added lines, -1 removed lines

@@ -140,7 +140,7 @@
             return;
         }
 
-        if (   !is_writable($config['filename'])
+        if (!is_writable($config['filename'])
             && !is_writable(dirname($config['filename']))) {
             debug_add("Error logging file {$config['filename']} is not writable", MIDCOM_LOG_WARN);
             return;

lib/net/nehmer/blog/handler/archive.php

Spacing +4 added lines, -4 removed lines

@@ -131,8 +131,8 @@ 
         $year_data = [];
         $first_post = $this->_compute_welcome_first_post();
         $this->_request_data['first_post'] = $first_post;
-        $this->_request_data['total_count'] =& $total_count;
-        $this->_request_data['year_data'] =& $year_data;
+        $this->_request_data['total_count'] = & $total_count;
+        $this->_request_data['year_data'] = & $year_data;
         if (!$first_post) {
             return;
         }
@@ -261,7 +261,7 @@ 
         switch ($handler_id) {
             case 'archive-year-category':
                 $category = trim(strip_tags($args[1]));
-                if (   $data['datamanager']->get_schema('default')->has_field('categories')
+                if ($data['datamanager']->get_schema('default')->has_field('categories')
                     && !$data['datamanager']->get_schema('default')->get_field('categories')['type_config']['allow_multiple']) {
                     $qb->add_constraint('extra1', '=', $category);
                 } else {
@@ -345,7 +345,7 @@ 
             throw new midcom_error_notfound("The year '{$year}' is not valid.");
         }
 
-        if (   $month < 1
+        if ($month < 1
             || $month > 12) {
             throw new midcom_error_notfound("The month {$month} is not valid.");
         }

lib/org/openpsa/products/product/group.php

Spacing +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
         }
 
         $result_cache[$cache_key] = [];
-        $ret =& $result_cache[$cache_key];
+        $ret = & $result_cache[$cache_key];
 
         if (empty($up)) {
             // TODO: use reflection to see what kind of property this is ?