Passed
Push — master ( 5e64e2...da283d )
by Andreas
12:33
created
lib/org/openpsa/user/validator.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         $result = $this->is_username_available($fields);
48 48
 
49 49
         $accounthelper = new org_openpsa_user_accounthelper();
50
-        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])){
50
+        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])) {
51 51
             $result = ['password' => midcom::get()->i18n->get_string('password weak', 'org.openpsa.user')];
52 52
         }
53 53
 
@@ -149,10 +149,10 @@  discard block
 block discarded – undo
149 149
         $user = new midcom_db_person($fields["person"]);
150 150
 
151 151
         $accounthelper = new org_openpsa_user_accounthelper($user);
152
-        if (!$accounthelper->check_password_reuse($fields['new_password'])){
152
+        if (!$accounthelper->check_password_reuse($fields['new_password'])) {
153 153
             $result['password'] = midcom::get()->i18n->get_string('password was already used', 'org.openpsa.user');
154 154
         }
155
-        if (!$accounthelper->check_password_strength($fields['new_password'])){
155
+        if (!$accounthelper->check_password_strength($fields['new_password'])) {
156 156
             $result['password'] = midcom::get()->i18n->get_string('password weak', 'org.openpsa.user');
157 157
         }
158 158
         return $result ?: true;
Please login to merge, or discard this patch.
Braces   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         $result = $this->is_username_available($fields);
48 48
 
49 49
         $accounthelper = new org_openpsa_user_accounthelper();
50
-        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])){
50
+        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])) {
51 51
             $result = ['password' => midcom::get()->i18n->get_string('password weak', 'org.openpsa.user')];
52 52
         }
53 53
 
@@ -149,10 +149,10 @@  discard block
 block discarded – undo
149 149
         $user = new midcom_db_person($fields["person"]);
150 150
 
151 151
         $accounthelper = new org_openpsa_user_accounthelper($user);
152
-        if (!$accounthelper->check_password_reuse($fields['new_password'])){
152
+        if (!$accounthelper->check_password_reuse($fields['new_password'])) {
153 153
             $result['password'] = midcom::get()->i18n->get_string('password was already used', 'org.openpsa.user');
154 154
         }
155
-        if (!$accounthelper->check_password_strength($fields['new_password'])){
155
+        if (!$accounthelper->check_password_strength($fields['new_password'])) {
156 156
             $result['password'] = midcom::get()->i18n->get_string('password weak', 'org.openpsa.user');
157 157
         }
158 158
         return $result ?: true;
Please login to merge, or discard this patch.
lib/org/openpsa/products/product/group.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
         }
75 75
 
76 76
         $result_cache[$cache_key] = [];
77
-        $ret =& $result_cache[$cache_key];
77
+        $ret = & $result_cache[$cache_key];
78 78
 
79 79
         if (empty($up)) {
80 80
             // TODO: use reflection to see what kind of property this is ?
Please login to merge, or discard this patch.
lib/org/openpsa/relatedto/handler/journal/list.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -149,7 +149,7 @@
 block discarded – undo
149 149
             }
150 150
 
151 151
             $reflector = midcom_helper_reflector::get($linked_object);
152
-            $link_html = "<a href='" . midcom::get()->permalinks->create_permalink($linked_object->guid) . "'>" . $reflector->get_object_label($linked_object) ."</a>";
152
+            $link_html = "<a href='" . midcom::get()->permalinks->create_permalink($linked_object->guid) . "'>" . $reflector->get_object_label($linked_object) . "</a>";
153 153
             $data['linked_objects'][$entry->linkGuid] = $link_html;
154 154
             $data['linked_raw_objects'][$entry->linkGuid] = $reflector->get_object_label($linked_object);
155 155
         }
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -142,7 +142,8 @@
 block discarded – undo
142 142
             //create reflector with linked object to get the right label
143 143
             try {
144 144
                 $linked_object = midcom::get()->dbfactory->get_object_by_guid($entry->linkGuid);
145
-            } catch (midcom_error $e) {
145
+            }
146
+            catch (midcom_error $e) {
146 147
                 unset($data['entries'][$i]);
147 148
                 $e->log();
148 149
                 continue;
Please login to merge, or discard this patch.
lib/org/openpsa/mail/template.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@
 block discarded – undo
103 103
         foreach ($parameters as $key => $value) {
104 104
             $this->_patterns[] = "/__({$key})__/";
105 105
 
106
-            if (   is_array($value)
106
+            if (is_array($value)
107 107
                 || is_object($value)) {
108 108
                 $this->_patterns[] = "/__({$key})_([^ \.>\"-]*?)__/";
109 109
             }
Please login to merge, or discard this patch.
lib/midcom/helper/imagefilter.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -341,7 +341,7 @@  discard block
 block discarded – undo
341 341
         $tmpfile = null;
342 342
         $imagesize = getimagesize($this->_filename);
343 343
 
344
-        if (   $imagesize[2] == IMAGETYPE_JPEG
344
+        if ($imagesize[2] == IMAGETYPE_JPEG
345 345
             && $this->_jpegtran_available()) {
346 346
             /* jpegtran */
347 347
             $operations = [
@@ -409,7 +409,7 @@  discard block
 block discarded – undo
409 409
         $imagesize = getimagesize($this->_filename);
410 410
 
411 411
         // Try lossless jpegtran rotation if possible
412
-        if (   $imagesize[2] == IMAGETYPE_JPEG
412
+        if ($imagesize[2] == IMAGETYPE_JPEG
413 413
             && ($rotate % 90 == 0)
414 414
             && $this->_jpegtran_available()) {
415 415
             $tmpfile = $this->_get_tempfile();
@@ -539,7 +539,7 @@  discard block
 block discarded – undo
539 539
      */
540 540
     public function fill($x = null, $y = null, $color = null, string $gravity = 'center')
541 541
     {
542
-        if (   empty($x)
542
+        if (empty($x)
543 543
             || empty($y)
544 544
             || empty($color)) {
545 545
             //This is a bit silly, but here for backwards compatibility...
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/invoice/pdf.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@
 block discarded – undo
97 97
             $attachment->update();
98 98
         } else {
99 99
             $attachment = $this->invoice->create_attachment($filename, $this->invoice->get_label(), "application/pdf");
100
-            if (   !$attachment
100
+            if (!$attachment
101 101
                 || !$this->invoice->set_parameter("midcom.helper.datamanager2.type.blobs", "guids_pdf_file", $attachment->guid . ":" . $attachment->guid)) {
102 102
                 throw new midcom_error("Failed to create invoice attachment for pdf: " . midcom_connection::get_error_string());
103 103
             }
Please login to merge, or discard this patch.
lib/midcom/services/auth/backend.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
             return null;
101 101
         }
102 102
 
103
-        if (   midcom::get()->config->get('auth_check_client_ip')
103
+        if (midcom::get()->config->get('auth_check_client_ip')
104 104
             && $data['clientip'] != $request->getClientIp()) {
105 105
             debug_add("The session had mismatching client IP.", MIDCOM_LOG_INFO);
106 106
             debug_add("Expected {$data['clientip']}, got {$request->getClientIp()}.");
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
             return null;
115 115
         }
116 116
 
117
-        if (   !$this->check_timestamp($data['timestamp'], $user)
117
+        if (!$this->check_timestamp($data['timestamp'], $user)
118 118
             || !$this->authenticate($user->username, '', true)) {
119 119
             $this->logout($user);
120 120
             return null;
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,8 @@
 block discarded – undo
79 79
         if (!array_key_exists($id, $this->_user_cache)) {
80 80
             try {
81 81
                 $this->_user_cache[$id] = new midcom_core_user($param);
82
-            } catch (midcom_error $e) {
82
+            }
83
+            catch (midcom_error $e) {
83 84
                 // Keep it silent while missing user object can mess here
84 85
                 $this->_user_cache[$id] = null;
85 86
             }
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/undelete.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -149,7 +149,7 @@
 block discarded – undo
149 149
             $child_indent = $indent + 20;
150 150
             echo "{$prefix}<tbody class=\"children\">\n";
151 151
             foreach ($child_types as $type => $children) {
152
-                if (   count($children) < 10
152
+                if (count($children) < 10
153 153
                     || isset($_GET['show_children'][$object->guid][$type])) {
154 154
                         foreach ($children as $child) {
155 155
                             $this->show_type($child, $child_indent, "{$prefix}    ", false);
Please login to merge, or discard this patch.
lib/net/nehmer/blog/style/index-item.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
         &(published:h);
29 29
             <?php
30 30
             if ($data['linked']) {
31
-                echo $data['l10n']->get('to') ." <a href=\"{$data['node'][MIDCOM_NAV_ABSOLUTEURL]}\">{$data['node'][MIDCOM_NAV_NAME]}</a>\n";
31
+                echo $data['l10n']->get('to') . " <a href=\"{$data['node'][MIDCOM_NAV_ABSOLUTEURL]}\">{$data['node'][MIDCOM_NAV_NAME]}</a>\n";
32 32
             }
33 33
             ?>
34 34
     </p>
Please login to merge, or discard this patch.