flack / openpsa

lib/net/nemein/rss/fetch.php

Spacing +6 added lines, -6 removed lines

@@ -101,7 +101,7 @@ 
             $etag = trim($parser->data['headers']['etag']);
 
             $feed_etag = $this->_feed->get_parameter('net.nemein.rss', 'etag');
-            if (   !empty($feed_etag)
+            if (!empty($feed_etag)
                 && $feed_etag == $etag) {
                 // Feed hasn't changed, skip updating
                 debug_add("Feed {$this->_feed->url} has not changed since " . date('c', $this->_feed->latestfetch), MIDCOM_LOG_WARN);
@@ -187,7 +187,7 @@ 
         $guid = $item->get_id();
         $title = $item->get_title();
 
-        if (   (   empty($title)
+        if ((empty($title)
                 || trim($title) == '...')
             && empty($guid)) {
             // Something wrong with this entry, skip it
@@ -255,7 +255,7 @@ 
                 $meta_values['published'] = $article_date;
             }
 
-            if (   $this->apply_values($article, $values, $meta_values)
+            if ($this->apply_values($article, $values, $meta_values)
                 && !$article->update()) {
                 return false;
             }
@@ -284,14 +284,14 @@ 
     private function find_author(net_nemein_rss_parser_item $item)
     {
         // Try to figure out item author
-        if (   $this->_feed->forceauthor
+        if ($this->_feed->forceauthor
             && $this->_feed->defaultauthor) {
             // Feed has a "default author" set, use it
             return new midcom_db_person($this->_feed->defaultauthor);
         }
         $author = $this->match_item_author($item);
         $fallback_person_id = 1;
-        if (   !$author
+        if (!$author
             || $author->id == $fallback_person_id) {
             if ($this->_feed->defaultauthor) {
                 // Feed has a "default author" set, use it
@@ -477,7 +477,7 @@ 
             }
         }
 
-        if (   !empty($author_info['username'])
+        if (!empty($author_info['username'])
             && $person = midcom::get()->auth->get_user_by_name($author_info['username'])) {
             return $person->get_storage();
         }

lib/net/nehmer/static/navigation.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
         $qb->add_constraint('name', '<>', '');
 
         // Unless in Auto-Index mode or the index article is hidden, we skip the index article.
-        if (   !$this->_config->get('autoindex')
+        if (!$this->_config->get('autoindex')
             && !$this->_config->get('indexinnav')) {
             $qb->add_constraint('name', '<>', 'index');
         }

lib/midgard/admin/asgard/handler/type.php

Spacing +2 added lines, -2 removed lines

@@ -109,8 +109,8 @@
         }
 
         $help = new midcom_admin_help_help();
-        $this->_request_data['help'] =  $help->get_help_contents('asgard_'.$this->type, $help_component);
-        $this->_request_data['component'] =  $component;
+        $this->_request_data['help'] = $help->get_help_contents('asgard_' . $this->type, $help_component);
+        $this->_request_data['component'] = $component;
     }
 
     /**

lib/midgard/admin/asgard/handler/undelete.php

Spacing +1 added lines, -1 removed lines

@@ -96,7 +96,7 @@
         $data['reflector'] = midcom_helper_reflector::get($data['type']);
         $data['label_property'] = $data['reflector']->get_label_property();
 
-        if (   isset($_POST['undelete'])
+        if (isset($_POST['undelete'])
             && is_array($_POST['undelete'])) {
             if (isset($_POST['purge'])) {
                 $this->_purge();

lib/midgard/admin/asgard/handler/welcome.php

Spacing +6 added lines, -6 removed lines

@@ -20,7 +20,7 @@ 
 
         // List installed MgdSchema types and convert to DBA classes
         foreach ($this->_request_data['schema_types'] as $schema_type) {
-            if (   !is_null($type)
+            if (!is_null($type)
                 && $schema_type != $type) {
                 // Skip
                 continue;
@@ -49,7 +49,7 @@ 
                 $qb->add_constraint('metadata.revised', '>=', $since);
             }
 
-            if (   $only_mine
+            if ($only_mine
                 && midcom::get()->auth->user) {
                 $qb->add_constraint('metadata.authors', 'LIKE', '|' . midcom::get()->auth->user->guid . '|');
             }
@@ -93,7 +93,7 @@ 
 
         $data['view_title'] = $this->_l10n->get('asgard');
 
-        if (    isset($_POST['execute_mass_action'])
+        if (isset($_POST['execute_mass_action'])
              && !empty($_POST['selections'])
              && isset($_POST['mass_action'])) {
             $method_name = "_mass_{$_POST['mass_action']}";
@@ -108,14 +108,14 @@ 
             }
 
             $data['review_by'] = null;
-            if (   $this->_config->get('enable_review_dates')
+            if ($this->_config->get('enable_review_dates')
                 && isset($_REQUEST['review_by'])
                 && $_REQUEST['review_by'] != 'any') {
                 $data['review_by'] = (int) $_REQUEST['review_by'];
             }
 
             $data['type_filter'] = null;
-            if (   isset($_REQUEST['type_filter'])
+            if (isset($_REQUEST['type_filter'])
                 && $_REQUEST['type_filter'] != 'any') {
                 $data['type_filter'] = $_REQUEST['type_filter'];
             }
@@ -274,7 +274,7 @@ 
                 continue;
             }
 
-            if (   $object->can_do('midgard:update')
+            if ($object->can_do('midgard:update')
                 && $object->can_do('midcom:approve')) {
                 $object->metadata->approve();
                 midcom::get()->uimessages->add($this->_l10n->get('midgard.admin.asgard'), sprintf($this->_l10n->get('object %s approved'), $object->guid));

Braces +8 added lines, -4 removed lines

@@ -147,7 +147,8 @@ 
         foreach ($activities as $activity) {
             try {
                 $object = midcom::get()->dbfactory->get_object_by_guid($activity->target);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 if (midcom_connection::get_error() == MGD_ERR_OBJECT_DELETED) {
                     // TODO: Visualize deleted objects somehow
                 }
@@ -155,7 +156,8 @@ 
             }
             try {
                 $actor = midcom_db_person::get_cached($activity->actor);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $actor = null;
             }
 
@@ -253,7 +255,8 @@ 
         foreach ($guids as $guid) {
             try {
                 $object = midcom::get()->dbfactory->get_object_by_guid($guid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 continue;
             }
 
@@ -270,7 +273,8 @@ 
         foreach ($guids as $guid) {
             try {
                 $object = midcom::get()->dbfactory->get_object_by_guid($guid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 continue;
             }
 

src/midcom/datamanager/storage/blobs.php

Spacing +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
         }
 
         if (!empty($this->config['widget_config']['sortable'])) {
-            uasort($this->map, function ($a, $b) {
+            uasort($this->map, function($a, $b) {
                 if ($a->metadata->score == $b->metadata->score) {
                     return strnatcasecmp($a->name, $b->name);
                 }

Braces +2 added lines, -1 removed lines

@@ -37,7 +37,8 @@
         foreach ($items as $identifier => $guid) {
             try {
                 $results[$identifier] = new midcom_db_attachment($guid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }

src/midcom/datamanager/storage/mnrelation.php

Spacing +1 added lines, -1 removed lines

@@ -99,7 +99,7 @@
         $qb = midcom::get()->dbfactory->new_query_builder($this->config['type_config']['mapping_class_name']);
         $qb->add_constraint($this->config['type_config']['master_fieldname'], '=', $this->get_master_foreign_key());
 
-        if (   $this->config['type_config']['sortable']
+        if ($this->config['type_config']['sortable']
             && preg_match('/^(ASC|DESC)/i', $this->config['type_config']['sortable_sort_order'], $regs)) {
             $order = strtoupper($regs[1]);
             $qb->add_order('metadata.score', $order);

src/midcom/datamanager/indexer/document.php

Spacing +3 added lines, -3 removed lines

@@ -137,7 +137,7 @@ 
             $this->content .= "{$this->abstract}\n";
         }
 
-        if (! $this->title) {
+        if (!$this->title) {
             $this->title = $this->document_url;
         }
     }
@@ -178,7 +178,7 @@ 
                     if (!empty($field->vars['value'])) {
                         //only index the first attachment for now
                         $attachment = array_shift($field->vars['value']);
-                        if (   !$attachment instanceof \midcom_db_attachment
+                        if (!$attachment instanceof \midcom_db_attachment
                             && !empty($attachment['object'])) {
                             //This is the form edit case
                             //@todo: In create case, nothing is found currently
@@ -262,7 +262,7 @@ 
      */
     private function resolve_auto_method($name)
     {
-        if (   $name == 'abstract'
+        if ($name == 'abstract'
             || $name == 'title'
             || $name == 'author') {
             return $name;

lib/org/openpsa/directmarketing/handler/logger.php

Spacing +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
         $qb = org_openpsa_directmarketing_campaign_messagereceipt_dba::new_query_builder();
         $qb->add_constraint('token', '=', $token);
         $qb->add_constraint('orgOpenpsaObtype', '=', $type);
-        $ret =  $qb->execute();
+        $ret = $qb->execute();
         debug_print_r("_qb_token_receipts({$token}) returned", $ret);
         if (empty($ret)) {
             midcom::get()->auth->drop_sudo();