flack / openpsa

lib/org/openpsa/core/acl/synchronizer.php

Spacing +3 added lines, -3 removed lines

@@ -15,7 +15,7 @@ 
 {
     public function write_acls(midcom_core_dbaobject $object, $owner_id, $accesstype)
     {
-        if (   empty($owner_id)
+        if (empty($owner_id)
             || empty($accesstype)) {
             return false;
         }
@@ -63,14 +63,14 @@ 
 
         if ($privileges) {
             foreach ($privileges as $privilege) {
-                if (   !empty($needed_privileges[$privilege->privilegename])
+                if (!empty($needed_privileges[$privilege->privilegename])
                     && $needed_privileges[$privilege->privilegename]['assignee'] == $privilege->assignee
                     && $needed_privileges[$privilege->privilegename]['value'] == $privilege->value) {
                     unset($needed_privileges[$privilege->privilegename]);
                     continue;
                 }
                 // Clear old ACLs applying to others than current user or selected owner group
-                if (   $privilege->assignee != midcom::get()->auth->user->id
+                if ($privilege->assignee != midcom::get()->auth->user->id
                     && $privilege->assignee != $owner_id) {
                     if (is_array($privilege->assignee)) {
                         $assignee_key = $privilege->assignee['identifier'];

lib/org/openpsa/core/filter/select.php

Spacing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
             echo '<select class="filter_input" onchange="document.forms[\'' . $this->name . '_filter\'].submit();" name="' . $this->name . '">';
 
             foreach ($options as $option) {
-                echo '<option value="' .  $option['id'] . '"';
+                echo '<option value="' . $option['id'] . '"';
                 if ($option['selected'] == true) {
                     echo " selected=\"selected\"";
                 }

lib/org/openpsa/core/queryfilter.php

Spacing +2 added lines, -2 removed lines

@@ -77,9 +77,9 @@
         $filter_id = $this->_identifier . '_' . $filtername;
         $user = midcom::get()->auth->user->get_storage();
 
-        if (   isset($_POST['unset_filter'])
+        if (isset($_POST['unset_filter'])
             && $_POST['unset_filter'] == $filter_id) {
-            if (   $user->get_parameter("org_openpsa_core_filter", $filter_id)
+            if ($user->get_parameter("org_openpsa_core_filter", $filter_id)
                 && !$user->delete_parameter("org_openpsa_core_filter", $filter_id)) {
                 $message_content = sprintf(
                     $l10n->get('the handed filter for %s could not be set as parameter'),

lib/org/openpsa/contacts/duplicates/merge.php

Spacing +6 added lines, -6 removed lines

@@ -45,7 +45,7 @@ 
      */
     public function merge($obj1, $obj2, $merge_mode)
     {
-        if (   $merge_mode !== 'all'
+        if ($merge_mode !== 'all'
             && $merge_mode !== 'future') {
             debug_add("invalid mode {$merge_mode}", MIDCOM_LOG_ERROR);
             throw new midcom_error('invalid merge mode');
@@ -87,9 +87,9 @@ 
                         if (!empty($conf['duplicate_check'])) {
                             $dup = $this->check_duplicate($results, $result, $conf['duplicate_check']);
 
-                            if (   is_object($dup)
+                            if (is_object($dup)
                                 || $dup === false) {
-                                if (   !is_object($dup)
+                                if (!is_object($dup)
                                     || !array_key_exists($dup->id, $todelete)) {
                                     $todelete[$result->id] = $result;
                                 }
@@ -98,7 +98,7 @@ 
                         }
                     }
                 }
-                if (   $needs_update
+                if ($needs_update
                     && !$result->update()) {
                     throw new midcom_error("Failed to update {$classname} #{$result->id}, errstr: " . midcom_connection::get_error_string());
                 }
@@ -147,7 +147,7 @@ 
         }
 
         foreach ($results as $result) {
-            if (   $result->$field === $object->$field
+            if ($result->$field === $object->$field
                 && $result->id !== $object->id) {
                 return $result;
             }
@@ -165,7 +165,7 @@ 
         $changed = false;
         foreach ($person2 as $property => $value) {
             // Copy only simple properties not marked to be skipped missing from person1
-            if (   empty($person2->$property)
+            if (empty($person2->$property)
                 || !empty($person1->$property)
                 || isset($skip_properties[$property])
                 || !is_scalar($value)) {

lib/org/openpsa/contacts/group.php

Spacing +2 added lines, -2 removed lines

@@ -31,7 +31,7 @@ 
 
     public function __set($name, $value)
     {
-        if (   $name == 'homepage'
+        if ($name == 'homepage'
             && !empty($value)
             && $value != $this->homepage) {
             $this->_register_prober = true;
@@ -77,7 +77,7 @@ 
 
     public function __get($property)
     {
-        if (   $property == 'invoice_label'
+        if ($property == 'invoice_label'
             || $property == 'postal_label') {
             if (!isset($this->_address_extras[$property])) {
                 $this->_get_address_extra($property);

lib/org/openpsa/contacts/person.php

Spacing +2 added lines, -2 removed lines

@@ -22,7 +22,7 @@ 
 
     public function __construct($identifier = null)
     {
-        if (   midcom::get()->config->get('person_class') != 'midgard_person'
+        if (midcom::get()->config->get('person_class') != 'midgard_person'
             && midcom::get()->config->get('person_class') != 'openpsa_person') {
             $this->__mgdschema_class_name__ = midcom::get()->config->get('person_class');
         }
@@ -31,7 +31,7 @@ 
 
     public function __set($name, $value)
     {
-        if (   $name == 'homepage'
+        if ($name == 'homepage'
             && !empty($value)
             && $value != $this->homepage) {
             $this->_url_changed = true;

lib/org/openpsa/qbpager/main.php

Spacing +7 added lines, -7 removed lines

@@ -61,16 +61,16 @@ 
     private function _check_page_vars()
     {
         $page_var = $this->_prefix . 'page';
-        $results_var =  $this->_prefix . 'results';
+        $results_var = $this->_prefix . 'results';
         if (!empty($_REQUEST[$page_var])) {
             debug_add("{$page_var} has value: {$_REQUEST[$page_var]}");
-            $this->_current_page = (int)$_REQUEST[$page_var];
+            $this->_current_page = (int) $_REQUEST[$page_var];
         }
         if (!empty($_REQUEST[$results_var])) {
             debug_add("{$results_var} has value: {$_REQUEST[$results_var]}");
-            $this->results_per_page = (int)$_REQUEST[$results_var];
+            $this->results_per_page = (int) $_REQUEST[$results_var];
         }
-        $this->_offset = ($this->_current_page-1)*$this->results_per_page;
+        $this->_offset = ($this->_current_page - 1) * $this->results_per_page;
         if ($this->_offset < 0) {
             $this->_offset = 0;
         }
@@ -292,7 +292,7 @@ 
         return $this->_midcom_qb->add_constraint($param, $op, $val);
     }
 
-    public function add_order($param, $sort='ASC')
+    public function add_order($param, $sort = 'ASC')
     {
         if (!$this->_sanity_check()) {
             return false;
@@ -329,7 +329,7 @@ 
         if (!$this->_sanity_check()) {
             return false;
         }
-        if (   !$this->count
+        if (!$this->count
             || $this->_count_mode != 'count') {
             $this->count = $this->_midcom_qb_count->count();
         }
@@ -342,7 +342,7 @@ 
         if (!$this->_sanity_check()) {
             return false;
         }
-        if (   !$this->count
+        if (!$this->count
             || $this->_count_mode != 'count_unchecked') {
             $this->count = $this->_midcom_qb_count->count_unchecked();
         }

lib/org/openpsa/projects/handler/task/resourcing.php

Spacing +2 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
         $this->_task = new org_openpsa_projects_task_dba($args[0]);
         $this->_task->require_do('midgard:create');
 
-        if (   array_key_exists('org_openpsa_projects_prospects', $_POST)
+        if (array_key_exists('org_openpsa_projects_prospects', $_POST)
             && $_POST['save']) {
             $qb = org_openpsa_projects_task_resource_dba::new_query_builder();
             $qb->add_constraint('guid', 'IN', array_keys($_POST['org_openpsa_projects_prospects']));
@@ -89,7 +89,7 @@ 
                     // create relatedto
                     org_openpsa_relatedto_plugin::create($event, 'org.openpsa.calendar', $this->_task, 'org.openpsa.projects');
                 }
-                if (   $update_prospect
+                if ($update_prospect
                     && !$prospect->update()) {
                     debug_add('Failed to update prospect: ' . midcom_connection::get_error_string(), MIDCOM_LOG_ERROR);
                 }

lib/org/openpsa/projects/task/status.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
     public function _on_created()
     {
         //Remove the resource if necessary
-        if (   $this->type == self::DECLINED
+        if ($this->type == self::DECLINED
             && $this->targetPerson) {
             $qb = org_openpsa_projects_task_resource_dba::new_query_builder();
             $qb->add_constraint('task', '=', $this->task);