Passed
Push — master ( 33989f...4d3c0d )
by Andreas
23:55
created
lib/org/openpsa/invoices/billing/data.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@
 block discarded – undo
60 60
      */
61 61
     public static function get_by_object(org_openpsa_invoices_interfaces_customer $object) : self
62 62
     {
63
-        if (   !($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer))
63
+        if (!($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer))
64 64
                // check if the customerContact is set and has invoice_data
65 65
             && !($bd = self::get_billing_data(org_openpsa_contacts_person_dba::class, $object->customerContact))) {
66 66
             $bd = new self();
Please login to merge, or discard this patch.
lib/org/openpsa/projects/task/resource.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -27,12 +27,12 @@
 block discarded – undo
27 27
     private function find_duplicates() : bool
28 28
     {
29 29
         $qb = self::new_query_builder();
30
-        $qb->add_constraint('person', '=', (int)$this->person);
31
-        $qb->add_constraint('task', '=', (int)$this->task);
32
-        $qb->add_constraint('orgOpenpsaObtype', '=', (int)$this->orgOpenpsaObtype);
30
+        $qb->add_constraint('person', '=', (int) $this->person);
31
+        $qb->add_constraint('task', '=', (int) $this->task);
32
+        $qb->add_constraint('orgOpenpsaObtype', '=', (int) $this->orgOpenpsaObtype);
33 33
 
34 34
         if ($this->id) {
35
-            $qb->add_constraint('id', '<>', (int)$this->id);
35
+            $qb->add_constraint('id', '<>', (int) $this->id);
36 36
         }
37 37
 
38 38
         return $qb->count() > 0;
Please login to merge, or discard this patch.
lib/net/nehmer/static/handler/admin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 
27 27
     private function load_controller() : controller
28 28
     {
29
-        if (    $this->_config->get('simple_name_handling')
29
+        if ($this->_config->get('simple_name_handling')
30 30
              && !midcom::get()->auth->admin) {
31 31
             foreach ($this->_request_data['schemadb']->all() as $schema) {
32 32
                 $schema->get_field('name')['readonly'] = true;
Please login to merge, or discard this patch.
lib/midcom/services/toolbars.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -314,7 +314,7 @@
 block discarded – undo
314 314
 
315 315
     private function add_head_elements(bool $centralized = false) : bool
316 316
     {
317
-        if (   !midcom::get()->auth->user
317
+        if (!midcom::get()->auth->user
318 318
             || !midcom::get()->config->get('toolbars_enable_centralized')
319 319
             || !midcom::get()->auth->can_user_do('midcom:centralized_toolbar', null, __CLASS__)) {
320 320
             return false;
Please login to merge, or discard this patch.
lib/midcom/services/i18n/l10n.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
             self::$_localedb[$this->_library] = [];
135 135
         }
136 136
 
137
-        $this->_stringdb =& self::$_localedb[$this->_library];
137
+        $this->_stringdb = & self::$_localedb[$this->_library];
138 138
 
139 139
         $this->set_language(midcom::get()->i18n->get_current_language());
140 140
     }
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
         $data = $this->parse_data(file($filename), $lang, $filename);
170 170
 
171 171
         // get site-specific l10n
172
-        $component_locale = midcom_helper_misc::get_snippet_content_graceful("conf:/" . $this->_component_name . '/l10n/'. $this->database . '.' . $lang . '.txt');
172
+        $component_locale = midcom_helper_misc::get_snippet_content_graceful("conf:/" . $this->_component_name . '/l10n/' . $this->database . '.' . $lang . '.txt');
173 173
         if (!empty($component_locale)) {
174 174
             $data = array_merge($data, $this->parse_data(explode("\n", $component_locale), $lang, $component_locale));
175 175
         }
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
     private function error(string $message, string $filename, int $line) : midcom_error
265 265
     {
266 266
         $line++; // Array is 0-indexed
267
-        return new midcom_error('L10n DB SYNTAX ERROR: ' .  $message . ' at ' . $filename . ' ' . $line);
267
+        return new midcom_error('L10n DB SYNTAX ERROR: ' . $message . ' at ' . $filename . ' ' . $line);
268 268
     }
269 269
 
270 270
     /**
Please login to merge, or discard this patch.
lib/midcom/services/metadata.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -109,20 +109,20 @@  discard block
 block discarded – undo
109 109
         }
110 110
 
111 111
         // Approval attributes
112
-        if (   midcom::get()->config->get('metadata_approval')
112
+        if (midcom::get()->config->get('metadata_approval')
113 113
             && !$object->metadata->is_approved()) {
114 114
             $css_classes[] = 'unapproved';
115 115
         }
116 116
 
117 117
         // Hiding and scheduling attributes
118
-        if (   (   !midcom::get()->config->get('show_hidden_objects')
118
+        if ((!midcom::get()->config->get('show_hidden_objects')
119 119
                 || midcom::get()->config->get('metadata_scheduling'))
120 120
             && !$object->metadata->is_visible()) {
121 121
             $css_classes[] = 'hidden';
122 122
         }
123 123
 
124 124
         // Folder's class
125
-        if (   $object instanceof midcom_db_topic
125
+        if ($object instanceof midcom_db_topic
126 126
             && $page_class = $object->get_parameter('midcom.services.metadata', 'page_class')) {
127 127
             $css_classes[] = $page_class;
128 128
         }
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
     private function _add_opengraph_metadata(midcom_helper_metadata $view_metadata)
194 194
     {
195 195
         $opengraph_type = $view_metadata->object->get_parameter('midcom.helper.metadata', 'opengraph_type');
196
-        if (   $opengraph_type
196
+        if ($opengraph_type
197 197
             && $opengraph_type != 'none') {
198 198
             $request_metadata = $this->get_request_metadata();
199 199
 
Please login to merge, or discard this patch.
lib/org/openpsa/reports/handler/invoices/report.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 
65 65
     private function _get_invoices_for_subscription(org_openpsa_sales_salesproject_deliverable_dba $deliverable, midcom_services_at_entry_dba $at_entry) : array
66 66
     {
67
-        if (   $deliverable->invoiceByActualUnits
67
+        if ($deliverable->invoiceByActualUnits
68 68
             && $at_entry->arguments['cycle'] > 1) {
69 69
             $invoice_sum = $deliverable->invoiced / ($at_entry->arguments['cycle'] - 1);
70 70
             if ($invoice_sum == 0) {
@@ -80,8 +80,8 @@  discard block
 block discarded – undo
80 80
         $time = $at_entry->start;
81 81
         $scheduler = new org_openpsa_invoices_scheduler($deliverable);
82 82
 
83
-        while (   $time < $this->_request_data['end']
84
-               && (   $time < $deliverable->end
83
+        while ($time < $this->_request_data['end']
84
+               && ($time < $deliverable->end
85 85
                    || $deliverable->continuous)) {
86 86
             $invoices[] = $this->get_invoice_for_deliverable($deliverable, $invoice_sum, $time, $calculation_base);
87 87
 
@@ -123,8 +123,8 @@  discard block
 block discarded – undo
123 123
         foreach ($qb->execute() as $at_entry) {
124 124
             try {
125 125
                 $deliverable = org_openpsa_sales_salesproject_deliverable_dba::get_cached($at_entry->arguments['deliverable']);
126
-                if (   $deliverable->continuous
127
-                    || (   $deliverable->start < $this->_request_data['end']
126
+                if ($deliverable->continuous
127
+                    || ($deliverable->start < $this->_request_data['end']
128 128
                         && $deliverable->end > $this->_request_data['start'])) {
129 129
                     $invoices = array_merge($invoices, $this->_get_invoices_for_subscription($deliverable, $at_entry));
130 130
                 }
Please login to merge, or discard this patch.
lib/org/openpsa/reports/handler/projects/report.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
         $qb_hr = org_openpsa_expenses_hour_report_dba::new_query_builder();
44 44
         $qb_hr->add_constraint('date', '<=', (int) $this->_request_data['query_data']['end']);
45 45
         $qb_hr->add_constraint('date', '>=', (int) $this->_request_data['query_data']['start']);
46
-        if (   array_key_exists('invoiceable_filter', $this->_request_data['query_data'])
46
+        if (array_key_exists('invoiceable_filter', $this->_request_data['query_data'])
47 47
             && $this->_request_data['query_data']['invoiceable_filter'] != -1) {
48 48
             $qb_hr->add_constraint('invoiceable', '=', (bool) $this->_request_data['query_data']['invoiceable_filter']);
49 49
         }
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
             $tasks = $this->_expand_task($this->_request_data['query_data']['task']);
59 59
             $qb_hr->add_constraint('task', 'IN', $tasks);
60 60
         }
61
-        if (   array_key_exists('hour_type_filter', $this->_request_data['query_data'])
61
+        if (array_key_exists('hour_type_filter', $this->_request_data['query_data'])
62 62
             && $this->_request_data['query_data']['hour_type_filter'] != 'builtin:all') {
63 63
             $qb_hr->add_constraint('reportType', '=', $this->_request_data['query_data']['hour_type_filter']);
64 64
         }
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 
147 147
     private function add_to_group(array $new_row, string $matching, string $sort, string $title)
148 148
     {
149
-        $rows =& $this->_request_data['report']['rows'];
149
+        $rows = & $this->_request_data['report']['rows'];
150 150
         if (array_key_exists($matching, $rows)) {
151 151
             $rows[$matching]['rows'][] = $new_row;
152 152
             $rows[$matching]['total_hours'] += $new_row['hour']->hours;
Please login to merge, or discard this patch.
lib/org/openpsa/qbpager/main.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -61,13 +61,13 @@  discard block
 block discarded – undo
61 61
         $results_var = $this->_prefix . 'results';
62 62
         if (!empty($_REQUEST[$page_var])) {
63 63
             debug_add("{$page_var} has value: {$_REQUEST[$page_var]}");
64
-            $this->_current_page = (int)$_REQUEST[$page_var];
64
+            $this->_current_page = (int) $_REQUEST[$page_var];
65 65
         }
66 66
         if (!empty($_REQUEST[$results_var])) {
67 67
             debug_add("{$results_var} has value: {$_REQUEST[$results_var]}");
68
-            $this->results_per_page = (int)$_REQUEST[$results_var];
68
+            $this->results_per_page = (int) $_REQUEST[$results_var];
69 69
         }
70
-        $this->_offset = ($this->_current_page-1)*$this->results_per_page;
70
+        $this->_offset = ($this->_current_page - 1) * $this->results_per_page;
71 71
         if ($this->_offset < 0) {
72 72
             $this->_offset = 0;
73 73
         }
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
     public function count() : int
300 300
     {
301 301
         $this->_sanity_check();
302
-        if (   !$this->count
302
+        if (!$this->count
303 303
             || $this->_count_mode != 'count') {
304 304
             $this->count = $this->_midcom_qb_count->count();
305 305
         }
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
310 310
     public function count_unchecked() : int
311 311
     {
312 312
         $this->_sanity_check();
313
-        if (   !$this->count
313
+        if (!$this->count
314 314
             || $this->_count_mode != 'count_unchecked') {
315 315
             $this->count = $this->_midcom_qb_count->count_unchecked();
316 316
         }
Please login to merge, or discard this patch.