Passed
Push — master ( 33989f...4d3c0d )
by Andreas
23:55
created
lib/midcom/services/uimessages.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -162,7 +162,7 @@
 block discarded – undo
162 162
         if (!$this->_message_stack) {
163 163
             return;
164 164
         }
165
-        if (   $show_simple
165
+        if ($show_simple
166 166
             || !midcom::get()->auth->can_user_do('midcom:ajax', null, static::class)) {
167 167
             $this->show_simple();
168 168
             return;
Please login to merge, or discard this patch.
lib/midcom/admin/help/style/midcom_admin_help_mgdschemas.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
 
16 16
         foreach ($properties as $propname => $val) {
17 17
             $description = preg_replace('/ *\n */', "\n", $val['value']);
18
-            if (   $val['link']
18
+            if ($val['link']
19 19
                 && $linked_component = midcom::get()->dbclassloader->get_component_for_class($val['link_name'])) {
20 20
                 $proplink = $data['router']->generate('help', ['component' => $linked_component, 'help_id' => 'mgdschemas']);
21 21
                 $proplink = "<a href='{$proplink}#{$val['link_name']}' title='{$linked_component}/{$val['link_name']}::{$val['link_target']}'>{$val['link_name']}:{$val['link_target']}</a>";
Please login to merge, or discard this patch.
lib/org/openpsa/projects/task.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -110,7 +110,7 @@
 block discarded – undo
110 110
     public function _on_updated()
111 111
     {
112 112
         // Sync the object's ACL properties into MidCOM ACL system
113
-        if (   !$this->_skip_acl_refresh) {
113
+        if (!$this->_skip_acl_refresh) {
114 114
             if ($this->orgOpenpsaAccesstype && $this->orgOpenpsaOwnerWg) {
115 115
                 debug_add("Synchronizing task ACLs to MidCOM");
116 116
                 $sync = new org_openpsa_core_acl_synchronizer();
Please login to merge, or discard this patch.
lib/org/openpsa/sales/handler/view.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
         }
92 92
 
93 93
         if ($this->_config->get('sales_pdfbuilder_class')) {
94
-            if (   $this->_salesproject->can_do('midgard:update')
94
+            if ($this->_salesproject->can_do('midgard:update')
95 95
                 && $this->is_pdf_creatable()) {
96 96
                 $workflow = $this->get_workflow('datamanager');
97 97
                 $buttons[] = $workflow->get_button($this->router->generate('create_offer', ['guid' => $this->_salesproject->guid]), [
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
             case 'ordered':
219 219
                 if ($deliverable->orgOpenpsaObtype == org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION) {
220 220
                     $entries = $deliverable->get_at_entries();
221
-                    if (   $entries
221
+                    if ($entries
222 222
                         && $entries[0]->status == midcom_services_at_entry_dba::SCHEDULED
223 223
                         && midcom::get()->auth->can_user_do('midgard:create', null, org_openpsa_invoices_invoice_dba::class)) {
224 224
                         return '<button class="run_cycle"><i class="fa fa-refresh"></i>' . $this->_l10n->get('generate now') . '</button>';
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
                 }
229 229
                 break;
230 230
             case 'delivered':
231
-                if (   $deliverable->orgOpenpsaObtype != org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
231
+                if ($deliverable->orgOpenpsaObtype != org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
232 232
                     && midcom::get()->auth->can_user_do('midgard:create', null, org_openpsa_invoices_invoice_dba::class)) {
233 233
                     $client_class = $this->_config->get('calculator');
234 234
                     $client = new $client_class();
Please login to merge, or discard this patch.
lib/org/openpsa/sales/style/show-deliverable-subscription.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
 $state = $data['deliverable']->get_state();
4 4
 $formatter = $data['l10n']->get_formatter();
5 5
 $per_unit = $data['l10n']->get('per unit');
6
-if (   $data['product']
6
+if ($data['product']
7 7
     && $unit_option = org_openpsa_sales_viewer::get_unit_option($data['product']->unit)) {
8 8
     $per_unit = sprintf($data['l10n']->get('per %s'), $unit_option);
9 9
 }
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
         </div>
125 125
         <?php
126 126
         $tabs = [];
127
-        if (   $data['invoices_url']
127
+        if ($data['invoices_url']
128 128
             && $data['deliverable']->invoiced > 0) {
129 129
             $tabs[] = [
130 130
                 'url' => $data['invoices_url'] . "list/deliverable/{$data['deliverable']->guid}/",
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
             ];
133 133
         }
134 134
 
135
-        if (   $data['projects_url']
135
+        if ($data['projects_url']
136 136
             && $data['deliverable']->state >= org_openpsa_sales_salesproject_deliverable_dba::STATE_ORDERED
137 137
             && $data['product']
138 138
             && $data['product']->orgOpenpsaObtype == org_openpsa_products_product_dba::TYPE_SERVICE) {
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
             }
192 192
             echo "    </tbody>\n";
193 193
             echo "</table>\n";
194
-            if (   $at_entries[0]->status == midcom_services_at_entry_dba::SCHEDULED
194
+            if ($at_entries[0]->status == midcom_services_at_entry_dba::SCHEDULED
195 195
                 && midcom::get()->auth->can_user_do('midgard:create', null, org_openpsa_invoices_invoice_dba::class)) {
196 196
                 $label = $data['l10n']->get('generate now');
197 197
                 $process_link = $data['router']->generate('deliverable_run_cycle', ['guid' => $data['deliverable']->guid]);
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/type/tinymceType.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -26,11 +26,11 @@
 block discarded – undo
26 26
      */
27 27
     public function configureOptions(OptionsResolver $resolver)
28 28
     {
29
-        $resolver->setDefault('config', function (Options $options) {
29
+        $resolver->setDefault('config', function(Options $options) {
30 30
             return \midcom_baseclasses_components_configuration::get('midcom.datamanager', 'config');
31 31
         });
32 32
 
33
-        $resolver->setNormalizer('widget_config', function (Options $options, $value) {
33
+        $resolver->setNormalizer('widget_config', function(Options $options, $value) {
34 34
             $widget_defaults = [
35 35
                 'mode' => 'exact',
36 36
                 'theme' => $options['config']->get('tinymce_default_theme'),
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/type/autocompleteType.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
     public function configureOptions(OptionsResolver $resolver)
35 35
     {
36 36
         $resolver->setDefault('error_bubbling', false);
37
-        $resolver->setNormalizer('widget_config', function (Options $options, $value) {
37
+        $resolver->setNormalizer('widget_config', function(Options $options, $value) {
38 38
             $widget_defaults = [
39 39
                 'creation_mode_enabled' => false,
40 40
                 'class' => null,
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 
67 67
             return helper::normalize($widget_defaults, $value);
68 68
         });
69
-        $resolver->setNormalizer('type_config', function (Options $options, $value) {
69
+        $resolver->setNormalizer('type_config', function(Options $options, $value) {
70 70
             $type_defaults = [
71 71
                 'options' => [],
72 72
                 'method' => 'GET',
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/type/subformType.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
                 'max_count' => 0
42 42
             ]
43 43
         ]);
44
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
44
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
45 45
             $validation = [];
46 46
             if ($options['type_config']['max_count'] > 0) {
47 47
                 $validation['max'] = $options['type_config']['max_count'];
@@ -54,13 +54,13 @@  discard block
 block discarded – undo
54 54
             }
55 55
             return $validation;
56 56
         });
57
-        $resolver->setNormalizer('entry_options', function (Options $options, $value) {
57
+        $resolver->setNormalizer('entry_options', function(Options $options, $value) {
58 58
             return array_replace([
59 59
                 'required' => false, //@todo no idea why this is necessary
60 60
                 'widget_config' => $options['widget_config']
61 61
             ], (array) $value);
62 62
         });
63
-        $resolver->setNormalizer('widget_config', function (Options $options, $value) {
63
+        $resolver->setNormalizer('widget_config', function(Options $options, $value) {
64 64
             if (!array_key_exists('sortable', $value)) {
65 65
                 $value['sortable'] = false;
66 66
             }
Please login to merge, or discard this patch.
lib/org/openpsa/user/validator.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         $result = $this->is_username_available($fields);
48 48
 
49 49
         $accounthelper = new org_openpsa_user_accounthelper();
50
-        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])){
50
+        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])) {
51 51
             $result = ['password' => midcom::get()->i18n->get_string('password weak', 'org.openpsa.user')];
52 52
         }
53 53
 
@@ -155,10 +155,10 @@  discard block
 block discarded – undo
155 155
         $user = new midcom_db_person($fields["person"]);
156 156
 
157 157
         $accounthelper = new org_openpsa_user_accounthelper($user);
158
-        if (!$accounthelper->check_password_reuse($fields['new_password'])){
158
+        if (!$accounthelper->check_password_reuse($fields['new_password'])) {
159 159
             $result['password'] = midcom::get()->i18n->get_string('password was already used', 'org.openpsa.user');
160 160
         }
161
-        if (!$accounthelper->check_password_strength($fields['new_password'])){
161
+        if (!$accounthelper->check_password_strength($fields['new_password'])) {
162 162
             $result['password'] = midcom::get()->i18n->get_string('password weak', 'org.openpsa.user');
163 163
         }
164 164
         if (!empty($result)) {
Please login to merge, or discard this patch.