Passed
Push — master ( 33989f...4d3c0d )
by Andreas
23:55
created
src/midcom/datamanager/controller.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -70,13 +70,13 @@  discard block
 block discarded – undo
70 70
             }
71 71
         } elseif (!$this->form->isSubmitted()) {
72 72
             $this->form->handleRequest($request);
73
-            if (   $this->form->isSubmitted()
73
+            if ($this->form->isSubmitted()
74 74
                 && $button = $this->form->getClickedButton()) {
75 75
                 $operation = $button->getConfig()->getOption('operation');
76 76
             }
77 77
         }
78 78
 
79
-        if (   in_array($operation, [self::SAVE, self::NEXT])
79
+        if (in_array($operation, [self::SAVE, self::NEXT])
80 80
             && !$this->form->isValid()) {
81 81
             $operation = self::EDIT;
82 82
         }
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
                 if ($storage->get_last_operation() === self::SAVE) {
160 160
                     // Get GUIDs and such for new-created dependent objects
161 161
                     $this->dm->set_storage($storage->get_value(), $this->dm->get_schema()->get_name());
162
-                } elseif (   !$this->form->isValid()
162
+                } elseif (!$this->form->isValid()
163 163
                           && $storage->move_uploaded_files() > 0) {
164 164
                     $form = $this->dm->get_form($this->form->getName(), true);
165 165
                     $this->copy_errors($this->form, $form);
Please login to merge, or discard this patch.
lib/org/openpsa/directmarketing/importer.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
                 }
122 122
             }
123 123
 
124
-            if (   !$person
124
+            if (!$person
125 125
                 && !empty($subscriber['person']['handphone'])) {
126 126
                 // Perform a simple cell phone test. More complicated duplicate checking is best left to the o.o.contacts duplicate checker
127 127
                 $qb = org_openpsa_contacts_person_dba::new_query_builder();
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
             // User is or has been subscriber earlier, update status
168 168
             $member = $members[0];
169 169
 
170
-            if (   $member->orgOpenpsaObtype == org_openpsa_directmarketing_campaign_member_dba::UNSUBSCRIBED
170
+            if ($member->orgOpenpsaObtype == org_openpsa_directmarketing_campaign_member_dba::UNSUBSCRIBED
171 171
                 || $member->orgOpenpsaObtype == org_openpsa_directmarketing_campaign_member_dba::NORMAL) {
172 172
                 $this->_import_status['already_subscribed']++;
173 173
                 return;
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
 
208 208
             $qb = org_openpsa_contacts_group_dba::new_query_builder();
209 209
             $schema = $this->_schemadbs['organization']->get('default');
210
-            if (   $schema->has_field('company_id')
210
+            if ($schema->has_field('company_id')
211 211
                 && !empty($subscriber['organization']['company_id'])) {
212 212
                 // Imported data has a company id, we use that instead of name
213 213
                 $qb->add_constraint($schema->get_field('company_id')['storage']['location'], '=', $subscriber['organization']['company_id']);
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
                 // Seek by official name
216 216
                 $qb->add_constraint('official', '=', $subscriber['organization']['official']);
217 217
 
218
-                if (   $schema->has_field('city')
218
+                if ($schema->has_field('city')
219 219
                     && !empty($subscriber['organization']['city'])) {
220 220
                     // Imported data has a city, we use also that for matching
221 221
                     $qb->add_constraint($schema->get_field('city')['storage']['location'], '=', $subscriber['organization']['city']);
Please login to merge, or discard this patch.
lib/net/nehmer/blog/style/feeds-item.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 $item->title = $data['article']->title;
19 19
 $arg = $data['article']->name ?: $data['article']->guid;
20 20
 
21
-if (   $data['config']->get('link_to_external_url')
21
+if ($data['config']->get('link_to_external_url')
22 22
     && !empty($data['article']->url)) {
23 23
     $item->link = $data['article']->url;
24 24
 } else {
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
     $item->description .= '<div class="abstract">' . $view['abstract'] . '</div>';
38 38
 }
39 39
 
40
-if (   array_key_exists('image', $view)
40
+if (array_key_exists('image', $view)
41 41
     && $data['config']->get('rss_use_image')) {
42 42
     $item->description .= "\n<div class=\"image\">" . $view['image'] . '</div>';
43 43
 }
Please login to merge, or discard this patch.
lib/org/openpsa/projects/style/show-frontpage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('ongoing') . "\">{$task_count['ongoing']}</span></td>\n";
69 69
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('on_hold') . "\">{$task_count['on_hold']}</span></td>\n";
70 70
             echo "        <td class=\"numeric\"><span title=\"" . $data['l10n']->get('closed') . "\">{$task_count['closed']}</span></td>\n";
71
-            echo "        <td class=\"numeric\"> " ;
71
+            echo "        <td class=\"numeric\"> ";
72 72
             echo "            <span title=\"" . $data['l10n']->get('reported') . "\">" . round($hours['reportedHours'], 2) . "</span>";
73 73
             if ($hours['plannedHours'] > 0) {
74 74
                 echo          " / <span title=\"" . $data['l10n']->get('planned hours') . "\">" . round($hours['plannedHours'], 2) . "</span>";
Please login to merge, or discard this patch.
lib/org/openpsa/documents/handler/document/admin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@
 block discarded – undo
101 101
 
102 102
         $this->_controller = $this->load_controller();
103 103
 
104
-        if (   $data['enable_versioning']
104
+        if ($data['enable_versioning']
105 105
             && $request->request->count() > 0) {
106 106
             $this->_backup_attachment();
107 107
         }
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/type.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@
 block discarded – undo
104 104
         }
105 105
 
106 106
         $help = new midcom_admin_help_help();
107
-        $this->_request_data['help'] = $help->get_help_contents('asgard_'.$this->type, $help_component);
107
+        $this->_request_data['help'] = $help->get_help_contents('asgard_' . $this->type, $help_component);
108 108
         $this->_request_data['component'] = $component;
109 109
     }
110 110
 
Please login to merge, or discard this patch.
lib/org/openpsa/relatedto/suspect.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -68,14 +68,14 @@  discard block
 block discarded – undo
68 68
     {
69 69
         $properties = ['fromClass', 'toClass', 'fromGuid', 'toGuid', 'fromComponent', 'toComponent', 'status', 'toExtra', 'toExtra'];
70 70
         foreach ($properties as $property) {
71
-            if (   !empty($defaults->$property)
71
+            if (!empty($defaults->$property)
72 72
                 && empty($link->$property)) {
73 73
                 debug_add("Copying property '{$property}' ('{$defaults->$property}') from defaults");
74 74
                 $link->$property = $defaults->$property;
75 75
             }
76 76
         }
77 77
 
78
-        if (   empty($link->toComponent)
78
+        if (empty($link->toComponent)
79 79
             && !empty($link->fromComponent)) {
80 80
             debug_add("Setting property 'toComponent' to '{$component}'");
81 81
             $link->toComponent = $component;
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
             $link->fromComponent = $component;
85 85
         }
86 86
 
87
-        if (   empty($link->toGuid)
87
+        if (empty($link->toGuid)
88 88
             && !empty($link->fromGuid)) {
89 89
             $link->toClass = get_class($obj);
90 90
             $link->toGuid = $obj->guid;
Please login to merge, or discard this patch.
lib/org/openpsa/projects/midcom/interfaces.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
      */
54 54
     private function _find_suspects_event(midcom_core_dbaobject $object, org_openpsa_relatedto_dba $defaults, array &$links_array)
55 55
     {
56
-        if (   !is_array($object->participants)
56
+        if (!is_array($object->participants)
57 57
             || count($object->participants) < 1) {
58 58
             //We have invalid list or zero participants, abort
59 59
             return;
Please login to merge, or discard this patch.
lib/midcom/admin/folder/management.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
             }
51 51
 
52 52
             // Skip components beginning with midcom or midgard
53
-            if (   preg_match('/^(midcom|midgard)\./', $manifest->name)
53
+            if (preg_match('/^(midcom|midgard)\./', $manifest->name)
54 54
                 && $manifest->name != 'midcom.helper.search') {
55 55
                 continue;
56 56
             }
Please login to merge, or discard this patch.