flack / openpsa

lib/net/nemein/rss/parser/item.php

Spacing +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
     public function get_link($key = 0, $rel = 'alternate')
     {
         $link = parent::get_link($key, $rel);
-        if (   $rel !== 'alternate'
+        if ($rel !== 'alternate'
             || $key !== 0) {
             return $link;
         }

lib/net/nehmer/comments/comment.php

Braces +2 added lines, -1 removed lines

@@ -408,7 +408,8 @@
         //Get the parent object
         try {
             $parent = midcom::get()->dbfactory->get_object_by_guid($this->objectguid);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return false;
         }

Spacing +7 added lines, -7 removed lines

@@ -185,7 +185,7 @@ 
         }
 
         // Set the status
-        if (   $this->can_do('net.nehmer.comments:moderation')
+        if ($this->can_do('net.nehmer.comments:moderation')
             && !$this->_sudo_requested) {
             $this->status = self::ABUSE;
         } else {
@@ -209,7 +209,7 @@ 
             return false;
         }
         // Set the status
-        if (   !$this->can_do('net.nehmer.comments:moderation')
+        if (!$this->can_do('net.nehmer.comments:moderation')
             || $this->_sudo_requested) {
             return false;
         }
@@ -233,7 +233,7 @@ 
         }
 
         // Set the status
-        if (   !$this->can_do('net.nehmer.comments:moderation')
+        if (!$this->can_do('net.nehmer.comments:moderation')
             || $this->_sudo_requested) {
             return false;
         }
@@ -252,7 +252,7 @@ 
      */
     public function report_not_abuse()
     {
-        if (   !$this->can_do('net.nehmer.comments:moderation')
+        if (!$this->can_do('net.nehmer.comments:moderation')
             || $this->_sudo_requested) {
             return false;
         }
@@ -351,8 +351,8 @@ 
     {
         $config = midcom_baseclasses_components_configuration::get('net.nehmer.comments', 'config');
 
-        if (   $config->get('ratings_enable')
-            && (    $config->get('ratings_cache_to_object')
+        if ($config->get('ratings_enable')
+            && ($config->get('ratings_cache_to_object')
                  || $config->get('comment_count_cache_to_object'))) {
             // Handle ratings
             $comments = self::list_by_objectguid($this->objectguid);
@@ -409,7 +409,7 @@ 
             return false;
         }
 
-        if (   empty($this->title)
+        if (empty($this->title)
             && empty($this->content)) {
             // No need to send notifications about empty rating entries
             return false;

lib/midcom/helper/metadata.php

Braces +2 added lines, -1 removed lines

@@ -658,7 +658,8 @@
             && mgd_is_guid($guid)) {
             try {
                 $object = midcom::get()->dbfactory->get_object_by_guid($guid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 debug_add("Failed to create a metadata instance for the GUID {$guid}: " . $e->getMessage(), MIDCOM_LOG_WARN);
                 debug_print_r("Source was:", $source);
 

Spacing +10 added lines, -10 removed lines

@@ -320,7 +320,7 @@ 
     {
         if (in_array($key, $this->field_config['timebased'])) {
             // This is ugly, but seems the only possible way...
-            if (   isset($this->__metadata->$key)
+            if (isset($this->__metadata->$key)
                 && (string) $this->__metadata->$key !== "0001-01-01T00:00:00+00:00") {
                 return (int) $this->__metadata->$key->format('U');
             }
@@ -385,11 +385,11 @@ 
         }
 
         $now = time();
-        if (   $this->get('schedulestart')
+        if ($this->get('schedulestart')
             && $this->get('schedulestart') > $now) {
             return false;
         }
-        if (   $this->get('scheduleend')
+        if ($this->get('scheduleend')
             && $this->get('scheduleend') < $now) {
             return false;
         }
@@ -407,9 +407,9 @@ 
     public function is_object_visible_onsite()
     {
         return
-        (   (   midcom::get()->config->get('show_hidden_objects')
+        ((midcom::get()->config->get('show_hidden_objects')
              || $this->is_visible())
-         && (   midcom::get()->config->get('show_unapproved_objects')
+         && (midcom::get()->config->get('show_unapproved_objects')
              || $this->is_approved())
         );
     }
@@ -497,7 +497,7 @@ 
             $guid = $source;
         }
 
-        if (   $object === null
+        if ($object === null
             && mgd_is_guid($guid)) {
             try {
                 $object = midcom::get()->dbfactory->get_object_by_guid($guid);
@@ -532,7 +532,7 @@ 
         }
 
         // Lock was created by the user, return "not locked"
-        if (   !empty(midcom::get()->auth->user->guid)
+        if (!empty(midcom::get()->auth->user->guid)
             && $this->get('locker') === midcom::get()->auth->user->guid) {
             return false;
         }
@@ -550,7 +550,7 @@ 
     {
         midcom::get()->auth->require_do('midgard:update', $this->__object);
 
-        if (   is_object($this->__object)
+        if (is_object($this->__object)
             && $this->__object->lock()) {
             $this->_cache = [];
             return true;
@@ -567,7 +567,7 @@ 
      */
     public function can_unlock()
     {
-        return (   $this->__object->can_do('midcom:unlock')
+        return ($this->__object->can_do('midcom:unlock')
                 || midcom::get()->auth->can_user_do('midcom:unlock', null, midcom_services_auth::class));
     }
 
@@ -578,7 +578,7 @@ 
      */
     public function unlock()
     {
-        if (   $this->can_unlock()
+        if ($this->can_unlock()
             && is_object($this->__object)
             && $this->__object->unlock()) {
             $this->_cache = [];

lib/midcom/admin/folder/handler/order.php

Braces +2 added lines, -1 removed lines

@@ -69,7 +69,8 @@
         // Use the DB Factory to resolve the class and to get the object
         try {
             $object = midcom::get()->dbfactory->get_object_by_guid($identifier);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             // This is probably a pseudo leaf, store the score to the current node
             $this->_topic->set_parameter('midcom.helper.nav.score', $identifier, $score);
             return true;

Spacing +1 added lines, -1 removed lines

@@ -89,7 +89,7 @@
         }
 
         // Approve if possible
-        if (   $approval_status
+        if ($approval_status
             && $object->can_do('midcom:approve')) {
             $object->metadata->approve();
         }

lib/midcom/db/topic.php

Spacing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
     public function _on_loaded()
     {
         // if we are missing the component, use the nullcomponent.
-        if (   !$this->component
+        if (!$this->component
             || !array_key_exists($this->component, midcom::get()->componentloader->manifests)) {
             debug_add("Topic {$this->id} has no component assigned to it, using 'midcom.core.nullcomponent'.",
             MIDCOM_LOG_INFO);

lib/midcom/services/cache/module/nap.php

Braces +2 added lines, -1 removed lines

@@ -132,7 +132,8 @@
                       && $nodeobject = $nav->get_node($node->id)) {
                 $napobject = $nav->get_leaf($nodeobject[MIDCOM_NAV_ID] . '-' . $object->id);
             }
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
         return $napobject;

Spacing +7 added lines, -7 removed lines

@@ -77,7 +77,7 @@ 
             // Get parent from DB and compare to catch moves
             if ($parent = $napobject[MIDCOM_NAV_OBJECT]->get_parent()) {
                 $parent_entry_from_object = $this->get_guid($parent->guid);
-                if (    $parent_entry_from_object
+                if ($parent_entry_from_object
                      && $parent_entry_from_object[MIDCOM_NAV_ID] != $cached_node_id) {
                     $this->_cache->delete($this->_prefix . '-' . $parent_entry_from_object[MIDCOM_NAV_ID] . '-leaves');
                 }
@@ -92,7 +92,7 @@ 
             $parent_id = $napobject[MIDCOM_NAV_NODEID];
             $parent_entry = $this->get_node($parent_id);
 
-            if (   $parent_entry
+            if ($parent_entry
                 && array_key_exists(MIDCOM_NAV_SUBNODES, $parent_entry)) {
                 unset($parent_entry[MIDCOM_NAV_SUBNODES]);
                 $this->put_node($parent_id, $parent_entry);
@@ -102,7 +102,7 @@ 
             if ($parent = $napobject[MIDCOM_NAV_OBJECT]->get_parent()) {
                 $parent_entry_from_object = $this->get_guid($parent->guid);
 
-                if (    !empty($parent_entry_from_object[MIDCOM_NAV_ID])
+                if (!empty($parent_entry_from_object[MIDCOM_NAV_ID])
                      && !empty($parent_entry[MIDCOM_NAV_ID])
                      && $parent_entry_from_object[MIDCOM_NAV_ID] != $parent_entry[MIDCOM_NAV_ID]) {
                     unset($parent_entry_from_object[MIDCOM_NAV_SUBNODES]);
@@ -128,7 +128,7 @@ 
             $nav = new midcom_helper_nav;
             if ($object instanceof midcom_db_topic) {
                 $napobject = $nav->get_node($object->id);
-            } elseif (   ($node = $nav->find_closest_topic($object))
+            } elseif (($node = $nav->find_closest_topic($object))
                       && $nodeobject = $nav->get_node($node->id)) {
                 $napobject = $nav->get_leaf($nodeobject[MIDCOM_NAV_ID] . '-' . $object->id);
             }
@@ -153,7 +153,7 @@ 
         }
         $lang_id = midcom::get()->i18n->get_current_language();
         $result = $this->_cache->fetch("{$this->_prefix}-{$key}");
-        if (   !is_array($result)
+        if (!is_array($result)
             || !isset($result[$lang_id])) {
             return false;
         }
@@ -177,7 +177,7 @@ 
 
         $lang_id = midcom::get()->i18n->get_current_language();
         $result = $this->_cache->fetch("{$this->_prefix}-{$key}");
-        if (   !is_array($result)
+        if (!is_array($result)
             || !isset($result[$lang_id])) {
             return false;
         }
@@ -244,7 +244,7 @@ 
 
         $lang_id = midcom::get()->i18n->get_current_language();
         $result = $this->_cache->fetch("{$this->_prefix}-{$guid}");
-        if (   !is_array($result)
+        if (!is_array($result)
             || !isset($result[$lang_id])) {
             return false;
         }

lib/midcom/services/permalinks/main.php

Braces +2 added lines, -1 removed lines

@@ -72,7 +72,8 @@
 
         try {
             $object = midcom::get()->dbfactory->get_object_by_guid($guid);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             debug_add("Failed to resolve the GUID {$guid}, this is most probably an access denied error.", MIDCOM_LOG_ERROR);
             debug_add('Last MidCOM error string: ' . $e->getMessage());
             return null;

Spacing +1 added lines, -1 removed lines

@@ -93,7 +93,7 @@
         if ($object instanceof midcom_db_attachment) {
             // Faster linking to attachments
             $parent = $object->get_parent();
-            if (   is_a($parent, midcom_db_topic::class)
+            if (is_a($parent, midcom_db_topic::class)
                 && $nav->is_node_in_tree($parent->id, $nav->get_root_node())) {
                 $napobj = $nav->get_node($parent->id);
                 return $napobj[MIDCOM_NAV_FULLURL] . $object->name;

lib/midcom/services/indexer/document/midcom.php

Spacing +1 added lines, -1 removed lines

@@ -109,7 +109,7 @@
      */
     public function members_to_fields()
     {
-        if (   empty($this->topic_guid)
+        if (empty($this->topic_guid)
             || empty($this->topic_url)
             || empty($this->component)) {
             //if one of those is missing, we override all three to ensure consistency

lib/midcom/config/test.php

Indentation +1 added lines, -1 removed lines

@@ -104,7 +104,7 @@
             $this->add('Setting: upload_max_filesize', self::OK, ini_get('upload_max_filesize'));
         } else {
             $this->add('Setting: upload_max_filesize',
-                             self::WARNING, "To make bulk uploads (for exampe in the Image Gallery) useful, you should increase the Upload limit to something above 50 MB. (Current setting: {$upload_limit})");
+                                self::WARNING, "To make bulk uploads (for exampe in the Image Gallery) useful, you should increase the Upload limit to something above 50 MB. (Current setting: {$upload_limit})");
         }
 
         $post_limit = $this->ini_get_filesize('post_max_size');

Braces +2 added lines, -1 removed lines

@@ -74,7 +74,8 @@
                 $config = new midcom_services_rcs_config($config);
                 $config->test_rcs_config();
                 $this->add("MidCOM RCS", self::OK);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $this->add("MidCOM RCS", self::ERROR, $e->getMessage());
             }
         } else {