midgard_admin_user_plugin::generate_password() - Code Metrics - Inspection of "Merge generate_password functions" - flack/openpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6a1094...c4becb )

by Andreas

created 2020-09-25 14:25 UTC

midgard_admin_user_plugin::generate_password() A

↳ Parent: midgard_admin_user_plugin

Complexity

Conditions	3
Paths	4

Size

Total Lines	20
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	3.0067

Importance

Changes

Metric	Value
cc	3
eloc	11
nc	4
nop	2
dl	0
loc	20
ccs	10
cts	11
cp	0.9091
crap	3.0067
rs	9.9
c	0
b	0
f	0

<?php
/**
 * @package midgard.admin.user
 * @author The Midgard Project, http://www.midgard-project.org
 * @copyright The Midgard Project, http://www.midgard-project.org
 * @license http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
 */

/**
 * user editor interface
 *
 * @package midgard.admin.user
 */
class midgard_admin_user_plugin extends midcom_baseclasses_components_plugin
{
    public function _on_initialize()
    {
        midcom::get()->auth->require_user_do('midgard.admin.user:access', null, 'midgard_admin_user_plugin');
        midgard_admin_asgard_plugin::prepare_plugin($this->_l10n->get('midgard.admin.user'), $this->_request_data);

        $this->add_stylesheet(MIDCOM_STATIC_URL . '/midgard.admin.user/usermgmt.css');
    }

    /**
     * Generate one password
     *
     * @param int $length
     */
    public static function generate_password(int $length = 8, bool $no_similars = true) : string
    {
        // Safety
        if ($length < 3) {
            $length = 8;
        }

        // Valid characters for default password (PONDER: make configurable ?)
        if ($no_similars) {
            $first_last_chars = 'abcdefghijkmnopqrstuvwxyzABCDEFGHJKLMNPQRSTUVWXYZ23456789';
        } else {
            $first_last_chars = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789';
        }
        $passwdchars = $first_last_chars . '.,-*!:+=()/&%$<>?#@';

        //make sure password doesn't begin or end in punctuation character
        $password = midcom_helper_misc::random_string(1, $first_last_chars);
        $password .= midcom_helper_misc::random_string($length - 2, $passwdchars);
        $password .= midcom_helper_misc::random_string(1, $first_last_chars);
        return $password;
    }
}


1		<?php
2		/**
3		* @package midgard.admin.user
4		* @author The Midgard Project, http://www.midgard-project.org
5		* @copyright The Midgard Project, http://www.midgard-project.org
6		* @license http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
7		*/
8
9		/**
10		* user editor interface
11		*
12		* @package midgard.admin.user
13		*/
14		class midgard_admin_user_plugin extends midcom_baseclasses_components_plugin
15		{
16	16	public function _on_initialize()
17		{
18	16	midcom::get()->auth->require_user_do('midgard.admin.user:access', null, 'midgard_admin_user_plugin');
19	16	midgard_admin_asgard_plugin::prepare_plugin($this->_l10n->get('midgard.admin.user'), $this->_request_data);
20
21	16	$this->add_stylesheet(MIDCOM_STATIC_URL . '/midgard.admin.user/usermgmt.css');
22	16	}
23
24		/**
25		* Generate one password
26		*
27		* @param int $length
28		*/
29	8	public static function generate_password(int $length = 8, bool $no_similars = true) : string
30		{
31		// Safety
32	8	if ($length < 3) {
33	6	$length = 8;
34		}
35
36		// Valid characters for default password (PONDER: make configurable ?)
37	8	if ($no_similars) {
38	8	$first_last_chars = 'abcdefghijkmnopqrstuvwxyzABCDEFGHJKLMNPQRSTUVWXYZ23456789';
39		} else {
40		$first_last_chars = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789';
41		}
42	8	$passwdchars = $first_last_chars . '.,-*!:+=()/&%$<>?#@';
43
44		//make sure password doesn't begin or end in punctuation character
45	8	$password = midcom_helper_misc::random_string(1, $first_last_chars);
46	8	$password .= midcom_helper_misc::random_string($length - 2, $passwdchars);
47	8	$password .= midcom_helper_misc::random_string(1, $first_last_chars);
48	8	return $password;
49		}
50		}
51

flack / openpsa

Push — master ( 6a1094...c4becb )

midgard_admin_user_plugin::generate_password() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like