flack / openpsa

src/midcom/dba/attachments.php

Spacing +3 added lines, -3 removed lines

@@ -51,7 +51,7 @@ 
             return false;
         }
 
-        if (   !$this->can_do('midgard:update')
+        if (!$this->can_do('midgard:update')
             || !$this->can_do('midgard:attachments')) {
             debug_add("Failed to set parameters, midgard:update or midgard:attachments on " . static::class . " {$this->guid} not granted for the current user.",
             MIDCOM_LOG_ERROR);
@@ -71,7 +71,7 @@ 
             return null;
         }
 
-        if (   !$this->can_do('midgard:update')
+        if (!$this->can_do('midgard:update')
             || !$this->can_do('midgard:attachments')) {
             debug_add("Failed to set parameters, midgard:update or midgard:attachments on the " . static::class . " {$this->guid} not granted for the current user.",
             MIDCOM_LOG_ERROR);
@@ -85,7 +85,7 @@ 
         $attachment->parentguid = $this->guid;
 
         if (!$attachment->create()) {
-            debug_add("Could not create the attachment '{$name}' for " . static::class . " {$this->guid}: "  . midcom_connection::get_error_string(),
+            debug_add("Could not create the attachment '{$name}' for " . static::class . " {$this->guid}: " . midcom_connection::get_error_string(),
             MIDCOM_LOG_INFO);
             return null;
         }

lib/midcom/services/i18n/l10n.php

Spacing +1 added lines, -1 removed lines

@@ -226,7 +226,7 @@
     private function error(string $message, string $filename, int $line) : midcom_error
     {
         $line++; // Array is 0-indexed
-        return new midcom_error('L10n DB SYNTAX ERROR: ' .  $message . ' at ' . $filename . ' ' . $line);
+        return new midcom_error('L10n DB SYNTAX ERROR: ' . $message . ' at ' . $filename . ' ' . $line);
     }
 
     /**

src/midcom/httpkernel/subscriber.php

Spacing +1 added lines, -1 removed lines

@@ -90,7 +90,7 @@
         $i = array_search('__request_data__', $arguments, true);
         if ($i !== false) {
             $context = $event->getRequest()->attributes->get('context');
-            $arguments[$i] =& $context->get_custom_key('request_data');
+            $arguments[$i] = & $context->get_custom_key('request_data');
             $event->setArguments($arguments);
         }
     }

lib/midcom/baseclasses/components/viewer.php

Spacing +1 added lines, -1 removed lines

@@ -246,7 +246,7 @@
      */
     public function prepare_handler(midcom_baseclasses_components_handler $handler, array &$parameters)
     {
-        $this->parameters =& $parameters;
+        $this->parameters = & $parameters;
 
         $parameters['handler'] = explode('::', $parameters['_controller'], 2);
 

lib/org/openpsa/projects/handler/task/resourcing.php

Spacing +2 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
             return new midcom_response_relocate($this->router->generate('task_view', ['guid' => $guid]));
         }
 
-        if (   $request->request->has('save')
+        if ($request->request->has('save')
             && $prospects = $request->request->all('org_openpsa_projects_prospects')) {
             $qb = org_openpsa_projects_task_resource_dba::new_query_builder();
             $qb->add_constraint('guid', 'IN', array_keys($prospects));
@@ -89,7 +89,7 @@ 
                     // create relatedto
                     org_openpsa_relatedto_plugin::create($event, 'org.openpsa.calendar', $this->_task, 'org.openpsa.projects');
                 }
-                if (   $update_prospect
+                if ($update_prospect
                     && !$prospect->update()) {
                     debug_add('Failed to update prospect: ' . midcom_connection::get_error_string(), MIDCOM_LOG_ERROR);
                 }

lib/org/openpsa/mail/backend.php

Braces +4 added lines, -2 removed lines

@@ -46,7 +46,8 @@ 
                     $object = self::_load_backend($backend, $params);
                     debug_add('Using backend ' . $backend);
                     return $object;
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     debug_add('Failed to load backend ' . $backend . ', message:' . $e->getMessage());
                 }
             }
@@ -76,7 +77,8 @@ 
             $this->mail($message);
             $this->error = null;
             return true;
-        } catch (Exception $e) {
+        }
+        catch (Exception $e) {
             $this->error = $e->getMessage();
             return false;
         }

lib/org/openpsa/documents/handler/document/admin.php

Spacing +1 added lines, -1 removed lines

@@ -90,7 +90,7 @@
 
         $this->_controller = $this->load_controller();
 
-        if (   $data['enable_versioning']
+        if ($data['enable_versioning']
             && $request->request->count() > 0) {
             $this->_backup_attachment($request);
         }

lib/org/openpsa/core/queryfilter.php

Spacing +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
         $user = midcom::get()->auth->user->get_storage();
 
         if ($request->request->get('unset_filter') == $filter_id) {
-            if (   $user->get_parameter("org_openpsa_core_filter", $filter_id)
+            if ($user->get_parameter("org_openpsa_core_filter", $filter_id)
                 && !$user->delete_parameter("org_openpsa_core_filter", $filter_id)) {
                 $message_content = sprintf(
                     $l10n->get('the handed filter for %s could not be set as parameter'),

lib/org/openpsa/reports/handler/invoices/report.php

Spacing +5 added lines, -5 removed lines

@@ -56,7 +56,7 @@ 
 
     private function _get_invoices_for_subscription(org_openpsa_sales_salesproject_deliverable_dba $deliverable, midcom_services_at_entry_dba $at_entry) : array
     {
-        if (   $deliverable->invoiceByActualUnits
+        if ($deliverable->invoiceByActualUnits
             && $at_entry->arguments['cycle'] > 1) {
             $months = midcom_baseclasses_components_configuration::get('org.openpsa.sales', 'config')->get('subscription_profit_months');
             $cutoff = (new DateTime)->modify('-' . $months . ' months');
@@ -81,8 +81,8 @@ 
         $time = $at_entry->start;
         $scheduler = new org_openpsa_invoices_scheduler($deliverable);
 
-        while (   $time < $this->_request_data['end']
-               && (   $time < $deliverable->end
+        while ($time < $this->_request_data['end']
+               && ($time < $deliverable->end
                    || $deliverable->continuous)) {
             $invoices[] = $this->get_invoice_for_deliverable($deliverable, $invoice_sum, $time, $calculation_base);
 
@@ -124,8 +124,8 @@ 
         foreach ($qb->execute() as $at_entry) {
             try {
                 $deliverable = org_openpsa_sales_salesproject_deliverable_dba::get_cached($at_entry->arguments['deliverable']);
-                if (   $deliverable->continuous
-                    || (   $deliverable->start < $this->_request_data['end']
+                if ($deliverable->continuous
+                    || ($deliverable->start < $this->_request_data['end']
                         && $deliverable->end > $this->_request_data['start'])) {
                     $invoices = array_merge($invoices, $this->_get_invoices_for_subscription($deliverable, $at_entry));
                 }

Braces +2 added lines, -1 removed lines

@@ -132,7 +132,8 @@
                         && $deliverable->end > $this->_request_data['start'])) {
                     $invoices = array_merge($invoices, $this->_get_invoices_for_subscription($deliverable, $at_entry));
                 }
-            } catch (midcom_error) {
+            }
+            catch (midcom_error) {
             }
         }
         $invoices = array_merge($invoices, $this->_get_deliverable_invoices());