Passed
Push — master ( 3657f2...b17fdb )
by Andreas
24:28 queued 05:07
created
lib/midgard/admin/asgard/schemadb.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 
65 65
     protected function add_string_field(string $key, string $type)
66 66
     {
67
-        if (   $key == 'component'
67
+        if ($key == 'component'
68 68
             && $type == midcom_db_topic::class) {
69 69
             $this->_add_component_dropdown($key);
70 70
             return;
@@ -134,12 +134,12 @@  discard block
 block discarded – undo
134 134
         parent::add_longtext_field($key);
135 135
 
136 136
         // Check the user preference and configuration
137
-        if (   in_array($key, ['content', 'description'])
137
+        if (in_array($key, ['content', 'description'])
138 138
             && midgard_admin_asgard_plugin::get_preference('tinymce_enabled')) {
139 139
             $this->schema['fields'][$key]['widget'] = 'tinymce';
140 140
         }
141 141
 
142
-        if (   in_array($key, ['value', 'code'])
142
+        if (in_array($key, ['value', 'code'])
143 143
             && midgard_admin_asgard_plugin::get_preference('codemirror_enabled')) {
144 144
             $this->schema['fields'][$key]['widget'] = 'codemirror';
145 145
         }
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
         if ($score1 > $score2) {
258 258
             return 1;
259 259
         }
260
-        if (   $score1 < 3
260
+        if ($score1 < 3
261 261
             || $score1 > 6) {
262 262
             return strnatcmp($first, $second);
263 263
         }
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/component/configuration.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
     {
278 278
         $success = true;
279 279
         foreach ($this->_request_data['config']->_global as $global_key => $global_value) {
280
-            if (   isset($config[$global_key])
280
+            if (isset($config[$global_key])
281 281
                 && $config[$global_key] != $global_value) {
282 282
                 continue;
283 283
                 // Skip the ones we will set next
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
         }
291 291
 
292 292
         foreach ($config as $key => $value) {
293
-            if (   is_array($value)
293
+            if (is_array($value)
294 294
                 || is_object($value)) {
295 295
                 /**
296 296
                  * See http://trac.midgard-project.org/ticket/1442
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/schemadb/config.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -61,11 +61,11 @@
 block discarded – undo
61 61
                 $fields[$key] = $this->detect_schema($key, $value);
62 62
             }
63 63
 
64
-            if (   !isset($this->config->_local[$key])
64
+            if (!isset($this->config->_local[$key])
65 65
                 || $this->config->_local[$key] == $this->config->_global[$key]) {
66 66
                 // No local configuration setting, note to user that this is the global value
67 67
                 $fields[$key]['title'] = $schema->get_l10n()->get($fields[$key]['title']);
68
-                $fields[$key]['title'] .= " <span class=\"global\">(" . midcom::get()->i18n->get_string('global value', 'midgard.admin.asgard') .")</span>";
68
+                $fields[$key]['title'] .= " <span class=\"global\">(" . midcom::get()->i18n->get_string('global value', 'midgard.admin.asgard') . ")</span>";
69 69
             }
70 70
         }
71 71
 
Please login to merge, or discard this patch.
lib/midcom/admin/help/help.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -179,9 +179,9 @@  discard block
 block discarded – undo
179 179
         $files = [];
180 180
         $pattern = $component_dir . '*.{' . $this->_i18n->get_current_language() . ',' . $this->_i18n->get_fallback_language() . '}.txt';
181 181
 
182
-        foreach (glob($pattern, GLOB_NOSORT|GLOB_BRACE) as $path) {
182
+        foreach (glob($pattern, GLOB_NOSORT | GLOB_BRACE) as $path) {
183 183
             $entry = basename($path);
184
-            if (   str_starts_with($entry, 'index')
184
+            if (str_starts_with($entry, 'index')
185 185
                 || str_starts_with($entry, 'handler')
186 186
                 || str_starts_with($entry, 'urlmethod')) {
187 187
                 // Ignore dotfiles, handlers & index.lang.txt
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
         $data = [];
233 233
 
234 234
         $exec_path = midcom::get()->componentloader->path_to_snippetpath($component) . '/exec/';
235
-        if (   !is_dir($exec_path)
235
+        if (!is_dir($exec_path)
236 236
             || !is_readable($exec_path)) {
237 237
             // Directory not accessible, skip loading it
238 238
             return $data;
Please login to merge, or discard this patch.
lib/midcom/helper/_dbfactory.php 2 patches
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,7 +43,8 @@  discard block
 block discarded – undo
43 43
     {
44 44
         try {
45 45
             $tmp = midgard_object_class::get_object_by_guid($guid);
46
-        } catch (mgd_exception $e) {
46
+        }
47
+        catch (mgd_exception $e) {
47 48
             debug_add('Loading object by GUID ' . $guid . ' failed, reason: ' . $e->getMessage(), MIDCOM_LOG_INFO);
48 49
 
49 50
             throw new midcom_error_midgard($e, $guid);
@@ -163,7 +164,8 @@  discard block
 block discarded – undo
163 164
 
164 165
         try {
165 166
             return $this->get_cached($classname, $parent_guid);
166
-        } catch (midcom_error $e) {
167
+        }
168
+        catch (midcom_error $e) {
167 169
             return null;
168 170
         }
169 171
     }
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
             throw new midcom_error_midgard($e, $guid);
50 50
         }
51 51
         $person_class = midcom::get()->config->get('person_class');
52
-        if (   get_class($tmp) == 'midgard_person'
52
+        if (get_class($tmp) == 'midgard_person'
53 53
             && $person_class != 'midgard_person') {
54 54
             $tmp = new $person_class($guid);
55 55
         }
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
         }
80 80
         $object = new $classname($src);
81 81
         $cache[$classname][$object->guid] = $object;
82
-        $cache[$classname][$object->id] =& $cache[$classname][$object->guid];
82
+        $cache[$classname][$object->id] = & $cache[$classname][$object->guid];
83 83
         return $cache[$classname][$object->guid];
84 84
     }
85 85
 
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
             return true;
128 128
         }
129 129
 
130
-        if (   isset($object->__object)
130
+        if (isset($object->__object)
131 131
             && is_object($object->__object)
132 132
             && $object->__object instanceof $class) {
133 133
             // Decorator whose MgdSchema object matches
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
             return $this->get_parent_data_uncached($object);
151 151
         });
152 152
 
153
-        if (   empty($parent_guid)
153
+        if (empty($parent_guid)
154 154
             || $parent_guid === $object->guid) {
155 155
             return null;
156 156
         }
Please login to merge, or discard this patch.
lib/org/openpsa/calendar/event.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
         }
142 142
 
143 143
         //Check up
144
-        if (   !$this->up
144
+        if (!$this->up
145 145
             && $this->title != '__org_openpsa_calendar') {
146 146
             $root_event = org_openpsa_calendar_interface::find_root_event();
147 147
             $this->up = $root_event->id;
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 
167 167
     private function _check_timerange() : bool
168 168
     {
169
-        if (   !$this->start
169
+        if (!$this->start
170 170
             || !$this->end) {
171 171
             debug_add('Event must have start and end timestamps');
172 172
             midcom_connection::set_error(MGD_ERR_RANGE);
Please login to merge, or discard this patch.
lib/net/nehmer/blog/style/index-item.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
 $published = sprintf($data['l10n']->get('posted on %s.'), "<abbr title=\"" . strftime('%Y-%m-%dT%H:%M:%S%z', $data['article']->metadata->published) . "\">" . $published . "</abbr>");
13 13
 
14 14
 if (array_key_exists('base_ajax_comments_url', $data)) {
15
-    $published .= ' <a href="#switch_comments" onClick="showAjaxComments(this, \''.$data['article']->guid.'\'); return false;">'
15
+    $published .= ' <a href="#switch_comments" onClick="showAjaxComments(this, \'' . $data['article']->guid . '\'); return false;">'
16 16
                     . sprintf($data['l10n']->get('%s comments'), net_nehmer_comments_comment::count_by_objectguid($data['article']->guid))
17 17
                     . "</a>.";
18 18
 } elseif ($data['config']->get('comments_enable')) {
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
         &(published:h);
29 29
             <?php
30 30
             if ($data['linked']) {
31
-                echo $data['l10n']->get('to') ." <a href=\"{$data['node'][MIDCOM_NAV_ABSOLUTEURL]}\">{$data['node'][MIDCOM_NAV_NAME]}</a>\n";
31
+                echo $data['l10n']->get('to') . " <a href=\"{$data['node'][MIDCOM_NAV_ABSOLUTEURL]}\">{$data['node'][MIDCOM_NAV_NAME]}</a>\n";
32 32
             }
33 33
             ?>
34 34
     </p>
Please login to merge, or discard this patch.
lib/midcom/helper/search/handler/search.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
      */
51 51
     private function search_nodes(array $node, midcom_helper_nav $nap, string $prefix)
52 52
     {
53
-        if (   !array_key_exists($node[MIDCOM_NAV_COMPONENT], $this->_request_data['components'])
53
+        if (!array_key_exists($node[MIDCOM_NAV_COMPONENT], $this->_request_data['components'])
54 54
             && $node[MIDCOM_NAV_COMPONENT] != 'midcom.helper.search') {
55 55
             $l10n = $this->_i18n->get_l10n($node[MIDCOM_NAV_COMPONENT]);
56 56
             $this->_request_data['components'][$node[MIDCOM_NAV_COMPONENT]] = $l10n->get($node[MIDCOM_NAV_COMPONENT]);
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
         }
99 99
         $this->prepare_formdata($_REQUEST['type']);
100 100
 
101
-        if (   count(explode(' ', $data['query'])) == 1
101
+        if (count(explode(' ', $data['query'])) == 1
102 102
             && !str_contains($data['query'], '*')
103 103
             && $this->_config->get('single_term_auto_wildcard')) {
104 104
             //If there is only one search term append * to the query if auto_wildcard is enabled
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 
167 167
             // Register GUIDs for cache engine
168 168
             foreach ($this->_request_data['result'] as $doc) {
169
-                if (   !isset($doc->source)
169
+                if (!isset($doc->source)
170 170
                     || !mgd_is_guid($doc->source)) {
171 171
                     // Non-Midgard results don't need to go through cache registration
172 172
                     continue;
Please login to merge, or discard this patch.
lib/net/nemein/wiki/handler/view.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -202,9 +202,9 @@
 block discarded – undo
202 202
         $toc .= "\n<ol class=\"midcom_helper_toc_formatter level_{$current_list_level}\">\n";
203 203
         foreach ($headings[4] as $key => $heading) {
204 204
             $anchor = 'heading-' . md5($heading);
205
-            $tag_level =& $headings[3][$key];
206
-            $heading_code =& $headings[0][$key];
207
-            $heading_tag =& $headings[2][$key];
205
+            $tag_level = & $headings[3][$key];
206
+            $heading_code = & $headings[0][$key];
207
+            $heading_tag = & $headings[2][$key];
208 208
             $heading_new_code = "<a id='{$anchor}'></a>{$heading_code}";
209 209
             $content = str_replace($heading_code, $heading_new_code, $content);
210 210
             if ($current_tag_level === false) {
Please login to merge, or discard this patch.