Passed
Push — master ( 3657f2...b17fdb )
by Andreas
24:28 queued 05:07
created
lib/org/openpsa/sales/handler/edit.php 2 patches
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -68,7 +68,8 @@  discard block
 block discarded – undo
68 68
                 $field['type_config']['options'] = [0 => '', $customer->id => $customer->official];
69 69
 
70 70
                 $defaults['customer'] = $customer->id;
71
-            } catch (midcom_error $e) {
71
+            }
72
+            catch (midcom_error $e) {
72 73
                 $customer = new org_openpsa_contacts_person_dba($guid);
73 74
                 $defaults['customerContact'] = $customer->id;
74 75
                 $field['type_config']['options'] = $this->list_groups(new org_openpsa_sales_salesproject_dba, [$customer->id => true]);
@@ -142,7 +143,8 @@  discard block
 block discarded – undo
142 143
             try {
143 144
                 $company = org_openpsa_contacts_group_dba::get_cached($company_id);
144 145
                 $ret[$company->id] = $company->get_label();
145
-            } catch (midcom_error $e) {
146
+            }
147
+            catch (midcom_error $e) {
146 148
                 $e->log();
147 149
             }
148 150
         }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
         $schemadb = schemadb::from_path($this->_config->get('schemadb_salesproject'));
62 62
 
63 63
         if (!empty($guid)) {
64
-            $field =& $schemadb->get('default')->get_field('customer');
64
+            $field = & $schemadb->get('default')->get_field('customer');
65 65
             try {
66 66
                 $customer = new org_openpsa_contacts_group_dba($guid);
67 67
                 $field['type_config']['options'] = [0 => '', $customer->id => $customer->official];
Please login to merge, or discard this patch.
lib/org/openpsa/user/validator.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         $result = $this->is_username_available($fields);
48 48
 
49 49
         $accounthelper = new org_openpsa_user_accounthelper();
50
-        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])){
50
+        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])) {
51 51
             $result = ['password' => midcom::get()->i18n->get_string('password weak', 'org.openpsa.user')];
52 52
         }
53 53
 
@@ -155,10 +155,10 @@  discard block
 block discarded – undo
155 155
         $user = new midcom_db_person($fields["person"]);
156 156
 
157 157
         $accounthelper = new org_openpsa_user_accounthelper($user);
158
-        if (!$accounthelper->check_password_reuse($fields['new_password'])){
158
+        if (!$accounthelper->check_password_reuse($fields['new_password'])) {
159 159
             $result['password'] = midcom::get()->i18n->get_string('password was already used', 'org.openpsa.user');
160 160
         }
161
-        if (!$accounthelper->check_password_strength($fields['new_password'])){
161
+        if (!$accounthelper->check_password_strength($fields['new_password'])) {
162 162
             $result['password'] = midcom::get()->i18n->get_string('password weak', 'org.openpsa.user');
163 163
         }
164 164
         if (!empty($result)) {
Please login to merge, or discard this patch.
Braces   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         $result = $this->is_username_available($fields);
48 48
 
49 49
         $accounthelper = new org_openpsa_user_accounthelper();
50
-        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])){
50
+        if ($fields['password']['switch'] && !$accounthelper->check_password_strength($fields['password']['password'])) {
51 51
             $result = ['password' => midcom::get()->i18n->get_string('password weak', 'org.openpsa.user')];
52 52
         }
53 53
 
@@ -155,10 +155,10 @@  discard block
 block discarded – undo
155 155
         $user = new midcom_db_person($fields["person"]);
156 156
 
157 157
         $accounthelper = new org_openpsa_user_accounthelper($user);
158
-        if (!$accounthelper->check_password_reuse($fields['new_password'])){
158
+        if (!$accounthelper->check_password_reuse($fields['new_password'])) {
159 159
             $result['password'] = midcom::get()->i18n->get_string('password was already used', 'org.openpsa.user');
160 160
         }
161
-        if (!$accounthelper->check_password_strength($fields['new_password'])){
161
+        if (!$accounthelper->check_password_strength($fields['new_password'])) {
162 162
             $result['password'] = midcom::get()->i18n->get_string('password weak', 'org.openpsa.user');
163 163
         }
164 164
         if (!empty($result)) {
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/invoice/pdf.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
         $filename = midcom_helper_misc::urlize($this->invoice->get_label()) . '.pdf';
89 89
 
90 90
         // tmp filename
91
-        $tmp_file = midcom::get()->config->get('midcom_tempdir') . "/". $filename;
91
+        $tmp_file = midcom::get()->config->get('midcom_tempdir') . "/" . $filename;
92 92
 
93 93
         // render pdf to tmp filename
94 94
         $pdf_builder->render($tmp_file);
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
             $attachment->update();
102 102
         } else {
103 103
             $attachment = $this->invoice->create_attachment($filename, $this->invoice->get_label(), "application/pdf");
104
-            if (   !$attachment
104
+            if (!$attachment
105 105
                 || !$this->invoice->set_parameter("midcom.helper.datamanager2.type.blobs", "guids_pdf_file", $attachment->guid . ":" . $attachment->guid)) {
106 106
                 throw new midcom_error("Failed to create invoice attachment for pdf: " . midcom_connection::get_error_string());
107 107
             }
Please login to merge, or discard this patch.
lib/midgard/admin/asgard/handler/undelete.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
             $object_label = $object->guid;
192 192
         }
193 193
         echo "{$prefix}    <td class=\"checkbox\"><input type=\"checkbox\" name=\"undelete[]\"{$disabled} value=\"{$object->guid}\" id=\"guid_{$object->guid}\" /></td>\n";
194
-        echo "{$prefix}    <td class=\"label\" style=\"padding-left: {$indent}px\"><a href=\"". $this->router->generate('object_deleted', ['guid' =>$object->guid]) . "\">{$icon} " . $object_label . "</a></td>\n";
194
+        echo "{$prefix}    <td class=\"label\" style=\"padding-left: {$indent}px\"><a href=\"" . $this->router->generate('object_deleted', ['guid' =>$object->guid]) . "\">{$icon} " . $object_label . "</a></td>\n";
195 195
         echo "{$prefix}    <td class=\"nowrap\">" . strftime('%x %X', strtotime($object->metadata->revised)) . "</td>\n";
196 196
 
197 197
         if (!empty($revisor->guid)) {
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
             $child_indent = $indent + 20;
208 208
             echo "{$prefix}<tbody class=\"children\">\n";
209 209
             foreach ($child_types as $type => $children) {
210
-                if (   count($children) < 10
210
+                if (count($children) < 10
211 211
                     || isset($_GET['show_children'][$object->guid][$type])) {
212 212
                         foreach ($children as $child) {
213 213
                             $this->show_type($child, $child_indent, "{$prefix}    ", false);
Please login to merge, or discard this patch.
lib/midcom/core/context.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
             return false;
154 154
         }
155 155
 
156
-        if (   $key === MIDCOM_CONTEXT_ROOTTOPIC
156
+        if ($key === MIDCOM_CONTEXT_ROOTTOPIC
157 157
             && $this->_data[$key] === null) {
158 158
             $this->_data[$key] = self::initialize_root_topic();
159 159
         }
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
      */
278 278
     public function set_custom_key($key, &$value)
279 279
     {
280
-        $this->_data[MIDCOM_CONTEXT_CUSTOMDATA][$key] =& $value;
280
+        $this->_data[MIDCOM_CONTEXT_CUSTOMDATA][$key] = & $value;
281 281
     }
282 282
 
283 283
     public function show()
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -165,7 +165,8 @@
 block discarded – undo
165 165
                 try {
166 166
                     self::$root_topic = midcom_db_topic::get_cached($guid);
167 167
                     return self::$root_topic;
168
-                } catch (midcom_error $e) {
168
+                }
169
+                catch (midcom_error $e) {
169 170
                     if ($e instanceof midcom_error_forbidden) {
170 171
                         throw $e;
171 172
                     }
Please login to merge, or discard this patch.
lib/net/nehmer/blog/handler/create.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
 
40 40
         $schema_name = $args[0];
41 41
         $schemadb = $data['schemadb'];
42
-        if (   $this->_config->get('simple_name_handling')
42
+        if ($this->_config->get('simple_name_handling')
43 43
             && !midcom::get()->auth->can_user_do('midcom:urlname')) {
44 44
             foreach ($schemadb->all() as $schema) {
45 45
                 $schema->get_field('name')['readonly'] = true;
Please login to merge, or discard this patch.
lib/net/nehmer/blog/handler/admin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
         $this->article->require_do('midgard:update');
52 52
 
53 53
         $schemadb = $data['schemadb'];
54
-        if (   $this->_config->get('simple_name_handling')
54
+        if ($this->_config->get('simple_name_handling')
55 55
             && !midcom::get()->auth->can_user_do('midcom:urlname')) {
56 56
             foreach ($schemadb->all() as $schema) {
57 57
                 $schema->get_field('name')['readonly'] = true;
Please login to merge, or discard this patch.
lib/org/openpsa/invoices/handler/invoice/view.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@
 block discarded – undo
107 107
 
108 108
             // sending per email enabled in billing data?
109 109
             $billing_data = org_openpsa_invoices_billing_data_dba::get_by_object($this->invoice);
110
-            if (    !$this->invoice->sent
110
+            if (!$this->invoice->sent
111 111
                  && intval($billing_data->sendingoption) == 2) {
112 112
                 $buttons[] = $this->build_button('send_by_mail', 'paper-plane');
113 113
             }
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/type/imageType.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
             ]
47 47
         ]);
48 48
 
49
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
49
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
50 50
             if ($options['required']) {
51 51
                 return [new constraint(['config' => $options['type_config']])];
52 52
             }
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 
79 79
         $builder->add('delete', CheckboxType::class, ['attr' => [
80 80
             "class" => "midcom_datamanager_photo_checkbox"
81
-        ], "required" => false ]);
81
+        ], "required" => false]);
82 82
         $builder->add('identifier', HiddenType::class);
83 83
     }
84 84
 
Please login to merge, or discard this patch.