Passed
Push — master ( 3657f2...b17fdb )
by Andreas
24:28 queued 05:07
created
lib/midcom/services/cache/module/nap.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
             // Get parent from DB and compare to catch moves
72 72
             if ($parent = $napobject[MIDCOM_NAV_OBJECT]->get_parent()) {
73 73
                 $parent_entry = $this->get_guid($parent->guid);
74
-                if (   $parent_entry
74
+                if ($parent_entry
75 75
                     && $parent_entry[MIDCOM_NAV_ID] != $cached_node_id) {
76 76
                     $this->backend->delete($parent_entry[MIDCOM_NAV_ID] . '-leaves');
77 77
                 }
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
             $parent_id = $napobject[MIDCOM_NAV_NODEID];
87 87
             $parent_entry = $this->get_node($parent_id);
88 88
 
89
-            if (   $parent_entry
89
+            if ($parent_entry
90 90
                 && array_key_exists(MIDCOM_NAV_SUBNODES, $parent_entry)) {
91 91
                 unset($parent_entry[MIDCOM_NAV_SUBNODES]);
92 92
                 $this->put_node($parent_id, $parent_entry);
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
             if ($parent = $napobject[MIDCOM_NAV_OBJECT]->get_parent()) {
97 97
                 $parent_entry_from_object = $this->get_guid($parent->guid);
98 98
 
99
-                if (    !empty($parent_entry_from_object[MIDCOM_NAV_ID])
99
+                if (!empty($parent_entry_from_object[MIDCOM_NAV_ID])
100 100
                      && !empty($parent_entry[MIDCOM_NAV_ID])
101 101
                      && $parent_entry_from_object[MIDCOM_NAV_ID] != $parent_entry[MIDCOM_NAV_ID]) {
102 102
                     unset($parent_entry_from_object[MIDCOM_NAV_SUBNODES]);
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
             $nav = new midcom_helper_nav;
123 123
             if ($object instanceof midcom_db_topic) {
124 124
                 $napobject = $nav->get_node($object->id);
125
-            } elseif (   ($node = $nav->find_closest_topic($object))
125
+            } elseif (($node = $nav->find_closest_topic($object))
126 126
                       && $nodeobject = $nav->get_node($node->id)) {
127 127
                 $napobject = $nav->get_leaf($nodeobject[MIDCOM_NAV_ID] . '-' . $object->id);
128 128
             }
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/type/captchaType.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,11 +43,11 @@
 block discarded – undo
43 43
     public function buildForm(FormBuilderInterface $builder, array $options)
44 44
     {
45 45
         $session_key = md5($builder->getForm()->getName() . '_session_key');
46
-        $builder->addEventListener(FormEvents::POST_SUBMIT, function (FormEvent $event) use ($session_key) {
46
+        $builder->addEventListener(FormEvents::POST_SUBMIT, function(FormEvent $event) use ($session_key) {
47 47
             $value = $event->getForm()->getData();
48 48
             $session = new midcom_services_session('midcom_datamanager_captcha');
49 49
 
50
-            if (   !$session->exists($session_key)
50
+            if (!$session->exists($session_key)
51 51
                 || $value != $session->get($session_key)) {
52 52
                 $event->getForm()->addError(new FormError($this->l10n->get('captcha validation failed')));
53 53
             }
Please login to merge, or discard this patch.
src/midcom/datamanager/extension/formExtension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@
 block discarded – undo
65 65
         $view->vars['readonly'] = $options['readonly'];
66 66
 
67 67
         if ($options['write_privilege'] !== null) {
68
-            if (   array_key_exists('group', $options['write_privilege'])
68
+            if (array_key_exists('group', $options['write_privilege'])
69 69
                 && !$this->auth->is_group_member($options['write_privilege']['group'])) {
70 70
                 $view->vars['readonly'] = true;
71 71
             }
Please login to merge, or discard this patch.
lib/midcom/debug.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -88,9 +88,9 @@  discard block
 block discarded – undo
88 88
 
89 89
         while ($bt) {
90 90
             $caller = array_shift($bt);
91
-            if (   !array_key_exists('class', $caller)
91
+            if (!array_key_exists('class', $caller)
92 92
                 || $caller['class'] != midcom_debug::class) {
93
-                if (   !array_key_exists('function', $bt[0])
93
+                if (!array_key_exists('function', $bt[0])
94 94
                     || $bt[0]['function'] != 'require') {
95 95
                     $caller = array_shift($bt);
96 96
                 }
@@ -102,11 +102,11 @@  discard block
 block discarded – undo
102 102
         if (array_key_exists('class', $caller)) {
103 103
             $record['extra']['caller'] .= $caller['class'] . '::';
104 104
         }
105
-        if (   array_key_exists('function', $caller)
105
+        if (array_key_exists('function', $caller)
106 106
             && !str_starts_with($caller['function'], 'debug_')) {
107 107
             $record['extra']['caller'] .= $caller['function'];
108 108
         } else {
109
-            $record['extra']['caller'] .= $caller['file'] . ' (' . $caller['line']. ')';
109
+            $record['extra']['caller'] .= $caller['file'] . ' (' . $caller['line'] . ')';
110 110
         }
111 111
         return $record;
112 112
     }
Please login to merge, or discard this patch.
lib/midcom/services/rcs/backend/rcs.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@
 block discarded – undo
91 91
                 $revisions[$history['revision']] = $history;
92 92
 
93 93
                 $i += 3;
94
-                while (   $i < $total
94
+                while ($i < $total
95 95
                         && !str_starts_with($lines[$i], '----')
96 96
                         && !str_starts_with($lines[$i], '=====')) {
97 97
                     $i++;
Please login to merge, or discard this patch.
lib/midcom/helper/nav/main.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -422,7 +422,7 @@  discard block
 block discarded – undo
422 422
                     $entry = "<span class=\"{$current_class}\">{$entry}</span>";
423 423
                 }
424 424
             } else {
425
-                if (   !empty($data['napobject'][MIDCOM_NAV_GUID])
425
+                if (!empty($data['napobject'][MIDCOM_NAV_GUID])
426 426
                     && in_array($data['napobject'][MIDCOM_NAV_GUID], $skip_guids)) {
427 427
                     continue;
428 428
                 }
@@ -537,7 +537,7 @@  discard block
 block discarded – undo
537 537
                     $id = "custom-{$key}";
538 538
 
539 539
                     $url = "{$prefix}{$entry[MIDCOM_NAV_URL]}";
540
-                    if (   str_starts_with($entry[MIDCOM_NAV_URL], '/')
540
+                    if (str_starts_with($entry[MIDCOM_NAV_URL], '/')
541 541
                         || preg_match('|^https?://|', $entry[MIDCOM_NAV_URL])) {
542 542
                         $url = $entry[MIDCOM_NAV_URL];
543 543
                     }
Please login to merge, or discard this patch.
lib/midcom/response/relocate.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
      */
28 28
     public function setTargetUrl($url)
29 29
     {
30
-        if (   !str_starts_with($url, "/")
30
+        if (!str_starts_with($url, "/")
31 31
             && !preg_match('|^https?://|', $url)) {
32 32
             $prefix = midcom_core_context::get()->get_key(MIDCOM_CONTEXT_ANCHORPREFIX);
33 33
             if ($prefix == '') {
Please login to merge, or discard this patch.
lib/midcom/config/main.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -427,7 +427,7 @@  discard block
 block discarded – undo
427 427
         // show_unapproved_objects). Disabled by default. Unsafe to Link Prefetching!
428 428
         'metadata_approval' => false,
429 429
         'metadata_scheduling' => false,
430
-        'metadata_lock_timeout' => 60,    // Time in minutes
430
+        'metadata_lock_timeout' => 60, // Time in minutes
431 431
         'staging2live_staging' => false,
432 432
 
433 433
         // Set the datamanager schema used by the Metadata Service
@@ -518,12 +518,12 @@  discard block
 block discarded – undo
518 518
             return $default;
519 519
         }
520 520
 
521
-        if (   $key === 'auth_type'
521
+        if ($key === 'auth_type'
522 522
             && !in_array($this->_merged_config[$key], ['Plaintext', 'Legacy', 'SHA256'])) {
523 523
             throw new midcom_error('Unsupported authentication type');
524 524
         }
525 525
         // Check the midcom_config site prefix for absolute local urls
526
-        if (   $key === 'midcom_site_url'
526
+        if ($key === 'midcom_site_url'
527 527
             && str_starts_with($this->_merged_config[$key], '/')) {
528 528
             $this->_merged_config[$key] = midcom::get()->get_page_prefix() . substr($this->_merged_config[$key], 1);
529 529
         }
Please login to merge, or discard this patch.
lib/org/openpsa/contacts/duplicates/check.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
             // if user's lastname is part of the email address, check to see if the difference is only in the domain part
129 129
             $email1 = preg_replace('/@.+/', '', $person1['email']);
130 130
             $email2 = preg_replace('/@.+/', '', $person2['email']);
131
-            if (   str_contains($email1, $person1['lastname'])
131
+            if (str_contains($email1, $person1['lastname'])
132 132
                 && $email1 == $email2) {
133 133
                 $ret['email_match'] = true;
134 134
                 $ret['p'] += 0.5;
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
 
175 175
     private function match(string $property, array $data1, array $data2) : bool
176 176
     {
177
-        if (   !empty($data1[$property])
177
+        if (!empty($data1[$property])
178 178
             && $data1[$property] == $data2[$property]) {
179 179
             return true;
180 180
         }
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
         $persons = $this->get_person_candidates();
326 326
 
327 327
         $params = [];
328
-        $params['objects'] =& $persons;
328
+        $params['objects'] = & $persons;
329 329
         $params['mode'] = 'person';
330 330
 
331 331
         array_walk($persons, [$this, 'check_all_arraywalk'], $params);
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
                 continue;
388 388
             }
389 389
 
390
-            if (   $obj1->get_parameter('org.openpsa.contacts.duplicates:not_duplicate', $obj2->guid)
390
+            if ($obj1->get_parameter('org.openpsa.contacts.duplicates:not_duplicate', $obj2->guid)
391 391
                 || $obj2->get_parameter('org.openpsa.contacts.duplicates:not_duplicate', $obj1->guid)) {
392 392
                 // Not-duplicate parameter found, returning zero probability
393 393
                 continue;
@@ -414,7 +414,7 @@  discard block
 block discarded – undo
414 414
 
415 415
         $groups = $this->get_group_candidates();
416 416
         $params = [];
417
-        $params['objects'] =& $groups;
417
+        $params['objects'] = & $groups;
418 418
         $params['mode'] = 'group';
419 419
         array_walk($groups, [$this, 'check_all_arraywalk'], $params);
420 420
 
Please login to merge, or discard this patch.