flack / openpsa

lib/midcom/admin/folder/handler/move.php

Braces +2 added lines, -1 removed lines

@@ -46,7 +46,8 @@
                 $target = new midcom_db_topic((int) $request->request->get('move_to'));
                 $this->_move_object($target);
                 midcom::get()->uimessages->add($this->_l10n->get($this->_component), sprintf($this->_l10n->get('moved %s to %s'), $this->_topic->get_label(), $target->get_label()));
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 midcom::get()->uimessages->add($this->_l10n->get($this->_component), $e->getMessage(), 'error');
             }
         }

Spacing +3 added lines, -3 removed lines

@@ -35,7 +35,7 @@ 
     {
         $this->_object = midcom::get()->dbfactory->get_object_by_guid($guid);
 
-        if (   !is_a($this->_object, midcom_db_topic::class)
+        if (!is_a($this->_object, midcom_db_topic::class)
             && !is_a($this->_object, midcom_db_article::class)) {
             throw new midcom_error_notfound("Moving only topics and articles is supported.");
         }
@@ -76,7 +76,7 @@ 
             $folder = midcom_core_context::get()->get_key(MIDCOM_CONTEXT_ROOTTOPIC);
         }
 
-        if (   is_a($this->_object, midcom_db_topic::class)
+        if (is_a($this->_object, midcom_db_topic::class)
             && $folder->up == $this->_object->id) {
             $tree_disabled = true;
         }
@@ -89,7 +89,7 @@ 
             $selected = ' checked="checked"';
         }
 
-        if (   !is_a($this->_object, midcom_db_topic::class)
+        if (!is_a($this->_object, midcom_db_topic::class)
             && $folder->component !== $this->current_folder->component) {
             // Non-topic objects may only be moved under folders of same component
             $class = 'wrong_component';

lib/midcom/helper/imagepopup/handler/list.php

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
         midcom::get()->auth->require_valid_user();
         midcom::get()->skip_page_style = true;
 
-        $this->add_stylesheet(MIDCOM_STATIC_URL ."/midcom.helper.imagepopup/styling.css", 'screen');
+        $this->add_stylesheet(MIDCOM_STATIC_URL . "/midcom.helper.imagepopup/styling.css", 'screen');
 
         $data['filetype'] = $filetype;
         $data['object'] = null;

lib/org/openpsa/user/handler/person/account.php

Spacing +2 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
         $workflow = $this->get_workflow('datamanager', ['controller' => $data['controller']]);
         $response = $workflow->run($request);
 
-        if (   $workflow->get_state() == 'save'
+        if ($workflow->get_state() == 'save'
             && $this->create_account($this->person, $data["controller"]->get_form_values())) {
             midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), sprintf($this->_l10n->get('person %s created'), $this->person->name));
         }
@@ -148,7 +148,7 @@ 
         $accounthelper = new org_openpsa_user_accounthelper($this->person);
 
         // Update account
-        if (   !$accounthelper->set_account($controller->get_form_values()["username"], $password)
+        if (!$accounthelper->set_account($controller->get_form_values()["username"], $password)
             && midcom_connection::get_error() != MGD_ERR_OK) {
             // Failure, give a message
             midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.user'), $this->_l10n->get("failed to update the user account, reason") . ': ' . midcom_connection::get_error_string(), 'error');

lib/org/openpsa/expenses/handler/hours/admin.php

Braces +2 added lines, -1 removed lines

@@ -100,7 +100,8 @@
         try {
             $task = org_openpsa_projects_task_dba::get_cached($hour_report->task);
             $options['success_url'] = $this->router->generate('list_hours_task', ['guid' => $task->guid]);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
         return $this->get_workflow('delete', $options)->run($request);

src/midcom/datamanager/controller.php

Spacing +3 added lines, -3 removed lines

@@ -70,13 +70,13 @@ 
             }
         } elseif (!$this->form->isSubmitted()) {
             $this->form->handleRequest($request);
-            if (   $this->form->isSubmitted()
+            if ($this->form->isSubmitted()
                 && $button = $this->form->getClickedButton()) {
                 $operation = $button->getConfig()->getOption('operation');
             }
         }
 
-        if (   in_array($operation, [self::SAVE, self::NEXT])
+        if (in_array($operation, [self::SAVE, self::NEXT])
             && !$this->form->isValid()) {
             $operation = self::EDIT;
         }
@@ -159,7 +159,7 @@ 
                 if ($storage->get_last_operation() === self::SAVE) {
                     // Get GUIDs and such for new-created dependent objects
                     $this->dm->set_storage($storage->get_value(), $this->dm->get_schema()->get_name());
-                } elseif (   !$this->form->isValid()
+                } elseif (!$this->form->isValid()
                           && $storage->move_uploaded_files() > 0) {
                     $form = $this->dm->get_form($this->form->getName(), true);
                     $this->copy_errors($this->form, $form);

lib/net/nehmer/blog/style/feeds-item.php

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
 $item->title = $data['article']->title;
 $arg = $data['article']->name ?: $data['article']->guid;
 
-if (   $data['config']->get('link_to_external_url')
+if ($data['config']->get('link_to_external_url')
     && !empty($data['article']->url)) {
     $item->link = $data['article']->url;
 } else {
@@ -37,7 +37,7 @@ 
     $item->description .= '<div class="abstract">' . $view['abstract'] . '</div>';
 }
 
-if (   array_key_exists('image', $view)
+if (array_key_exists('image', $view)
     && $data['config']->get('rss_use_image')) {
     $item->description .= "\n<div class=\"image\">" . $view['image'] . '</div>';
 }

lib/org/openpsa/documents/handler/document/admin.php

Spacing +1 added lines, -1 removed lines

@@ -101,7 +101,7 @@
 
         $this->_controller = $this->load_controller();
 
-        if (   $data['enable_versioning']
+        if ($data['enable_versioning']
             && $request->request->count() > 0) {
             $this->_backup_attachment();
         }

lib/midgard/admin/asgard/handler/type.php

Spacing +1 added lines, -1 removed lines

@@ -104,7 +104,7 @@
         }
 
         $help = new midcom_admin_help_help();
-        $this->_request_data['help'] = $help->get_help_contents('asgard_'.$this->type, $help_component);
+        $this->_request_data['help'] = $help->get_help_contents('asgard_' . $this->type, $help_component);
         $this->_request_data['component'] = $component;
     }
 

lib/org/openpsa/relatedto/suspect.php

Spacing +3 added lines, -3 removed lines

@@ -68,14 +68,14 @@ 
     {
         $properties = ['fromClass', 'toClass', 'fromGuid', 'toGuid', 'fromComponent', 'toComponent', 'status', 'toExtra', 'toExtra'];
         foreach ($properties as $property) {
-            if (   !empty($defaults->$property)
+            if (!empty($defaults->$property)
                 && empty($link->$property)) {
                 debug_add("Copying property '{$property}' ('{$defaults->$property}') from defaults");
                 $link->$property = $defaults->$property;
             }
         }
 
-        if (   empty($link->toComponent)
+        if (empty($link->toComponent)
             && !empty($link->fromComponent)) {
             debug_add("Setting property 'toComponent' to '{$component}'");
             $link->toComponent = $component;
@@ -84,7 +84,7 @@ 
             $link->fromComponent = $component;
         }
 
-        if (   empty($link->toGuid)
+        if (empty($link->toGuid)
             && !empty($link->fromGuid)) {
             $link->toClass = get_class($obj);
             $link->toGuid = $obj->guid;