flack / openpsa

lib/org/openpsa/sales/handler/list.php

Braces +2 added lines, -1 removed lines

@@ -113,7 +113,8 @@
         try {
             $this->_request_data['customer'] = new org_openpsa_contacts_group_dba($guid);
             $qb->add_constraint('customer', '=', $this->_request_data['customer']->id);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $this->_request_data['customer'] = new org_openpsa_contacts_person_dba($guid);
             $qb->add_constraint('customerContact', '=', $this->_request_data['customer']->id);
         }

lib/org/openpsa/contacts/midcom/indexer.php

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
  */
 class org_openpsa_contacts_midcom_indexer extends midcom_helper_datamanager2_indexer_client
 {
-    public function prepare_document(midcom_services_indexer_document &$document, midcom_helper_datamanager2_datamanager $dm)
+    public function prepare_document(midcom_services_indexer_document & $document, midcom_helper_datamanager2_datamanager $dm)
     {
         if (is_a($dm->storage->object, 'org_openpsa_contacts_person_dba')) {
             $document->title = $dm->storage->object->name;

lib/org/openpsa/contacts/handler/person/view.php

Spacing +4 added lines, -4 removed lines

@@ -110,7 +110,7 @@ 
         $invoices_url = $siteconfig->get_node_full_url('org.openpsa.invoices');
         $user_url = $siteconfig->get_node_full_url('org.openpsa.user');
 
-        if (   $invoices_url
+        if ($invoices_url
             && midcom::get()->auth->can_user_do('midgard:create', null, 'org_openpsa_invoices_invoice_dba')
             && $this->_contact->can_do('midgard:update')) {
             $buttons[] = $workflow->get_button($invoices_url . "billingdata/" . $this->_contact->guid . '/', array(
@@ -118,8 +118,8 @@ 
             ));
         }
 
-        if (   $user_url
-            && (   midcom_connection::get_user() == $this->_contact->id
+        if ($user_url
+            && (midcom_connection::get_user() == $this->_contact->id
                 || midcom::get()->auth->can_user_do('org.openpsa.user:access', null, 'org_openpsa_user_interface'))) {
             $buttons[] = array(
                 MIDCOM_TOOLBAR_URL => $user_url . "view/{$this->_contact->guid}/",
@@ -197,7 +197,7 @@ 
      */
     public function _show_group_memberships($handler_id, array &$data)
     {
-        if (   count($data['organizations']) == 0
+        if (count($data['organizations']) == 0
             && count($data['groups']) == 0) {
             midcom_show_style('show-person-groups-empty');
         } else {

Braces +2 added lines, -1 removed lines

@@ -216,7 +216,8 @@
         foreach ($this->_request_data[$identifier] as $member) {
             try {
                 $this->_request_data['group'] = org_openpsa_contacts_group_dba::get_cached($member->gid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
                 continue;
             }

lib/org/openpsa/contacts/handler/person/admin.php

Spacing +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
     {
         $this->_load_schemadb();
         $this->_controller = midcom_helper_datamanager2_controller::create('simple');
-        $this->_controller->schemadb =& $this->_schemadb;
+        $this->_controller->schemadb = & $this->_schemadb;
         $this->_controller->set_storage($this->_contact, $this->_schema);
         if (!$this->_controller->initialize()) {
             throw new midcom_error("Failed to initialize a DM2 controller instance for contact {$this->_contact->id}.");

lib/org/openpsa/contacts/handler/group/view.php

Spacing +2 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
             );
         }
 
-        if (   midcom::get()->auth->can_user_do('midgard:create', null, 'org_openpsa_contacts_person_dba')
+        if (midcom::get()->auth->can_user_do('midgard:create', null, 'org_openpsa_contacts_person_dba')
             && $this->group->can_do('midgard:create')) {
             $buttons[] = $workflow->get_button("person/create/{$this->group->guid}/", array(
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n->get('create person'),
@@ -68,7 +68,7 @@ 
 
         $siteconfig = org_openpsa_core_siteconfig::get_instance();
         $user_url = $siteconfig->get_node_full_url('org.openpsa.user');
-        if (   $user_url
+        if ($user_url
             && midcom::get()->auth->can_user_do('org.openpsa.user:access', null, 'org_openpsa_user_interface')) {
             $buttons[] = array(
                 MIDCOM_TOOLBAR_URL => $user_url . "group/{$this->group->guid}/",

lib/org/openpsa/reports/handler/base.php

Spacing +6 added lines, -6 removed lines

@@ -42,7 +42,7 @@ 
     public function _handler_generator_get($handler_id, array $args, array &$data)
     {
         midcom::get()->auth->require_valid_user();
-        if (   !array_key_exists('org_openpsa_reports_query_data', $_REQUEST)
+        if (!array_key_exists('org_openpsa_reports_query_data', $_REQUEST)
             || !is_array($_REQUEST['org_openpsa_reports_query_data'])) {
             throw new midcom_error('query data not present or invalid');
         }
@@ -89,7 +89,7 @@ 
     private function _load_edit_controller()
     {
         $this->_controller = midcom_helper_datamanager2_controller::create('simple');
-        $this->_controller->schemadb =& $this->_schemadb;
+        $this->_controller->schemadb = & $this->_schemadb;
         $this->_controller->set_storage($this->_request_data['query'], 'default');
         if (!$this->_controller->initialize()) {
             throw new midcom_error("Failed to initialize a DM2 controller instance for document {$this->_document->id}.");
@@ -132,9 +132,9 @@ 
     {
         $this->_load_schemadb();
         $this->_controller = midcom_helper_datamanager2_controller::create('create');
-        $this->_controller->schemadb =& $this->_schemadb;
+        $this->_controller->schemadb = & $this->_schemadb;
         $this->_controller->schemaname = 'default';
-        $this->_controller->callback_object =& $this;
+        $this->_controller->callback_object = & $this;
         if (!$this->_controller->initialize()) {
             throw new midcom_error("Failed to initialize a DM2 create controller.");
         }
@@ -172,9 +172,9 @@ 
         $this->_request_data['datamanager'] = $this->_datamanagers[$this->module];
 
         if (isset($data['query'])) {
-            $breadcrumb_label =  sprintf($this->_l10n->get('edit report %s'), $data['query']->title);
+            $breadcrumb_label = sprintf($this->_l10n->get('edit report %s'), $data['query']->title);
         } else {
-            $breadcrumb_label =  $this->_l10n->get('define custom report');
+            $breadcrumb_label = $this->_l10n->get('define custom report');
         }
         $this->add_breadcrumb("", $breadcrumb_label);
     }

lib/org/openpsa/reports/handler/sales/report.php

Braces +2 added lines, -1 removed lines

@@ -71,7 +71,8 @@
             $owner = org_openpsa_contacts_person_dba::get_cached($salesproject->owner);
             $row['index_owner'] = $owner->name;
             $row['owner'] = org_openpsa_widgets_contact::get($owner->guid)->show_inline();
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
         $row['amount'] = $object->pricePerUnit * $object->units;

lib/org/openpsa/helpers/list.php

Braces +2 added lines, -1 removed lines

@@ -69,7 +69,8 @@
         if (empty(self::$_seen[$company_id])) {
             try {
                 $company = new org_openpsa_contacts_group_dba($company_id);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 return;
             }
             self::$_seen[$company->id] = true;

lib/org/openpsa/widgets/contact.php

Braces +4 added lines, -2 removed lines

@@ -114,7 +114,8 @@ 
 
         try {
             $person = org_openpsa_contacts_person_dba::get_cached($src);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $widget = new self();
             $cache[$src] = $widget;
             return $widget;
@@ -323,7 +324,8 @@ 
         foreach ($memberships as $data) {
             try {
                 $group = org_openpsa_contacts_group_dba::get_cached($data['gid']);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
                 continue;
             }

Spacing +8 added lines, -8 removed lines

@@ -132,7 +132,7 @@ 
      */
     private function read_object($person)
     {
-        if (   !is_object($person)
+        if (!is_object($person)
             || !midcom::get()->dbfactory->is_a($person, 'midcom_db_person')) {
             // Given $person is not one
             return false;
@@ -156,12 +156,12 @@ 
             }
         }
 
-        if (   $this->_config->get('jabber_enable_presence')
+        if ($this->_config->get('jabber_enable_presence')
             && $person->get_parameter('org.openpsa.jabber', 'jid')) {
             $this->contact_details['jid'] = $person->get_parameter('org.openpsa.jabber', 'jid');
         }
 
-        if (   $this->_config->get('skype_enable_presence')
+        if ($this->_config->get('skype_enable_presence')
             && $person->get_parameter('org.openpsa.skype', 'name')) {
             $this->contact_details['skype'] = $person->get_parameter('org.openpsa.skype', 'name');
         }
@@ -236,7 +236,7 @@ 
 
         // Show picture
         // TODO: Implement photo also in local way
-        if (   $this->_config->get('gravatar_enable')
+        if ($this->_config->get('gravatar_enable')
             && !empty($this->contact_details['email'])) {
             $size = $this->_config->get('gravatar_size');
             $gravatar_url = "http://www.gravatar.com/avatar.php?gravatar_id=" . md5($this->contact_details['email']) . "&size=" . $size;
@@ -310,7 +310,7 @@ 
 
     private function _show_groups()
     {
-        if (   !$this->show_groups
+        if (!$this->show_groups
             || empty($this->contact_details['id'])) {
             return;
         }
@@ -376,7 +376,7 @@ 
                     $cards_to_show[] = $cardname;
                 }
             } else {
-                if (    $customer->$property
+                if ($customer->$property
                     || ($customer->street && !$inherited_cards_only && !$default_shown)) {
                     $inherited_cards_only = false;
                     $multiple_addresses = true;
@@ -398,8 +398,8 @@ 
 
         foreach ($cards_to_show as $cardname) {
             echo '<div class="vcard">';
-            if (   $multiple_addresses
-                || (   $cardname != 'visiting'
+            if ($multiple_addresses
+                || ($cardname != 'visiting'
                     && !$inherited_cards_only)) {
                 echo '<div style="text-align:center"><em>' . midcom::get()->i18n->get_string($cardname . ' address', 'org.openpsa.contacts') . "</em></div>\n";
             }