flack / openpsa

lib/midgard/admin/asgard/stylehelper.php

Indentation +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
                 'midcom' => array(
                     'style-init' => '',
                     'style-finish' => '',
-                 )
+                    )
             ),
             'nodes' => array(),
         );

Spacing +5 added lines, -5 removed lines

@@ -22,7 +22,7 @@ 
 
     public function __construct(array &$data)
     {
-        $this->_data =& $data;
+        $this->_data = & $data;
         midcom::get()->head->enable_jquery_ui(array('accordion'));
     }
 
@@ -33,11 +33,11 @@ 
             return;
         }
 
-        if (   midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_style')
-            && (   $this->_data['handler_id'] !== '____mfa-asgard-object_create'
+        if (midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_style')
+            && ($this->_data['handler_id'] !== '____mfa-asgard-object_create'
                 || $this->_data['current_type'] == 'midgard_element')) {
             $help_element = $this->_get_help_style_elementnames($this->_data['object']);
-        } elseif (   midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_element')
+        } elseif (midcom::get()->dbfactory->is_a($this->_data['object'], 'midgard_element')
                   && $this->_data['handler_id'] !== '____mfa-asgard-object_create') {
             $help_element = $this->_get_help_element();
         }
@@ -49,7 +49,7 @@ 
 
     private function _get_help_element()
     {
-        if (   empty($this->_data['object']->name)
+        if (empty($this->_data['object']->name)
             || empty($this->_data['object']->style)) {
             // We cannot help with empty elements
             return;

lib/midgard/admin/asgard/response.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
     public function send()
     {
         $context = midcom_core_context::get();
-        $data =& $context->get_custom_key('request_data');
+        $data = & $context->get_custom_key('request_data');
         midcom::get()->style->enter_context($context->id);
 
         if (isset($data['view_title'])) {

lib/midgard/admin/user/handler/list.php

Braces +2 added lines, -1 removed lines

@@ -217,7 +217,8 @@
 
         try {
             $account = new midcom_core_account($person);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             midcom::get()->uimessages->add($this->_l10n->get('midgard.admin.user'), sprintf($this->_l10n->get('failed to get the user with id %s'), $person->id), 'error');
             return;
         }

lib/midgard/admin/user/handler/group/list.php

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
                 midcom::get()->uimessages->add($this->_l10n->get('midgard.admin.user'), $this->_l10n_midcom->get('updated'));
                 return new midcom_response_relocate("__mfa/asgard_midgard.admin.user/group/edit/{$data['group']->guid}/");
             }
-            debug_add('Failed to update the group, last error was '. midcom_connection::get_error_string(), MIDCOM_LOG_ERROR);
+            debug_add('Failed to update the group, last error was ' . midcom_connection::get_error_string(), MIDCOM_LOG_ERROR);
             debug_print_r('We operated on this object', $data['group'], MIDCOM_LOG_ERROR);
 
             throw new midcom_error('Failed to update the group, see error level log for details');

lib/midgard/admin/user/handler/group/create.php

Spacing +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
         $this->_group = new midcom_db_group();
         if (!$this->_group->create()) {
             debug_print_r('We operated on this object:', $this->_group);
-            throw new midcom_error('Failed to create a new group. Last Midgard error was: '. midcom_connection::get_error_string());
+            throw new midcom_error('Failed to create a new group. Last Midgard error was: ' . midcom_connection::get_error_string());
         }
 
         return $this->_group;

lib/midgard/admin/user/handler/user/create.php

Spacing +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
         $this->_person = new midcom_db_person();
         if (!$this->_person->create()) {
             debug_print_r('We operated on this object:', $this->_person);
-            throw new midcom_error('Failed to create a new person. Last Midgard error was: '. midcom_connection::get_error_string());
+            throw new midcom_error('Failed to create a new person. Last Midgard error was: ' . midcom_connection::get_error_string());
         }
 
         return $this->_person;

lib/midgard/admin/user/validator.php

Spacing +2 added lines, -2 removed lines

@@ -27,8 +27,8 @@
         if (!empty($fields["username"])) {
             $user = midcom::get()->auth->get_user_by_name($fields["username"]);
 
-            if (   $user
-                && (   !isset($fields['person'])
+            if ($user
+                && (!isset($fields['person'])
                     || $user->guid != $fields['person'])) {
                 $result["username"] = sprintf(midcom::get()->i18n->get_string("username %s is already in use", "midgard.admin.user"), $fields['username']);
             }

lib/org/openpsa/projects/midcom/indexer.php

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
  */
 class org_openpsa_projects_midcom_indexer extends midcom_helper_datamanager2_indexer_client
 {
-    public function prepare_document(midcom_services_indexer_document &$document, midcom_helper_datamanager2_datamanager $dm)
+    public function prepare_document(midcom_services_indexer_document & $document, midcom_helper_datamanager2_datamanager $dm)
     {
         $document->title = $dm->storage->object->get_label();
         if (is_a($dm->storage->object, 'org_openpsa_projects_task_dba')) {

lib/org/openpsa/projects/handler/workflow.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
     {
         midcom::get()->auth->require_valid_user();
         //Look for action among POST variables, then load main handler...
-        if (   empty($_POST['org_openpsa_projects_workflow_action'])
+        if (empty($_POST['org_openpsa_projects_workflow_action'])
             || !is_array($_POST['org_openpsa_projects_workflow_action'])) {
             throw new midcom_error('Incomplete request');
         }