flack / openpsa

lib/midcom/helper/datamanager2/type/number.php

Spacing +2 added lines, -2 removed lines

@@ -170,11 +170,11 @@
      */
     public function validate_number($fields)
     {
-        if (   $this->minimum !== null
+        if ($this->minimum !== null
             && $fields[$this->name] < $this->minimum) {
             return array($this->name => sprintf($this->_l10n->get('type number: value must not be smaller than %s'), $this->minimum));
         }
-        if (   $this->maximum !== null
+        if ($this->maximum !== null
             && $fields[$this->name] > $this->maximum) {
             return array($this->name => sprintf($this->_l10n->get('type number: value must not be larger than %s'), $this->maximum));
         }

lib/midcom/helper/datamanager2/type/date.php

Spacing +6 added lines, -6 removed lines

@@ -76,7 +76,7 @@ 
             return true;
         }
 
-        if (   !isset($this->_datamanager->types[$this->later_than])
+        if (!isset($this->_datamanager->types[$this->later_than])
             || !is_a($this->_datamanager->types[$this->later_than], 'midcom_helper_datamanager2_type_date')
             || !$this->_datamanager->types[$this->later_than]->value) {
             debug_add("Failed to validate date field {$this->name} with {$this->later_than}, as such date field wasn't found.",
@@ -196,10 +196,10 @@ 
     {
         // FIXME: This is not exactly an elegant way to do this
         $widget_conf = $this->storage->_schema->fields[$this->name]['widget_config'];
-        if (    $this->storage_type != 'ISO_DATE'
-            && (   !array_key_exists('show_time', $widget_conf)
+        if ($this->storage_type != 'ISO_DATE'
+            && (!array_key_exists('show_time', $widget_conf)
                 || $widget_conf['show_time'])) {
-            if (   array_key_exists('hide_seconds', $widget_conf)
+            if (array_key_exists('hide_seconds', $widget_conf)
                 && !$widget_conf['hide_seconds']) {
                 return 'medium';
             }
@@ -230,13 +230,13 @@ 
         }
 
         //sometimes the date-compare function seems to corrupt the date, by changing timezone maybe
-        if (   !empty($this->min_date)
+        if (!empty($this->min_date)
             && $this->value < new DateTime($this->min_date)) {
             $min_date = new DateTime($this->min_date);
             $this->validation_error = sprintf($this->_l10n->get('type date: this date must be %s or later'), htmlspecialchars($this->_l10n->get_formatter()->date($min_date)));
             return false;
         }
-        if (   !empty($this->max_date)
+        if (!empty($this->max_date)
             && $this->value > new DateTime($this->max_date)) {
             $max_date = new DateTime($this->max_date);
             $this->validation_error = sprintf($this->_l10n->get('type date: this date must be %s or earlier'), htmlspecialchars($this->_l10n->get_formatter()->date($max_date)));

lib/midcom/helper/datamanager2/type/photo.php

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
      */
     protected function _prepare_recreate($force = true)
     {
-        if (   !empty($this->_original_tmpname)
+        if (!empty($this->_original_tmpname)
             && !$force) {
             // We have prepared.
             return true;

lib/midcom/helper/datamanager2/type/php.php

Spacing +1 added lines, -1 removed lines

@@ -87,7 +87,7 @@
      */
     public function _on_validate()
     {
-        if (   is_array($this->value)
+        if (is_array($this->value)
             || is_object($this->value)) {
             $this->validation_error = $this->_l10n->get('type text: value may not be array or object');
             return false;

lib/midcom/helper/datamanager2/type/privilege.php

Spacing +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
      */
     public function _on_initialize()
     {
-        if (   !$this->name
+        if (!$this->name
             || !$this->assignee) {
             throw new midcom_error("The field {$this->name} had no name or assignee specified with it, cannot start up.");
         }

lib/midcom/helper/configuration.php

Spacing +5 added lines, -5 removed lines

@@ -144,7 +144,7 @@ 
     private function _update_cache()
     {
         $this->_merged = $this->_global;
-        if (   !empty($this->_local)
+        if (!empty($this->_local)
             && is_array($this->_local)) {
             $this->_merged = array_merge($this->_merged, $this->_local);
         }
@@ -186,7 +186,7 @@ 
      */
     public function store(array $params, $reset = true)
     {
-        if (   !$this->_object_stored
+        if (!$this->_object_stored
             && $this->_object) {
             $this->_store_from_object();
         }
@@ -246,7 +246,7 @@ 
      */
     public function get($key)
     {
-        if (   !$this->_object_stored
+        if (!$this->_object_stored
             && $this->_object) {
             $this->_store_from_object();
         }
@@ -278,7 +278,7 @@ 
      */
     public function get_all()
     {
-        if (   !$this->_object_stored
+        if (!$this->_object_stored
             && $this->_object) {
             $this->_store_from_object();
         }
@@ -294,7 +294,7 @@ 
      */
     public function exists($key)
     {
-        if (   !$this->_object_stored
+        if (!$this->_object_stored
             && $this->_object) {
             $this->_store_from_object();
         }

lib/midcom/admin/folder/handler/order.php

Braces +2 added lines, -1 removed lines

@@ -69,7 +69,8 @@
         // Use the DB Factory to resolve the class and to get the object
         try {
             $object = midcom::get()->dbfactory->get_object_by_guid($identifier);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             // This is probably a pseudo leaf, store the score to the current node
             $this->_topic->set_parameter('midcom.helper.nav.score', $identifier, $score);
             return true;

Spacing +3 added lines, -3 removed lines

@@ -89,7 +89,7 @@ 
         }
 
         // Approve if possible
-        if (   $approval_status
+        if ($approval_status
             && $object->can_do('midcom:approve')) {
             $object->metadata->approve();
         }
@@ -135,10 +135,10 @@ 
             // jQuery sorting
             midcom::get()->head->enable_jquery_ui(array('mouse', 'sortable'));
 
-            midcom::get()->head->add_jsfile(MIDCOM_STATIC_URL.'/midcom.admin.folder/jquery-postfix.js');
+            midcom::get()->head->add_jsfile(MIDCOM_STATIC_URL . '/midcom.admin.folder/jquery-postfix.js');
 
             // Custom styles
-            $this->add_stylesheet(MIDCOM_STATIC_URL.'/midcom.admin.folder/midcom-admin-order.css');
+            $this->add_stylesheet(MIDCOM_STATIC_URL . '/midcom.admin.folder/midcom-admin-order.css');
         }
     }
 

lib/midcom/admin/folder/handler/approvals.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
      */
     public function _handler_approval($handler_id, array $args, array &$data)
     {
-        if (   !array_key_exists('guid', $_REQUEST)
+        if (!array_key_exists('guid', $_REQUEST)
             || !array_key_exists('return_to', $_REQUEST)) {
             throw new midcom_error('Cannot process approval request, request is incomplete.');
         }

lib/midcom/admin/folder/selectcomponent.php

Indentation +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
         $select_attributes['class'] .= ' selectcomponent';
 
         $select_element = $this->_form->createElement('select', $this->name, $this->_translate($this->_field['title']),
-           array(), $select_attributes);
+            array(), $select_attributes);
 
         // Translate and add
         foreach ($this->_all_elements as $key => $value) {