flack / openpsa

lib/org/openpsa/contacts/handler/person/create.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
 
     public function _handler_create(Request $request, ?string $guid = null)
     {
-        midcom::get()->auth->require_user_do('midgard:create', class: org_openpsa_contacts_person_dba::class);
+        midcom::get()->auth->require_user_do('midgard:create', class : org_openpsa_contacts_person_dba::class);
 
         $defaults = [];
         if (!empty($guid)) {

lib/org/openpsa/sales/handler/edit.php

Spacing +2 added lines, -2 removed lines

@@ -37,7 +37,7 @@ 
 
     public function _handler_new(Request $request, ?string $guid = null)
     {
-        midcom::get()->auth->require_user_do('midgard:create', class: org_openpsa_sales_salesproject_dba::class);
+        midcom::get()->auth->require_user_do('midgard:create', class : org_openpsa_sales_salesproject_dba::class);
 
         $this->_salesproject = new org_openpsa_sales_salesproject_dba;
 
@@ -48,7 +48,7 @@ 
         $schemadb = schemadb::from_path($this->_config->get('schemadb_salesproject'));
 
         if ($guid) {
-            $field =& $schemadb->get('default')->get_field('customer');
+            $field = & $schemadb->get('default')->get_field('customer');
             try {
                 $customer = new org_openpsa_contacts_group_dba($guid);
                 $field['type_config']['options'] = [0 => '', $customer->id => $customer->official];

lib/org/openpsa/expenses/handler/hours/admin.php

Spacing +1 added lines, -1 removed lines

@@ -133,7 +133,7 @@
         return new midcom_response_relocate($relocate);
     }
 
-    private function parse_input(ParameterBag $input, string $action) : int|bool
+    private function parse_input(ParameterBag $input, string $action) : int | bool
     {
         if (!in_array($action, ['invoiceable', 'invoice', 'task'])) {
             throw new midcom_error('passed action ' . $action . ' is unknown');

lib/org/openpsa/directmarketing/handler/import.php

Spacing +2 added lines, -2 removed lines

@@ -138,7 +138,7 @@ 
 
         if ($contacts = $importer->parse($input)) {
             $this->_request_data['import_status'] = $importer->import_subscribers($contacts, $this->_request_data['campaign']);
-            if (   $this->_request_data['import_status']['subscribed_new'] > 0
+            if ($this->_request_data['import_status']['subscribed_new'] > 0
                 || $this->_request_data['import_status']['already_subscribed'] > 0) {
                 $this->_import_success = true;
             }
@@ -195,7 +195,7 @@ 
                 $read_rows = 0;
                 $handle = fopen($data['tmp_file'], 'r');
                 $total_columns = 0;
-                while (   $read_rows < 2
+                while ($read_rows < 2
                        && $csv_line = fgetcsv($handle, 1000, $data['separator'])) {
                     if ($total_columns == 0) {
                         $total_columns = count($csv_line);

lib/org/openpsa/sales/validator.php

Spacing +2 added lines, -2 removed lines

@@ -17,7 +17,7 @@ 
     {
         $result = $this->validate_units($fields);
 
-        if (   empty($fields['end'])
+        if (empty($fields['end'])
             && empty($fields['continuous'])) {
             if ($result === true) {
                 $result = [];
@@ -29,7 +29,7 @@ 
 
     public function validate_units(array $fields)
     {
-        if (   empty($fields['invoiceByActualUnits'])
+        if (empty($fields['invoiceByActualUnits'])
             && empty($fields['plannedUnits'])) {
             return [
                 'plannedUnits' => midcom::get()->i18n->get_string('select either planned units or invoice by actual units', 'org.openpsa.sales')

lib/org/openpsa/sales/handler/deliverable/admin.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
             $schema->get_field('next_cycle')['hidden'] = false;
             $schema->get_field('next_cycle')['default'] = $entry->start;
             $schema->get_field('at_entry')['default'] = $entry->id;
-        } elseif (   ($this->_deliverable->continuous || $this->_deliverable->end > time())
+        } elseif (($this->_deliverable->continuous || $this->_deliverable->end > time())
                   && $this->_deliverable->state == org_openpsa_sales_salesproject_deliverable_dba::STATE_STARTED) {
             $schema->get_field('next_cycle')['hidden'] = false;
         }

lib/net/nehmer/comments/handler/moderate.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
         $message['title'] = sprintf($this->_l10n->get('comment %s reported as abuse'), $comment->title);
         $message['content'] = '';
         if ($logs = $comment->get_logs()) {
-            $message['content'] .= $this->_l10n->get('moderation history').":\n\n";
+            $message['content'] .= $this->_l10n->get('moderation history') . ":\n\n";
             foreach ($logs as $time => $log) {
                 $reported = $this->_l10n->get_formatter()->datetime(strtotime("{$time}Z"));
                 $message['content'] .= $this->_l10n->get(sprintf('%s: %s by %s (from %s)', "$reported:\n", $this->_l10n->get($log['action']), $log['reporter'], $log['ip'])) . "\n\n";

lib/org/openpsa/invoices/invoice/item.php

Spacing +4 added lines, -4 removed lines

@@ -25,7 +25,7 @@ 
 
     public function _on_creating() : bool
     {
-        if (   $this->invoice
+        if ($this->invoice
             && $this->position == 0) {
             $invoice = org_openpsa_invoices_invoice_dba::get_cached($this->invoice);
             $this->position = count($invoice->get_invoice_items()) + 1;
@@ -75,7 +75,7 @@ 
             } catch (midcom_error) {
             }
         }
-        if (   $url == ''
+        if ($url == ''
             && $sales_url) {
             try {
                 $deliverable = org_openpsa_sales_salesproject_deliverable_dba::get_cached($this->deliverable);
@@ -97,7 +97,7 @@ 
                 $invoice = new org_openpsa_invoices_invoice_dba($this->invoice);
                 $old_sum = $invoice->sum;
                 self::update_invoice($invoice);
-                if (   $old_sum != $invoice->sum
+                if ($old_sum != $invoice->sum
                     && !empty($this->deliverable)) {
                     $deliverable = new org_openpsa_sales_salesproject_deliverable_dba($this->deliverable);
                     self::update_deliverable($deliverable);
@@ -135,7 +135,7 @@ 
 
         if ($invoiced != $deliverable->invoiced) {
             $deliverable->invoiced = $invoiced;
-            if (   $deliverable->orgOpenpsaObtype !== org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
+            if ($deliverable->orgOpenpsaObtype !== org_openpsa_products_product_dba::DELIVERY_SUBSCRIPTION
                 && $deliverable->state < org_openpsa_sales_salesproject_deliverable_dba::STATE_INVOICED) {
                 $deliverable->state = org_openpsa_sales_salesproject_deliverable_dba::STATE_INVOICED;
             }

lib/midcom/helper/metadata.php

Spacing +7 added lines, -7 removed lines

@@ -254,7 +254,7 @@ 
     {
         if (in_array($key, $this->field_config['timebased'])) {
             // This is ugly, but seems the only possible way...
-            if (   isset($this->__metadata->$key)
+            if (isset($this->__metadata->$key)
                 && (string) $this->__metadata->$key !== "0001-01-01T00:00:00+00:00") {
                 return (int) $this->__metadata->$key->format('U');
             }
@@ -315,11 +315,11 @@ 
         }
 
         $now = time();
-        if (   $this->get('schedulestart')
+        if ($this->get('schedulestart')
             && $this->get('schedulestart') > $now) {
             return false;
         }
-        if (   $this->get('scheduleend')
+        if ($this->get('scheduleend')
             && $this->get('scheduleend') < $now) {
             return false;
         }
@@ -335,9 +335,9 @@ 
     public function is_object_visible_onsite() : bool
     {
         return
-        (   (   midcom::get()->config->get('show_hidden_objects')
+        ((midcom::get()->config->get('show_hidden_objects')
              || $this->is_visible())
-         && (   midcom::get()->config->get('show_unapproved_objects')
+         && (midcom::get()->config->get('show_unapproved_objects')
              || $this->is_approved())
         );
     }
@@ -394,7 +394,7 @@ 
             $guid = $source;
         }
 
-        if (   $object === null
+        if ($object === null
             && mgd_is_guid($guid)) {
             try {
                 $object = midcom::get()->dbfactory->get_object_by_guid($guid);
@@ -453,7 +453,7 @@ 
      */
     public function can_unlock() : bool
     {
-        return (   midcom::get()->auth->user?->guid == $this->__object->metadata->locker
+        return (midcom::get()->auth->user?->guid == $this->__object->metadata->locker
                 || $this->__object->can_do('midcom:unlock')
                 || midcom::get()->auth->can_user_do('midcom:unlock', class: midcom_services_auth::class));
     }