flack / openpsa

lib/org/openpsa/sales/calculator/default.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 
     private function get_units($units = false) : float
     {
-        if (   $this->deliverable->invoiceByActualUnits
+        if ($this->deliverable->invoiceByActualUnits
             || $this->deliverable->plannedUnits == 0) {
             // In most cases we calculate the price based on the actual units entered
             return $units ?: $this->deliverable->units;

lib/org/openpsa/documents/elFinderVolumeOpenpsa.php

Spacing +7 added lines, -7 removed lines

@@ -67,7 +67,7 @@ 
             return $this->setError(elFinder::ERROR_UPLOAD_FILE_MIME, '(' . $mime . ')');
         }
 
-        $tmpsize = (int)sprintf('%u', filesize($tmpname));
+        $tmpsize = (int) sprintf('%u', filesize($tmpname));
         if ($this->uploadMaxSize > 0 && $tmpsize > $this->uploadMaxSize) {
             return $this->setError(elFinder::ERROR_UPLOAD_FILE_SIZE);
         }
@@ -250,7 +250,7 @@ 
         $output = [$object->get_label()];
 
         $parent = $object->get_parent();
-        while (   $parent
+        while ($parent
                && $parent->component == 'org.openpsa.documents') {
             $output[] = $parent->extra;
             $parent = $parent->get_parent();
@@ -347,12 +347,12 @@ 
             $data['mime'] = 'directory';
         }
 
-        if (   $owner
+        if ($owner
             && $group = midcom::get()->auth->get_assignee($owner)) {
             $data['group'] = $group->name;
         }
 
-        if (   $this->root !== $path
+        if ($this->root !== $path
             && $parent = $object->get_parent()) {
             $data['phash'] = $this->encode($parent->guid);
         }
@@ -411,7 +411,7 @@ 
      * @param  string $mode open mode
      * @return resource|false
      */
-    protected function _fopen($path, $mode="rb")
+    protected function _fopen($path, $mode = "rb")
     {
         $document = org_openpsa_documents_document_dba::get_cached($path);
         $attachments = blobs::get_attachments($document, 'document');
@@ -429,7 +429,7 @@ 
      * @param  string    $path  file path
      * @return bool
      */
-    protected function _fclose($fp, $path='')
+    protected function _fclose($fp, $path = '')
     {
         fclose($fp);
         return true;
@@ -611,7 +611,7 @@ 
     {
         $filename = midcom_db_attachment::safe_filename($name);
         $att = $doc->create_attachment($filename, $name, $mimetype);
-        if (   !$att
+        if (!$att
             || !$att->copy_from_handle($fp)) {
             return false;
         }

Braces +10 added lines, -5 removed lines

@@ -83,7 +83,8 @@ 
 
         $this->clearcache();
 
-        if ($file && $file['name'] === $name) { // file exists and check filename for item ID based filesystem
+        if ($file && $file['name'] === $name) {
+// file exists and check filename for item ID based filesystem
             if ($this->uploadOverwrite) {
                 if (!$file['write']) {
                     return $this->setError(elFinder::ERROR_PERM_DENIED);
@@ -139,11 +140,13 @@ 
     {
         try {
             return org_openpsa_documents_document_dba::get_cached($path);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             try {
                 return org_openpsa_documents_directory::get_cached($path);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }
@@ -275,7 +278,8 @@ 
         $object = midcom::get()->dbfactory->get_object_by_guid($path);
         try {
             $parentdir = org_openpsa_documents_directory::get_cached($parent);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return false;
         }
@@ -567,7 +571,8 @@ 
         try {
             $doc = new org_openpsa_documents_document_dba($path);
             return $doc->delete();
-        } catch (midcom_error) {
+        }
+        catch (midcom_error) {
             return false;
         }
     }

src/midcom/datamanager/extension/type/schemaType.php

Spacing +5 added lines, -5 removed lines

@@ -35,11 +35,11 @@ 
         $resolver
             ->setRequired('schema')
             ->setAllowedTypes('schema', [schema::class, 'string'])
-            ->setDefault('action', function (Options $options, $value) {
+            ->setDefault('action', function(Options $options, $value) {
                 return $options['schema']->get('action');
             });
 
-        $resolver->setNormalizer('csrf_protection', function (Options $options, $value) {
+        $resolver->setNormalizer('csrf_protection', function(Options $options, $value) {
             foreach ($options['schema']->get('fields') as $config) {
                 if ($config['widget'] === 'csrf') {
                     return true;
@@ -47,7 +47,7 @@ 
             }
             return false;
         });
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
             $validation = $options['schema']->get('validation');
             if (!empty($validation)) {
                 $cb_wrapper = new cb_wrapper($validation);
@@ -55,7 +55,7 @@ 
             }
             return $value;
         });
-        $resolver->setNormalizer('schema', function (Options $options, $value) {
+        $resolver->setNormalizer('schema', function(Options $options, $value) {
             if (is_string($value)) {
                 $schemadb = schemadb::from_path($value);
                 return $schemadb->get_first();
@@ -80,7 +80,7 @@ 
         // this is mainly there to skip validation in case the user pressed cancel
         $builder->addEventListener(FormEvents::POST_SUBMIT, function(PostSubmitEvent $event) {
             $form = $event->getForm();
-            if (   $form instanceof Form
+            if ($form instanceof Form
                 && $form->getClickedButton()
                 && $form->getClickedButton()->getConfig()->getOption('operation') == controller::CANCEL) {
                 $event->stopPropagation();

src/midcom/datamanager/extension/type/subformType.php

Spacing +3 added lines, -3 removed lines

@@ -38,7 +38,7 @@ 
                 'max_count' => 0
             ]
         ]);
-        $resolver->setNormalizer('constraints', function (Options $options, $value) {
+        $resolver->setNormalizer('constraints', function(Options $options, $value) {
             $validation = [];
             if ($options['type_config']['max_count'] > 0) {
                 $validation['max'] = $options['type_config']['max_count'];
@@ -51,12 +51,12 @@ 
             }
             return $validation;
         });
-        $resolver->setNormalizer('entry_options', function (Options $options, $value) {
+        $resolver->setNormalizer('entry_options', function(Options $options, $value) {
             return array_replace([
                 'widget_config' => $options['widget_config']
             ], (array) $value);
         });
-        $resolver->setNormalizer('widget_config', function (Options $options, $value) {
+        $resolver->setNormalizer('widget_config', function(Options $options, $value) {
             if (!array_key_exists('sortable', $value)) {
                 $value['sortable'] = false;
             }

lib/midgard/admin/asgard/style/midgard_admin_asgard_rcs_history.php

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
                 echo "                    <td>" . $formatter->datetime($revision['date'], IntlDateFormatter::MEDIUM, IntlDateFormatter::LONG) . "</td>\n";
                 echo "                    <td>";
 
-                if (   $revision['user']
+                if ($revision['user']
                     && $user = midcom::get()->auth->get_user($revision['user'])) {
                     echo $user->get_storage()->name;
                 } elseif ($revision['ip']) {

lib/org/openpsa/directmarketing/handler/message/compose.php

Spacing +2 added lines, -2 removed lines

@@ -64,7 +64,7 @@ 
         }
 
         //Substyle handling
-        if (   !empty($data['message_array']['substyle'])
+        if (!empty($data['message_array']['substyle'])
             && !str_starts_with($data['message_array']['substyle'], 'builtin:')) {
             debug_add("Appending substyle {$data['message_array']['substyle']}");
             midcom::get()->style->append_substyle($data['message_array']['substyle']);
@@ -113,7 +113,7 @@ 
     private function _real_show_compose(array $data)
     {
         $prefix = '';
-        if (   !empty($data['message_array']['substyle'])
+        if (!empty($data['message_array']['substyle'])
             && preg_match('/^builtin:(.*)/', $data['message_array']['substyle'], $matches_style)) {
             $prefix = $matches_style[1] . '-';
         }

lib/org/openpsa/slideshow/handler/edit.php

Spacing +2 added lines, -2 removed lines

@@ -61,7 +61,7 @@ 
         $images = $qb->execute();
         $failed = 0;
         foreach ($images as $image) {
-            if (   !$image->generate_image('thumbnail', $this->_config->get('thumbnail_filter'))
+            if (!$image->generate_image('thumbnail', $this->_config->get('thumbnail_filter'))
                 || !$image->generate_image('image', $this->_config->get('image_filter'))) {
                 $failed++;
             }
@@ -241,7 +241,7 @@ 
         $attachment->title = $title;
         $attachment->mimetype = $file->getMimeType();
         $attachment->parentguid = $image->guid;
-        if (   !$attachment->create()
+        if (!$attachment->create()
             || !$attachment->copy_from_file($file->getRealPath())) {
             throw new midcom_error('Failed to create attachment: ' . midcom_connection::get_error_string());
         }

Braces +2 added lines, -1 removed lines

@@ -123,7 +123,8 @@
         try {
             $this->$function($request->request, $request->files);
             $this->response['success'] = true;
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $this->response['success'] = false;
             $this->response['error'] = $e->getMessage();
         }

src/midcom/console/command/reindex.php

Braces +2 added lines, -1 removed lines

@@ -73,7 +73,8 @@
             if ($stat instanceof midcom_services_indexer_client) {
                 try {
                     $stat->reindex();
-                } catch (RequestException $e) {
+                }
+                catch (RequestException $e) {
                     if ($e->hasResponse()) {
                         $crawler = new Crawler($e->getResponse()->getBody()->getContents());
                         $body = $crawler->filterXPath('//body')->html();

lib/org/openpsa/products/viewer.php

Spacing +3 added lines, -3 removed lines

@@ -30,11 +30,11 @@
         $object = $dm->get_storage()->get_value();
 
         $document = $indexer->new_document($dm);
-        if (   $config->get('enable_scheduling')
+        if ($config->get('enable_scheduling')
             && $object instanceof org_openpsa_products_product_dba) {
             // Check start/end for products
-            if (   $object->start > time()
-                || (   $object->end != 0
+            if ($object->start > time()
+                || ($object->end != 0
                     && $object->end < time())) {
                 // Not in market, remove from index
                 $indexer->delete($document->RI);